Re: [PR] MINOR:modify scala $var to java string [kafka]

2025-04-05 Thread via GitHub
showuon commented on code in PR #18393: URL: https://github.com/apache/kafka/pull/18393#discussion_r2030056754 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java: ## @@ -470,8 +470,8 @@ public FetchDataInfo read(long startOffset, return maybeH

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-04-05 Thread via GitHub
frankvicky commented on PR #17614: URL: https://github.com/apache/kafka/pull/17614#issuecomment-2781237676 Hi @ableegoldman A huge thanks for your patience and review! šŸ™‡šŸ¼ > do you want to start working on the followup PR now to utilize this new API for KafkaStreams#close? Yes, I

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-04-05 Thread via GitHub
ableegoldman commented on PR #17614: URL: https://github.com/apache/kafka/pull/17614#issuecomment-2781223772 Merged to trunk (🄳 ) -- do you want to start working on the followup PR now to utilize this new API for `KafkaStreams#close`? This will also let us clean up the `internal.leave.group

[PR] MINOR: Cleanup 0.10.x legacy references in ClusterResourceListener and TopicConfig (clients module) [kafka]

2025-04-05 Thread via GitHub
LoganZhuZzz opened a new pull request, #19388: URL: https://github.com/apache/kafka/pull/19388 This PR is a minor follow-up to [PR #19320](https://github.com/apache/kafka/pull/19320), which cleaned up 0.10.x legacy information from the clients module. It addresses remaining reviewer

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-04-05 Thread via GitHub
ableegoldman merged PR #17614: URL: https://github.com/apache/kafka/pull/17614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-04-05 Thread via GitHub
mjsax commented on PR #19303: URL: https://github.com/apache/kafka/pull/19303#issuecomment-2781214593 Thanks for the patch! Merged to `trunk`, and cherry-picked to `4.0` and `3.9` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [MINOR] Cleanup Core Module- Scala Modules [kafka]

2025-04-05 Thread via GitHub
sjhajharia commented on PR #19380: URL: https://github.com/apache/kafka/pull/19380#issuecomment-2781209728 OffloadAndTxnConsumeFromLeaderTest -> Seems to be a flaky test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-10640: Add recursive support to Connect Cast and ReplaceField transforms, and support for casting complex types to either a native or JSON string. [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #9493: URL: https://github.com/apache/kafka/pull/9493#issuecomment-2781201685 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

[jira] [Commented] (KAFKA-19042) Move kafka.api test cases to clients-integration-tests module

2025-04-05 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941311#comment-17941311 ] PoAn Yang commented on KAFKA-19042: --- Thanks. Updated it. > Move kafka.api test cases

[jira] [Updated] (KAFKA-19042) Move kafka.api test cases to clients-integration-tests module

2025-04-05 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19042: -- Description: This is an umbrella Jira about moving integration tests from kafka.api module to clients

[jira] [Updated] (KAFKA-19042) Move kafka.api test cases to clients-integration-tests module

2025-04-05 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19042: -- Summary: Move kafka.api test cases to clients-integration-tests module (was: Move kafka.api test case

Re: [PR] KAFKA 18238 - fIdentify the first commit where a test became flaky [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #18334: URL: https://github.com/apache/kafka/pull/18334#issuecomment-2781197176 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP]KAFKA-19000 Flaky test report should use absolute time for links [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #19228: URL: https://github.com/apache/kafka/pull/19228#issuecomment-2781197134 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-04-05 Thread via GitHub
mjsax merged PR #19303: URL: https://github.com/apache/kafka/pull/19303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-18073) Data loss when exception is raised from Kafka Connect record conversion call

2025-04-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18073: Fix Version/s: (was: 4.1.0) > Data loss when exception is raised from Kafka Connect re

Re: [PR] MINOR: Move BrokerReconfigurable to the sever-common module [kafka]

2025-04-05 Thread via GitHub
frankvicky commented on code in PR #19383: URL: https://github.com/apache/kafka/pull/19383#discussion_r2030020799 ## server-common/src/main/java/org/apache/kafka/config/BrokerReconfigurable.java: ## @@ -27,13 +29,10 @@ * The reconfiguration process follows three steps: *

Re: [PR] MINOR: small optimization by judgment [kafka]

2025-04-05 Thread via GitHub
gongxuanzhang commented on PR #19386: URL: https://github.com/apache/kafka/pull/19386#issuecomment-2781166844 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Assigned] (KAFKA-19096) Skipped Records in FK join should not be marked as dropped

2025-04-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-19096: --- Assignee: Matthias J. Sax > Skipped Records in FK join should not be marked as drop

[jira] [Commented] (KAFKA-14485) Move LogCleaner to storage module

2025-04-05 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941300#comment-17941300 ] Dmitry Werner commented on KAFKA-14485: --- [~chia7712] [~mimaison] I've opened the P

[PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-05 Thread via GitHub
wernerdv opened a new pull request, #19387: URL: https://github.com/apache/kafka/pull/19387 Move LogCleaner and related classes to storage module and rewrite in Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-04-05 Thread via GitHub
AyoubOm commented on code in PR #19303: URL: https://github.com/apache/kafka/pull/19303#discussion_r2029961920 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplierTest.java: ## @@ -316,6 +367,21 @@ public void inner

[jira] [Updated] (KAFKA-19096) Skipped Records in FK join should not be marked as dropped

2025-04-05 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari updated KAFKA-19096: Description: Currently, we are logging all skipped records in FK join as dropped. This seems inco

[jira] [Created] (KAFKA-19096) Skipped Records in FK join should not be marked as dropped

2025-04-05 Thread Ayoub Omari (Jira)
Ayoub Omari created KAFKA-19096: --- Summary: Skipped Records in FK join should not be marked as dropped Key: KAFKA-19096 URL: https://issues.apache.org/jira/browse/KAFKA-19096 Project: Kafka Issu

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-05 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2022583314 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -413,24 +418,19 @@ void testRemoteLogMetadataManagerWithEndpointConfigOverridden() throws IOExc

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-05 Thread via GitHub
Rancho-7 commented on PR #19347: URL: https://github.com/apache/kafka/pull/19347#issuecomment-2772098768 To verify the behavior, I ran the tests locally using the following command,and the output is also shown below. ``` (base) lansg:kafka/ (KAFKA-19027āœ—) $ N=100; I=0; while [ $I -

Re: [PR] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-04-05 Thread via GitHub
ijuma commented on PR #19327: URL: https://github.com/apache/kafka/pull/19327#issuecomment-2781041904 OK, if the concern is that this method is unsafe in prod, it's reasonable to replace it with a test utility method. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] MINOR Mar 19 flaky tests [kafka]

2025-04-05 Thread via GitHub
mumrah merged PR #19248: URL: https://github.com/apache/kafka/pull/19248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Commented] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938882#comment-17938882 ] Chia-Ping Tsai commented on KAFKA-19050: [~utkuaydin] do you mean we should move

Re: [PR] KAFKA-18613: Unit tests for usage of incorrect RPCs [kafka]

2025-04-05 Thread via GitHub
lucasbru merged PR #18383: URL: https://github.com/apache/kafka/pull/18383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19001: Use streams group-level configurations in heartbeat [kafka]

2025-04-05 Thread via GitHub
lucasbru commented on code in PR #19219: URL: https://github.com/apache/kafka/pull/19219#discussion_r2028473669 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -8148,7 +8174,10 @@ private TaskAssignor streamsGroupAssignor(St

[jira] [Commented] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-04-05 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939766#comment-17939766 ] Stanislav Spiridonov commented on KAFKA-18713: -- # 4.0.0 is released, but th

[jira] [Created] (KAFKA-19019) Verify Share Fetch with Tiered Storage

2025-04-05 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-19019: - Summary: Verify Share Fetch with Tiered Storage Key: KAFKA-19019 URL: https://issues.apache.org/jira/browse/KAFKA-19019 Project: Kafka Issue Type: Sub-task

Re: [PR] [KAFKA-18713] Left join bug integration test [kafka]

2025-04-05 Thread via GitHub
mjsax commented on code in PR #19005: URL: https://github.com/apache/kafka/pull/19005#discussion_r2026065811 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -232,57 +236,134 @@ public void doJo

Re: [PR] KAFKA-18329; [2/3] Delete old group coordinator (KIP-848) [kafka]

2025-04-05 Thread via GitHub
dajac commented on code in PR #19251: URL: https://github.com/apache/kafka/pull/19251#discussion_r2005969287 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1635,40 +1635,8 @@ class KafkaApis(val requestChannel: RequestChannel, trace(s"End transaction marker a

Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-04-05 Thread via GitHub
Parkerhiphop commented on PR #19213: URL: https://github.com/apache/kafka/pull/19213#issuecomment-2741254322 Since the reset behavior has changed, it now resets the configs to their default values instead of leaving them empty as before. Here’s a screenshot of the reset behavior—inter

Re: [PR] MINOR: Update .asf.yaml collaborators [kafka]

2025-04-05 Thread via GitHub
mimaison commented on PR #19280: URL: https://github.com/apache/kafka/pull/19280#issuecomment-2750753505 > Somehow, I was convinced that it was executed automatically now every quarter. Me too! But it does not seem to be the case. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-19017: Changed consumer.config to command-config in verifiable_share_consumer.py [kafka]

2025-04-05 Thread via GitHub
AndrewJSchofield merged PR #19254: URL: https://github.com/apache/kafka/pull/19254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18959: increase the num_workers from 9 to 12 [kafka]

2025-04-05 Thread via GitHub
apalan60 commented on PR #19274: URL: https://github.com/apache/kafka/pull/19274#issuecomment-2759098547 I ran a few tests, and so far I have successfully invoked 14 nodes, with the tests remaining stable. ![image](https://github.com/user-attachments/assets/99c63aeb-c04c-4fe3-9be5-10

Re: [PR] MINOR: Unnecessary changeCapacity in ImplicitLinkedHashCollection [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #17893: URL: https://github.com/apache/kafka/pull/17893#issuecomment-2749985982 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on code in PR #18937: URL: https://github.com/apache/kafka/pull/18937#discussion_r2020616189 ## metadata/src/main/java/org/apache/kafka/metadata/util/SnapshotFileReader.java: ## @@ -208,8 +208,4 @@ public void close() throws Exception { beginShutdown(

Re: [PR] KAFKA-17218: kafka-consumer-groups should handle describe groups with deleted topics [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #19029: URL: https://github.com/apache/kafka/pull/19029#issuecomment-2764362494 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] [WIP] JWT bearer grant type support [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #18912: URL: https://github.com/apache/kafka/pull/18912#issuecomment-2764362509 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18329; [2/3] Delete old group coordinator (KIP-848) [kafka]

2025-04-05 Thread via GitHub
dajac merged PR #19251: URL: https://github.com/apache/kafka/pull/19251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-05 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2026267169 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1246,7 +1259,9 @@ private boolean archiveAvailableRecords(long startOffset, long endOffset

[jira] [Assigned] (KAFKA-19004) Move DelayedDeleteRecords to server-common module

2025-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-19004: -- Assignee: xuanzhang gong (was: Chia-Ping Tsai) > Move DelayedDeleteRecords to server

Re: [PR] KAFKA-18713: Fix FK Left-Join result race condition [kafka]

2025-04-05 Thread via GitHub
nilmadhab commented on PR #19005: URL: https://github.com/apache/kafka/pull/19005#issuecomment-2774512670 @mjsax LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-05 Thread via GitHub
ijuma commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2743945863 @OmniaGM Would you like someone to help get this over the finish line? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-04-05 Thread via GitHub
lianetm commented on code in PR #19281: URL: https://github.com/apache/kafka/pull/19281#discussion_r2016344814 ## core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala: ## @@ -37,15 +37,17 @@ import java.lang.{Byte => JByte} import java.util.Collections

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-05 Thread via GitHub
apoorvmittal10 commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013454652 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,259 @@ private long startOffsetDuringInitialization(long partitionDataStartOff

[jira] [Created] (KAFKA-19021) Broker should not be allowed to be promoted to controller

2025-04-05 Thread Jira
JosƩ Armando Garcƭa Sancio created KAFKA-19021: -- Summary: Broker should not be allowed to be promoted to controller Key: KAFKA-19021 URL: https://issues.apache.org/jira/browse/KAFKA-19021

Re: [PR] MINOR: Optimize the 'waitForVerifyAssignment' method log output [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #17753: URL: https://github.com/apache/kafka/pull/17753#issuecomment-2739046191 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-19024 Enhance the client behaviour when it tries to exceed the `group.share.max.groups` [kafka]

2025-04-05 Thread via GitHub
AndrewJSchofield commented on PR #19313: URL: https://github.com/apache/kafka/pull/19313#issuecomment-2772915350 @DL1231 Of course, the reason is that the limit is being applied per group coordinator shard. Hmmm. This is not so straightforward. -- This is an automated message from the Apa

Re: [PR] KAFKA-18754: Allow `PlainSaslServer` to pass client info through the negotiated properties. [kafka]

2025-04-05 Thread via GitHub
bachmanity1 commented on PR #18828: URL: https://github.com/apache/kafka/pull/18828#issuecomment-2765563652 > > but we're facing an issue—PlainSaslServer can only pass the authorizationID to the authorizer, meaning the client info is lost. > > Have you considered implementing a custom

[jira] [Created] (KAFKA-19074) Remove the cached responseData from ShareFetchResponse

2025-04-05 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19074: -- Summary: Remove the cached responseData from ShareFetchResponse Key: KAFKA-19074 URL: https://issues.apache.org/jira/browse/KAFKA-19074 Project: Kafka Is

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-05 Thread via GitHub
TaiJuWu commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2028375807 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -103,6 +105,9 @@ public void onMetadataUpdate(MetadataDelta delta, MetadataImage

Re: [PR] MINOR: Remove unused `ApiKeys.minRequiredInterBrokerMagic` [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on code in PR #19325: URL: https://github.com/apache/kafka/pull/19325#discussion_r2021372461 ## clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java: ## @@ -67,11 +66,11 @@ public enum ApiKeys { DELETE_RECORDS(ApiMessageType.DELETE_RECORDS)

Re: [PR] KAFKA-19004:Move DelayedDeleteRecords to server-common module [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on code in PR #19226: URL: https://github.com/apache/kafka/pull/19226#discussion_r2020587635 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1282,8 +1281,31 @@ class ReplicaManager(val config: KafkaConfig, } if (delayedDeleteRecord

[PR] MINOR: FindCoordinator API does not lookup partition for share partition key correctly [kafka]

2025-04-05 Thread via GitHub
dajac opened a new pull request, #19273: URL: https://github.com/apache/kafka/pull/19273 This patch fixes another bug in the FindCoordinator API handling for share partition key. `shareCoordinator.foreach` returns `Unit` so `shareCoordinator.foreach(coordinator => coordinator.partitionFor(

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-04-05 Thread via GitHub
ijuma commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2009192580 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -286,4 +291,12 @@ private static FetchResponseData toMessage(Errors error,

Re: [PR] MINOR: Cleanup test-common-runtime module [kafka]

2025-04-05 Thread via GitHub
chia7712 merged PR #19305: URL: https://github.com/apache/kafka/pull/19305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-19051) Fix implicit acknowledgement cannot be override when RecordDeserializationException occurs

2025-04-05 Thread Jira
FrƩdƩrik ROULEAU created KAFKA-19051: Summary: Fix implicit acknowledgement cannot be override when RecordDeserializationException occurs Key: KAFKA-19051 URL: https://issues.apache.org/jira/browse/KAFKA-19051

Re: [PR] KAFKA-19062: Port changes from KAFKA-18645 to share-consumers [kafka]

2025-04-05 Thread via GitHub
ShivsundarR commented on code in PR #19335: URL: https://github.com/apache/kafka/pull/19335#discussion_r2022361659 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -250,6 +251,7 @@ private enum AcknowledgementMode {

[jira] [Commented] (KAFKA-19079) KIP-890 Cleanups

2025-04-05 Thread oshione gabriel esiemokhai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940811#comment-17940811 ] oshione gabriel esiemokhai commented on KAFKA-19079: hello ,what doe

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-04-05 Thread via GitHub
frankvicky commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2011287595 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Updated] (KAFKA-19026) AlterConfigPolicy incompatibility between ZK mode and KRaft mode when using AlterConfigOp.OpType.SUBTRACT

2025-04-05 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-19026: -- Attachment: KAFKA19026Test.java > AlterConfigPolicy incompatibility between ZK mode and KRaft

Re: [PR] KAFKA-16616: refactor mergeWith and updatePartitionLeadership [kafka]

2025-04-05 Thread via GitHub
kirktrue commented on PR #19199: URL: https://github.com/apache/kafka/pull/19199#issuecomment-2767702063 @lorcanj—Looking at the [test history of `CooperativeConsumerCoordinatorTest.testOutdatedCoordinatorAssignment()`](https://develocity.apache.org/scans/tests?search.relativeStartTime=P28D&

Re: [PR] KAFKA-18991: FetcherThread should match leader epochs between fetch request and fetch state [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on PR #19223: URL: https://github.com/apache/kafka/pull/19223#issuecomment-2752082932 > The fixed version for [KAFKA-18723](https://issues.apache.org/jira/browse/KAFKA-18723) already includes 3.9.1 and 4.0.1? I grep the git history , and KAFKA-18723 is not in 4.0/3

Re: [PR] KAFKA-19025: Reuse LZ4 buffers for compression [kafka]

2025-04-05 Thread via GitHub
squah-confluent closed pull request #19260: KAFKA-19025: Reuse LZ4 buffers for compression URL: https://github.com/apache/kafka/pull/19260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests [kafka]

2025-04-05 Thread via GitHub
jsancio commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r2004145500 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -475,6 +563,99 @@ void canRecoverFromSingleNodeCommittedDataLoss( scheduler.run

[PR] Mar 18 Testing [kafka-merge-queue-sandbox]

2025-04-05 Thread via GitHub
mumrah opened a new pull request, #63: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/63 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] MINOR: Update Mockito on 3.9 for Java 23 support [kafka]

2025-04-05 Thread via GitHub
srdo opened a new pull request, #19367: URL: https://github.com/apache/kafka/pull/19367 This was done on trunk in 6a37d5ccebaa6bbfc1d1b943f0ff761cf978da7d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on PR #19327: URL: https://github.com/apache/kafka/pull/19327#issuecomment-2781010552 @ijuma thanks for your explanation. I do agree that there is no strict requirement of removing a test-only method. However, `nodeEndpoints` is crucial for handling specific errors like `

Re: [PR] Trying again [kafka-merge-queue-sandbox]

2025-04-05 Thread via GitHub
mumrah merged PR #68: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] [MINOR] Cleanup Server Common Module [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on PR #19085: URL: https://github.com/apache/kafka/pull/19085#issuecomment-2742992871 @sjhajharia could you please rebase code? there is a build error if I apply this PR on the trunk. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on code in PR #18795: URL: https://github.com/apache/kafka/pull/18795#discussion_r2004284732 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -432,7 +439,14 @@ protected Map prepareFetchRequests()

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

2025-04-05 Thread via GitHub
smjn commented on code in PR #19328: URL: https://github.com/apache/kafka/pull/19328#discussion_r2024607201 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1365,6 +1368,67 @@ public CompletableFuture describeShareGroup

[jira] [Resolved] (KAFKA-18827) Initialize share group state impl

2025-04-05 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan resolved KAFKA-18827. - Resolution: Fixed > Initialize share group state impl >

[jira] [Commented] (KAFKA-19068) Eliminate the duplicate type check in creating ControlRecord

2025-04-05 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940093#comment-17940093 ] Nick Guo commented on KAFKA-19068: -- Hi [~chia7712] ,I would like to handle this.Thanks!

[PR] KAFKA-15931: Cancel RemoteLogReader gracefully [kafka]

2025-04-05 Thread via GitHub
jeqo opened a new pull request, #19331: URL: https://github.com/apache/kafka/pull/19331 Backports f24945b519005c0bc7a28db2db7aae6cec158927 to 4.0 Instead of reopening the transaction index, it cancels the RemoteFetchTask without interrupting it--avoiding to close the TransactionIndex

[jira] [Updated] (KAFKA-19012) Messages ending up on the wrong topic

2025-04-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19012: -- Component/s: clients producer > Messages ending up on the wrong topic >

Re: [PR] Another change but this time with a long title. What happens if the title is over 72 characters? I guess we'll find out. [kafka-merge-queue-sandbox]

2025-04-05 Thread via GitHub
mumrah merged PR #66: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] Minor: Add functionalinterface to the producer callback [kafka]

2025-04-05 Thread via GitHub
Tombert commented on code in PR #19366: URL: https://github.com/apache/kafka/pull/19366#discussion_r2027542000 ## clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgementCommitCallback.java: ## @@ -34,6 +34,7 @@ * The callback may be executed in any thread calli

Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

2025-04-05 Thread via GitHub
fvaleri commented on code in PR #19198: URL: https://github.com/apache/kafka/pull/19198#discussion_r1999330309 ## docs/upgrade.html: ## @@ -72,10 +72,8 @@ Upgrading Servers to 4.0.0 from brokers will be running the latest version and you can verify that the cluster's

Re: [PR] [WIP] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-04-05 Thread via GitHub
JimmyWang6 commented on PR #18929: URL: https://github.com/apache/kafka/pull/18929#issuecomment-2765640456 Hi @AndrewJSchofield, Sorry for the delay. I've been occupied with other tasks recently, but I will start to work on this issue as soon as possible. Much thanks for your help. --

[jira] [Created] (KAFKA-19030) Remove metricNamePrefix from RequestChannel

2025-04-05 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19030: -- Summary: Remove metricNamePrefix from RequestChannel Key: KAFKA-19030 URL: https://issues.apache.org/jira/browse/KAFKA-19030 Project: Kafka Issue Type: I

Re: [PR] MINOR VerifableProducer ducktape can set idempotency and retries [kafka]

2025-04-05 Thread via GitHub
josefk31 commented on PR #19362: URL: https://github.com/apache/kafka/pull/19362#issuecomment-2776483452 Testing: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (KAFKA-19003) Add force-terminate feature to kafka-transactions CLI and Admin Client

2025-04-05 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy resolved KAFKA-19003. -- Resolution: Fixed > Add force-terminate feature to kafka-transactions CLI and Admin Client >

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-04-05 Thread via GitHub
ijuma commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r200354 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -234,9 +229,10 @@ * successful writes are marked as aborted, hence keeping the tran

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

2025-04-05 Thread via GitHub
Tombert commented on code in PR #19234: URL: https://github.com/apache/kafka/pull/19234#discussion_r2025864206 ## streams/src/main/java/org/apache/kafka/streams/kstream/EmitStrategy.java: ## @@ -29,6 +29,7 @@ /** * This interface controls the strategy that can be used to cont

[jira] [Commented] (KAFKA-15580) KIP-966: Unclean Recovery

2025-04-05 Thread Jonah Hooper (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940127#comment-17940127 ] Jonah Hooper commented on KAFKA-15580: -- This is being actively worked on; the actua

Re: [PR] KAFKA-18845: Fix flaky QuorumControllerTest#testUncleanShutdownBrokerElrEnabled [kafka]

2025-04-05 Thread via GitHub
mumrah commented on code in PR #19240: URL: https://github.com/apache/kafka/pull/19240#discussion_r2004033069 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -376,10 +375,12 @@ public void testElrEnabledByDefault() throws Throwable {

[jira] [Assigned] (KAFKA-19080) The constraint on segment.ms is not enforced at topic level

2025-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-19080: -- Assignee: é»ƒē«£é™½ > The constraint on segment.ms is not enforced at topic level > ---

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-04-05 Thread via GitHub
wernerdv commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2007200264 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogToClean.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[jira] [Comment Edited] (KAFKA-17354) StreamThread::setState race condition causes java.lang.RuntimeException: State mismatch PENDING_SHUTDOWN different from STARTING

2025-04-05 Thread Ao Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939350#comment-17939350 ] Ao Li edited comment on KAFKA-17354 at 3/28/25 11:41 PM: - We rec

Re: [PR] KAFKA-19084: Port KAFKA-16224, KAFKA-16764 for ShareConsumers [kafka]

2025-04-05 Thread via GitHub
smjn commented on code in PR #19369: URL: https://github.com/apache/kafka/pull/19369#discussion_r2028490277 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -971,9 +971,11 @@ private void handlePartitionError(ShareAckno

Re: [PR] KAFKA-18329; [1/3] Delete old group coordinator (KIP-848) [kafka]

2025-04-05 Thread via GitHub
dajac merged PR #19243: URL: https://github.com/apache/kafka/pull/19243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-19003) Add force-terminate command to kafka-transactions CLI

2025-04-05 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-19003: - Description: TheĀ {{kafka-transactions.sh}} tool is going to support a new command forceTerminate

[jira] [Created] (KAFKA-19056) Move EndToEndClusterIdTest to server module

2025-04-05 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19056: -- Summary: Move EndToEndClusterIdTest to server module Key: KAFKA-19056 URL: https://issues.apache.org/jira/browse/KAFKA-19056 Project: Kafka Issue Type: I

[jira] [Resolved] (KAFKA-19055) Cleanup the 0.10.x information from clients module

2025-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19055. Fix Version/s: 4.1.0 Resolution: Fixed > Cleanup the 0.10.x information from client

[jira] [Updated] (KAFKA-19061) Add ACL changes to enable role based 2PC

2025-04-05 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-19061: - Description: *transaction.max.timeout.ms*Ā guarantees that an ongoing transaction is aborted wit

  1   2   3   >