chia7712 commented on code in PR #18795:
URL: https://github.com/apache/kafka/pull/18795#discussion_r2004284732
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##########
@@ -432,7 +439,14 @@ protected Map<Node, FetchSessionHandler.FetchRequestData>
prepareFetchRequests()
// going to be failed anyway before being sent, so skip
sending the request for now
log.trace("Skipping fetch for partition {} because node {} is
awaiting reconnect backoff", partition, node);
} else if (nodesWithPendingFetchRequests.contains(node.id())) {
+ // If there's already an inflight request for this node, don't
issue another request.
log.trace("Skipping fetch for partition {} because previous
request to {} has not been processed", partition, node);
+ } else if (bufferedNodes.contains(node.id())) {
Review Comment:
Sorry that I don't follow whole discussion of this PR, but I have a small
question for this condition.
Is it impossible for server A to have a pending fetch request when the
consumer is still processing records from server A? If so, does this constraint
reduce concurrency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
