adixitconfluent commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2026267169
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1246,7 +1259,9 @@ private boolean archiveAvailableRecords(long startOffset,
long endOffset, Naviga
private boolean archivePerOffsetBatchRecords(InFlightBatch inFlightBatch,
long startOffsetToArchive,
- long endOffsetToArchive) {
+ long endOffsetToArchive,
+ RecordState initialState
+ ) {
Review Comment:
I made the change as per this review comment
https://github.com/apache/kafka/pull/19261#discussion_r2022398987 but I agree
that this file has the convention to use `) { ` on the end of the parameter
line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
