ijuma commented on code in PR #19057:
URL: https://github.com/apache/kafka/pull/19057#discussion_r1982857330
##
clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java:
##
@@ -20,13 +20,33 @@
import org.apache.kafka.common.KafkaFuture;
import java.u
ijuma commented on PR #19131:
URL: https://github.com/apache/kafka/pull/19131#issuecomment-2703049893
I'll update the KIP once this is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chirag-wadhwa5 closed pull request #19108: KAFKA-18811: Included
admin.client.config in VerifiableShareConsumer.java
URL: https://github.com/apache/kafka/pull/19108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chirag-wadhwa5 opened a new pull request, #19130:
URL: https://github.com/apache/kafka/pull/19130
This PR includes a new flag in VerifiableShareConsumer.java called
admin.client.config to include a properties file for admin client related
configs
Reference: [KAFKA-18811](https://issu
[
https://issues.apache.org/jira/browse/KAFKA-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932852#comment-17932852
]
Chia-Ping Tsai commented on KAFKA-18246:
revert:
https://github.com/apache/kafk
leaf-soba commented on code in PR #18684:
URL: https://github.com/apache/kafka/pull/18684#discussion_r1982759489
##
server-common/src/main/java/org/apache/kafka/timeline/Snapshot.java:
##
@@ -47,6 +48,7 @@ T getDelta(Revertable owner) {
}
void setDelta(Revertable ow
[
https://issues.apache.org/jira/browse/KAFKA-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18910.
Fix Version/s: 4.1.0
Resolution: Fixed
> Remove kafka.utils.json
> ---
[
https://issues.apache.org/jira/browse/KAFKA-18927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932840#comment-17932840
]
Chia-Ping Tsai commented on KAFKA-18927:
[~ijuma] yes, you are right. I will rev
[
https://issues.apache.org/jira/browse/KAFKA-18928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-18928:
--
Assignee: xuanzhang gong (was: Chia-Ping Tsai)
> Support to dynamically change confi
[
https://issues.apache.org/jira/browse/KAFKA-18788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Dixit updated KAFKA-18788:
--
Description:
The current simple assignor doesn't offer perfect sharing between share
consumer
[
https://issues.apache.org/jira/browse/KAFKA-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18246.
Fix Version/s: 4.1.0
(was: 4.0.0)
Resolution: Fixed
> Fix Co
[
https://issues.apache.org/jira/browse/KAFKA-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932839#comment-17932839
]
Chia-Ping Tsai commented on KAFKA-18246:
run the e2e "tests/kafkatest/tests/conn
[
https://issues.apache.org/jira/browse/KAFKA-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reopened KAFKA-18246:
> Fix ConnectRestApiTest.test_rest_api by adding multiversioning configs
> ---
[
https://issues.apache.org/jira/browse/KAFKA-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932837#comment-17932837
]
Chia-Ping Tsai commented on KAFKA-18246:
I will revert this from 4.0 to follow K
[
https://issues.apache.org/jira/browse/KAFKA-18928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932833#comment-17932833
]
xuanzhang gong commented on KAFKA-18928:
Hi,i will handle this issue ,plz assign
[
https://issues.apache.org/jira/browse/KAFKA-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932826#comment-17932826
]
TengYao Chi commented on KAFKA-18067:
-
Hi [~ableegoldman]
Thanks for the informati
sjhajharia commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2702786625
Sure @mumrah
Will keep that in mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ijuma commented on PR #18917:
URL: https://github.com/apache/kafka/pull/18917#issuecomment-2702772140
Interesting, so the record implementation of `hashCode` is significantly
faster than the previous implementation.
--
This is an automated message from the Apache Git Service.
To respond t
github-actions[bot] commented on PR #18789:
URL: https://github.com/apache/kafka/pull/18789#issuecomment-2702684614
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
frankvicky commented on code in PR #18600:
URL: https://github.com/apache/kafka/pull/18600#discussion_r1982650451
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java:
##
@@ -795,21 +800,20 @@ public void testFetchSnapshotRequestAsLeader(boolean
withKip8
[
https://issues.apache.org/jira/browse/KAFKA-18927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932814#comment-17932814
]
Ismael Juma commented on KAFKA-18927:
-
The change here is basically reverting the ch
github-actions[bot] commented on PR #17248:
URL: https://github.com/apache/kafka/pull/17248#issuecomment-2702713397
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] closed pull request #17248: KAFKA-17552: Handle
LIST_OFFSETS request for max_timestamp when remote storage is enabled
URL: https://github.com/apache/kafka/pull/17248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
chia7712 commented on code in PR #19100:
URL: https://github.com/apache/kafka/pull/19100#discussion_r1982635141
##
docs/zk2kraft.html:
##
@@ -153,6 +153,67 @@ Configurations
+Dynamic Log Levels
+
+
+
+The
Chia-Ping Tsai created KAFKA-18928:
--
Summary: Support to dynamically change config for specific
controller
Key: KAFKA-18928
URL: https://issues.apache.org/jira/browse/KAFKA-18928
Project: Kafka
github-actions[bot] commented on PR #19035:
URL: https://github.com/apache/kafka/pull/19035#issuecomment-2702684508
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #18912:
URL: https://github.com/apache/kafka/pull/18912#issuecomment-2702684563
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #18711:
URL: https://github.com/apache/kafka/pull/18711#issuecomment-2702684656
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
frankvicky commented on code in PR #19099:
URL: https://github.com/apache/kafka/pull/19099#discussion_r1982611756
##
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##
@@ -482,6 +482,30 @@ class DynamicBrokerReconfigurationTest extends
Quoru
[
https://issues.apache.org/jira/browse/KAFKA-18927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-18927:
--
Assignee: Cheng Yi Chang (was: Chia-Ping Tsai)
> Remove LATEST_0_11, LATEST_1_0, LAT
[
https://issues.apache.org/jira/browse/KAFKA-18927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932812#comment-17932812
]
Cheng Yi Chang commented on KAFKA-18927:
Hi, [~chia7712]
Could you please assi
[
https://issues.apache.org/jira/browse/KAFKA-18927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932808#comment-17932808
]
Chia-Ping Tsai commented on KAFKA-18927:
from https://github.com/apache/kafka/pu
chia7712 commented on PR #18988:
URL: https://github.com/apache/kafka/pull/18988#issuecomment-2702645351
> Seems we can simplify the docker build and cleanup some more code as
follow up.
open https://issues.apache.org/jira/browse/KAFKA-18927
--
This is an automated message from the
Chia-Ping Tsai created KAFKA-18927:
--
Summary: Remove LATEST_0_11, LATEST_1_0, LATEST_1_1,LATEST_2_0
Key: KAFKA-18927
URL: https://issues.apache.org/jira/browse/KAFKA-18927
Project: Kafka
chia7712 merged PR #19109:
URL: https://github.com/apache/kafka/pull/19109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-18861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932787#comment-17932787
]
A. Sophie Blee-Goldman commented on KAFKA-18861:
Sounds like a similar s
[
https://issues.apache.org/jira/browse/KAFKA-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932798#comment-17932798
]
Lan Ding commented on KAFKA-18925:
--
Hi [~lucasbru] , are we ready to do this? I'm happy
[
https://issues.apache.org/jira/browse/KAFKA-18819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932797#comment-17932797
]
Lan Ding commented on KAFKA-18819:
--
Hi [~lucasbru] , are we ready to do this? I'm happy
mumrah opened a new pull request, #19128:
URL: https://github.com/apache/kafka/pull/19128
Trying something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
[
https://issues.apache.org/jira/browse/KAFKA-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932795#comment-17932795
]
David Arthur commented on KAFKA-18921:
--
The Timeline section of build scans added C
cmccabe opened a new pull request, #19127:
URL: https://github.com/apache/kafka/pull/19127
The kafka controllers need to set kraft.version in their ApiVersionsResponse
messages according to the current kraft.version reported by the Raft layer.
Instead, currently they always set it to 0.
[
https://issues.apache.org/jira/browse/KAFKA-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-18920:
-
Summary: The kcontrollers do not set kraft.version in ApiVersionsResponse
(was: kafka-feature d
zheguang commented on code in PR #19121:
URL: https://github.com/apache/kafka/pull/19121#discussion_r1982385169
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##
@@ -254,34 +284,131 @@ public StreamsGroupHeartbeatRe
mumrah closed pull request #19123: TESTING update readme
URL: https://github.com/apache/kafka/pull/19123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on code in PR #19104:
URL: https://github.com/apache/kafka/pull/19104#discussion_r1980994112
##
docs/zk2kraft.html:
##
@@ -57,7 +57,7 @@ Configurations
In KRaft mode, Kafka eliminates its dependency on ZooKeeper,
and the control
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1982298361
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3637,6 +3637,11 @@ QuorumState quorum() {
return quorum;
}
+// Visible o
ableegoldman commented on PR #19089:
URL: https://github.com/apache/kafka/pull/19089#issuecomment-2702232938
ah, good catch, and thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
mumrah merged PR #19126:
URL: https://github.com/apache/kafka/pull/19126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mumrah opened a new pull request, #19126:
URL: https://github.com/apache/kafka/pull/19126
Change the `strict` value to false. Follow-up of #19124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932778#comment-17932778
]
A. Sophie Blee-Goldman commented on KAFKA-18067:
thanks for catching thi
[
https://issues.apache.org/jira/browse/KAFKA-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-18067:
---
Fix Version/s: 4.1.0
> Kafka Streams can leak Producer client under EOS
> --
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1982287669
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3637,6 +3637,11 @@ QuorumState quorum() {
return quorum;
}
+// Visible onl
[
https://issues.apache.org/jira/browse/KAFKA-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932770#comment-17932770
]
A. Sophie Blee-Goldman commented on KAFKA-18921:
[~davidarthur] is there
bbejeck commented on code in PR #19116:
URL: https://github.com/apache/kafka/pull/19116#discussion_r1982259039
##
clients/src/main/java/org/apache/kafka/clients/admin/DescribeStreamsGroupsResult.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
mumrah merged PR #19124:
URL: https://github.com/apache/kafka/pull/19124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1982280759
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -550,14 +576,17 @@ void canAddObserverAndRemovePartitionedVoter(
initializeC
ahuang98 commented on code in PR #19079:
URL: https://github.com/apache/kafka/pull/19079#discussion_r1982266631
##
metadata/src/main/java/org/apache/kafka/image/ClientQuotasImage.java:
##
@@ -126,40 +144,45 @@ public DescribeClientQuotasResponseData
describe(DescribeClientQuota
ijuma commented on PR #18685:
URL: https://github.com/apache/kafka/pull/18685#issuecomment-2702191844
Let's add a test please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
ableegoldman commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r1982252797
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -1151,31 +1153,28 @@ protected void handlePollTimeoutExpiry()
mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r1982210800
##
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslClient.java:
##
@@ -190,7 +190,7 @@ private void setState(State state) {
priv
mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r1982214194
##
metadata/src/main/java/org/apache/kafka/metadata/storage/ScramParser.java:
##
@@ -173,7 +173,8 @@ byte[] saltedPassword(byte[] salt, int iterations) throws
Excepti
mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r198021
##
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramSaslClient.java:
##
@@ -190,7 +190,7 @@ private void setState(State state) {
priv
mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r1982207332
##
metadata/src/main/java/org/apache/kafka/metadata/storage/ScramParser.java:
##
@@ -173,7 +173,9 @@ byte[] saltedPassword(byte[] salt, int iterations) throws
Excepti
mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r1982216871
##
core/src/main/scala/kafka/server/DelegationTokenManager.scala:
##
@@ -100,13 +100,13 @@ class DelegationTokenManager(val config: KafkaConfig,
}
/**
- * @p
mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r1982214194
##
metadata/src/main/java/org/apache/kafka/metadata/storage/ScramParser.java:
##
@@ -173,7 +173,8 @@ byte[] saltedPassword(byte[] salt, int iterations) throws
Excepti
Iamoshione commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2702116652
@AndrewJSchofield Branch updated with trunk. Please let me know if any
further changes are needed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to
AndrewJSchofield commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2702110906
@Iamoshione Please could you update the branch with the latest changes from
trunk. I will need a green build of up-to-date code to merge.
--
This is an automated message from t
Iamoshione commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2702105935
@AndrewJSchofield Apologies for the oversight—I didn’t notice it on time.
I’ve now addressed the request as specified. Let me know if any further changes
are needed. Thanks!
--
This
mumrah commented on code in PR #19113:
URL: https://github.com/apache/kafka/pull/19113#discussion_r1982166952
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java:
##
@@ -1062,6 +1065,24 @@ private void ensureExplicitAcknowledgement() {
cherylws opened a new pull request, #19125:
URL: https://github.com/apache/kafka/pull/19125
- Adding a space, article and punctuation to the doc strings for consistency
and readability.
If you would like to tag individuals, add some commentary, upload images, or
include other suppl
mumrah opened a new pull request, #19124:
URL: https://github.com/apache/kafka/pull/19124
We need to reapply this asf.yaml change, so first setting it to "true"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
AndrewJSchofield commented on code in PR #19077:
URL: https://github.com/apache/kafka/pull/19077#discussion_r1982140648
##
docs/security.html:
##
@@ -2366,4 +2374,4 @@
security.inter.broker.protocol=SSL
-
Review Comment:
I still do not see why this PR contains this fin
[
https://issues.apache.org/jira/browse/KAFKA-18054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932736#comment-17932736
]
Lorcan commented on KAFKA-18054:
Hi [~ableegoldman], I’ve done some investigation into t
mumrah opened a new pull request, #19123:
URL: https://github.com/apache/kafka/pull/19123
Just testing a new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
ahuang98 commented on code in PR #18600:
URL: https://github.com/apache/kafka/pull/18600#discussion_r1982108615
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java:
##
@@ -795,21 +800,20 @@ public void testFetchSnapshotRequestAsLeader(boolean
withKip853
ahuang98 commented on code in PR #18600:
URL: https://github.com/apache/kafka/pull/18600#discussion_r1982108615
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java:
##
@@ -795,21 +800,20 @@ public void testFetchSnapshotRequestAsLeader(boolean
withKip853
ahuang98 commented on PR #18600:
URL: https://github.com/apache/kafka/pull/18600#issuecomment-2701942128
@frankvicky let me know when you need another review, I spot checked some of
the comments I left earlier that you thumbs up-ed and it seems they haven't all
been addressed yet
--
This
[
https://issues.apache.org/jira/browse/KAFKA-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-18925:
Component/s: streams
> Add streams groups support in Admin.listGroups.
> -
ahuang98 commented on code in PR #18600:
URL: https://github.com/apache/kafka/pull/18600#discussion_r1982110708
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java:
##
@@ -52,13 +54,19 @@
import java.util.concurrent.atomic.AtomicLong;
import java.util.
mumrah merged PR #19122:
URL: https://github.com/apache/kafka/pull/19122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mumrah commented on code in PR #19122:
URL: https://github.com/apache/kafka/pull/19122#discussion_r1981908712
##
.asf.yaml:
##
@@ -45,3 +45,19 @@ github:
squash_commit_message: PR_TITLE_AND_DESC
merge: false
rebase: false
+
+ protected_branches:
+trunk:
+
Iamoshione commented on PR #19077:
URL: https://github.com/apache/kafka/pull/19077#issuecomment-2701858209
@AndrewJSchofield Hello there I have adjusted the indentation and removed
the unnecessary div tag at the end of the page
--
This is an automated message from the Apache Git Service.
jsancio commented on PR #18685:
URL: https://github.com/apache/kafka/pull/18685#issuecomment-2701811371
@FrankYang0529 is this still a WIP? I would like to get this fixed and
included in the 4.0.0 release. cc @dajac @junrao
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932713#comment-17932713
]
Mahsa Seifikar commented on KAFKA-18920:
There is a similar Jira ticket
https:/
Iamoshione closed pull request #19077: KAFKA-18766:Docs: Make usage of
allow.everyone.if.no.acl.found config clearer
URL: https://github.com/apache/kafka/pull/19077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932712#comment-17932712
]
Jun Rao commented on KAFKA-18477:
-
[~chia7712] : Good point. If the follower doesn't hav
azhar2407 commented on code in PR #19099:
URL: https://github.com/apache/kafka/pull/19099#discussion_r1981949803
##
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##
@@ -482,6 +482,30 @@ class DynamicBrokerReconfigurationTest extends
Quorum
ijuma commented on code in PR #19100:
URL: https://github.com/apache/kafka/pull/19100#discussion_r1981944751
##
docs/zk2kraft.html:
##
@@ -153,6 +153,67 @@ Configurations
+Dynamic Log Levels
+
+
+
+The dyn
cmccabe commented on code in PR #19100:
URL: https://github.com/apache/kafka/pull/19100#discussion_r1981933910
##
docs/zk2kraft.html:
##
@@ -153,6 +153,67 @@ Configurations
+Dynamic Log Levels
+
+
+
+The d
cmccabe commented on code in PR #19100:
URL: https://github.com/apache/kafka/pull/19100#discussion_r1981929991
##
docs/zk2kraft.html:
##
@@ -153,6 +153,67 @@ Configurations
+Dynamic Log Levels
+
+
+
+The d
junrao commented on code in PR #18726:
URL: https://github.com/apache/kafka/pull/18726#discussion_r1981925892
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -106,7 +106,7 @@
]},
{ "name": "PreferredReadReplica", "type": "int32", "version
smjn commented on code in PR #19057:
URL: https://github.com/apache/kafka/pull/19057#discussion_r1981910462
##
clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java:
##
@@ -20,13 +20,33 @@
import org.apache.kafka.common.KafkaFuture;
import java.ut
mumrah commented on code in PR #19122:
URL: https://github.com/apache/kafka/pull/19122#discussion_r1981908712
##
.asf.yaml:
##
@@ -45,3 +45,19 @@ github:
squash_commit_message: PR_TITLE_AND_DESC
merge: false
rebase: false
+
+ protected_branches:
+trunk:
+
AndrewJSchofield commented on code in PR #19057:
URL: https://github.com/apache/kafka/pull/19057#discussion_r1981904870
##
clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java:
##
@@ -20,13 +20,33 @@
import org.apache.kafka.common.KafkaFuture;
im
mumrah commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2701677430
@sjhajharia just a quick note -- if you force push your branch after someone
has reviewed your PR, it basically destroys the history of the review and
inline conversations. It's best to me
junrao commented on code in PR #19057:
URL: https://github.com/apache/kafka/pull/19057#discussion_r1981900730
##
clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupsResult.java:
##
@@ -20,13 +20,33 @@
import org.apache.kafka.common.KafkaFuture;
import java.
mumrah commented on code in PR #18684:
URL: https://github.com/apache/kafka/pull/18684#discussion_r1981899587
##
server-common/src/main/java/org/apache/kafka/timeline/Snapshot.java:
##
@@ -47,6 +48,7 @@ T getDelta(Revertable owner) {
}
void setDelta(Revertable owner
mumrah commented on PR #18684:
URL: https://github.com/apache/kafka/pull/18684#issuecomment-270121
Can you please merge trunk into this PR and let the CI run again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
AndrewJSchofield commented on code in PR #19077:
URL: https://github.com/apache/kafka/pull/19077#discussion_r1981867953
##
docs/security.html:
##
@@ -1248,11 +1248,16 @@ https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+Interface";>KIP-11
and
resourc
mumrah commented on PR #19122:
URL: https://github.com/apache/kafka/pull/19122#issuecomment-2701616024
Here's how Pulsar has their repo configured:
https://github.com/apache/pulsar/blob/master/.asf.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message
1 - 100 of 251 matches
Mail list logo
