mumrah commented on code in PR #19122:
URL: https://github.com/apache/kafka/pull/19122#discussion_r1981908712


##########
.asf.yaml:
##########
@@ -45,3 +45,19 @@ github:
     squash_commit_message: PR_TITLE_AND_DESC
     merge: false
     rebase: false
+
+  protected_branches:
+    trunk:
+      required_status_checks:
+        strict: false
+        contexts:
+          - build / CI checks completed

Review Comment:
   BTW this name comes from the Checks API.
   
   ```
   gh api \
     -H "Accept: application/vnd.github+json" \
     -H "X-GitHub-Api-Version: 2022-11-28" \
     
/repos/apache/kafka/commits/d64df5162bf08b96c1483b143d6ca77a48c35aaf/check-runs
   ```
   
   returns a list of check runs. We want the `name` of the run to use in 
.asf.yaml.
   
   ```
   ...
     {
         "id": 38237327961,
         "name": "build / Compile and Check (Merge Ref)", <-- This
         "node_id": "CR_kwDOACG9q88AAAAI5x9SWQ",
         "head_sha": "d64df5162bf08b96c1483b143d6ca77a48c35aaf",
         "external_id": "5f14810a-731d-5037-cdc7-5b433ffc2634",
         "url": 
"https://api.github.com/repos/apache/kafka/check-runs/38237327961";,
         "html_url": 
"https://github.com/apache/kafka/actions/runs/13676254784/job/38237327961";,
         "details_url": 
"https://github.com/apache/kafka/actions/runs/13676254784/job/38237327961";,
         "status": "completed",
         "conclusion": "success",
         "started_at": "2025-03-05T12:42:54Z",
         "completed_at": "2025-03-05T12:48:32Z",
         "output": {
           "title": null,
           "summary": null,
           "text": null,
           "annotations_count": 0,
           "annotations_url": 
"https://api.github.com/repos/apache/kafka/check-runs/38237327961/annotations";
         },
   ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to