frankvicky commented on code in PR #18782:
URL: https://github.com/apache/kafka/pull/18782#discussion_r1938906951
##
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorLoader.java:
##
@@ -49,50 +49,7 @@ public short unknownType() {
* Ob
frankvicky commented on code in PR #18783:
URL: https://github.com/apache/kafka/pull/18783#discussion_r1938894196
##
server/src/main/java/org/apache/kafka/server/Assignment.java:
##
@@ -96,23 +57,6 @@ boolean valid(int nodeId, MetadataImage image) {
return Replicas.cont
frankvicky commented on code in PR #18783:
URL: https://github.com/apache/kafka/pull/18783#discussion_r1938893604
##
server-common/src/main/java/org/apache/kafka/server/common/TopicIdPartition.java:
##
@@ -18,45 +18,15 @@
import org.apache.kafka.common.Uuid;
-import java.ut
frankvicky opened a new pull request, #18783:
URL: https://github.com/apache/kafka/pull/18783
JIRA: KAFKA-18698
The following are the classes that might be converted to records:
```
server-common:
TopicIdPartition
RequestAndCompletionHandler
FinalizedFeatures
server:
[
https://issues.apache.org/jira/browse/KAFKA-18297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-18297:
--
Assignee: Yu-Lin Chen (was: Chia-Ping Tsai)
> Fix flaky PlaintextAdminIntegrationTes
chenyulin0719 commented on PR #18513:
URL: https://github.com/apache/kafka/pull/18513#issuecomment-2630121780
@dajac Thanks for the review. I've updated this PR with below 2 changes:
1. Call `consumer.wakeup` before setting stop flag
2. Remove `consumerThread.interrupt()` from close()
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1938869089
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4004,6 +3922,82 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
Rancho-7 opened a new pull request, #18782:
URL: https://github.com/apache/kafka/pull/18782
jira: https://issues.apache.org/jira/browse/KAFKA-18694
As title.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test co
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1938857657
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4003,6 +3939,77 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1938864992
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2204,270 +2172,238 @@ class PlaintextAdminIntegrationTest extends
BaseAd
[
https://issues.apache.org/jira/browse/KAFKA-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 updated KAFKA-18697:
Priority: Minor (was: Major)
> Migrate suitable classes to records in connect module
> --
[
https://issues.apache.org/jira/browse/KAFKA-18701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 updated KAFKA-18701:
Priority: Minor (was: Major)
> Migrate suitable classes to records in trogdor and tools module
>
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1938857657
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4003,6 +3939,77 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1938841407
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1838,250 +1838,218 @@ class PlaintextAdminIntegrationTest extends
BaseAd
[
https://issues.apache.org/jira/browse/KAFKA-18701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923190#comment-17923190
]
Mingdao Yang commented on KAFKA-18701:
--
Hi [~m1a2st] , I'd like to work on this iss
[
https://issues.apache.org/jira/browse/KAFKA-18701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingdao Yang reassigned KAFKA-18701:
Assignee: Mingdao Yang (was: 黃竣陽)
> Migrate suitable classes to records in trogdor and t
[
https://issues.apache.org/jira/browse/KAFKA-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingdao Yang reassigned KAFKA-18703:
Assignee: Mingdao Yang (was: 黃竣陽)
> Remove unused class PayloadKeyType
> ---
[
https://issues.apache.org/jira/browse/KAFKA-18703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923188#comment-17923188
]
Mingdao Yang commented on KAFKA-18703:
--
Hi [~m1a2st] , I'd like to work on this iss
[
https://issues.apache.org/jira/browse/KAFKA-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923187#comment-17923187
]
Chia-Ping Tsai commented on KAFKA-18697:
agree to [~gharris1727] that we should
[
https://issues.apache.org/jira/browse/KAFKA-18699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923186#comment-17923186
]
TengYao Chi commented on KAFKA-18699:
-
Go for it.
These classes are from quick scan
[
https://issues.apache.org/jira/browse/KAFKA-18702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923182#comment-17923182
]
TengYao Chi edited comment on KAFKA-18702 at 2/3/25 6:20 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-18698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TengYao Chi reassigned KAFKA-18698:
---
Assignee: TengYao Chi (was: Ming-Yen Chung)
> Migrate suitable classes to records in serve
[
https://issues.apache.org/jira/browse/KAFKA-18698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923185#comment-17923185
]
TengYao Chi commented on KAFKA-18698:
-
i have started working on it, feel free to gr
[
https://issues.apache.org/jira/browse/KAFKA-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923184#comment-17923184
]
黃竣陽 commented on KAFKA-18697:
-
Thanks for [~gharris1727] reminder, I will take a look which
[
https://issues.apache.org/jira/browse/KAFKA-18694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TengYao Chi updated KAFKA-18694:
Summary: Migrate suitable classes to recorods in coordinator-common module
(was: Convert LoadSumm
chia7712 merged PR #18768:
URL: https://github.com/apache/kafka/pull/18768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-18698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923183#comment-17923183
]
Ming-Yen Chung commented on KAFKA-18698:
Hi [~frankvicky] , could you assign thi
[
https://issues.apache.org/jira/browse/KAFKA-18702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923182#comment-17923182
]
TengYao Chi commented on KAFKA-18702:
-
go ahead
> Migrate suitable classes to recor
[
https://issues.apache.org/jira/browse/KAFKA-18698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ming-Yen Chung reassigned KAFKA-18698:
--
Assignee: Ming-Yen Chung (was: TengYao Chi)
> Migrate suitable classes to records in
[
https://issues.apache.org/jira/browse/KAFKA-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923179#comment-17923179
]
Ming-Yen Chung commented on KAFKA-18700:
Hi [~frankvicky] , could you assign thi
chia7712 commented on code in PR #18768:
URL: https://github.com/apache/kafka/pull/18768#discussion_r1938829155
##
tests/kafkatest/sanity_checks/test_verifiable_producer.py:
##
@@ -32,25 +31,21 @@ def __init__(self, test_context):
super(TestVerifiableProducer, self).__i
[
https://issues.apache.org/jira/browse/KAFKA-18702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923180#comment-17923180
]
Ming-Yen Chung commented on KAFKA-18702:
Hi [~frankvicky] , could you assign thi
[
https://issues.apache.org/jira/browse/KAFKA-18699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923181#comment-17923181
]
Ming-Yen Chung commented on KAFKA-18699:
Hi [~frankvicky] , could you assign thi
[
https://issues.apache.org/jira/browse/KAFKA-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ming-Yen Chung reassigned KAFKA-18700:
--
Assignee: Ming-Yen Chung (was: TengYao Chi)
> Migrate suitable classes to records in
[
https://issues.apache.org/jira/browse/KAFKA-18699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ming-Yen Chung reassigned KAFKA-18699:
--
Assignee: Ming-Yen Chung (was: TengYao Chi)
> Migrate suitable classes to records in
[
https://issues.apache.org/jira/browse/KAFKA-18702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ming-Yen Chung reassigned KAFKA-18702:
--
Assignee: Ming-Yen Chung (was: TengYao Chi)
> Migrate suitable classes to records in
黃竣陽 created KAFKA-18703:
---
Summary: Remove unused class PayloadKeyType
Key: KAFKA-18703
URL: https://issues.apache.org/jira/browse/KAFKA-18703
Project: Kafka
Issue Type: Improvement
Reporter
[
https://issues.apache.org/jira/browse/KAFKA-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923177#comment-17923177
]
Greg Harris commented on KAFKA-18697:
-
I think classes in the `connect-api` module s
[
https://issues.apache.org/jira/browse/KAFKA-18701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 updated KAFKA-18701:
Parent: KAFKA-18696
Issue Type: Sub-task (was: Test)
> Migrate suitable classes to records in trogdor and
TengYao Chi created KAFKA-18702:
---
Summary: Migrate suitable classes to records in storage module
Key: KAFKA-18702
URL: https://issues.apache.org/jira/browse/KAFKA-18702
Project: Kafka
Issue Typ
TengYao Chi created KAFKA-18700:
---
Summary: Migrate suitable classes to records in raft and
connector-common modules
Key: KAFKA-18700
URL: https://issues.apache.org/jira/browse/KAFKA-18700
Project: Kafka
黃竣陽 created KAFKA-18701:
---
Summary: Migrate suitable classes to records in trogdor and tools
module
Key: KAFKA-18701
URL: https://issues.apache.org/jira/browse/KAFKA-18701
Project: Kafka
Issue Type: Te
[
https://issues.apache.org/jira/browse/KAFKA-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 updated KAFKA-18697:
Summary: Migrate suitable classes to records in connect module (was:
Migrate connect module suitable classes to r
TengYao Chi created KAFKA-18699:
---
Summary: Migrate suitable classes to records in metadata
Key: KAFKA-18699
URL: https://issues.apache.org/jira/browse/KAFKA-18699
Project: Kafka
Issue Type: Sub
黃竣陽 created KAFKA-18697:
---
Summary: Migrate connect module suitable classes to records
Key: KAFKA-18697
URL: https://issues.apache.org/jira/browse/KAFKA-18697
Project: Kafka
Issue Type: Test
[
https://issues.apache.org/jira/browse/KAFKA-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 updated KAFKA-18697:
Parent: KAFKA-18696
Issue Type: Sub-task (was: Test)
> Migrate connect module suitable classes to records
TengYao Chi created KAFKA-18698:
---
Summary: Migrate suitable classes to records in server and
server-common modules
Key: KAFKA-18698
URL: https://issues.apache.org/jira/browse/KAFKA-18698
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18674.
Resolution: Fixed
trunk:
[https://github.com/apache/kafka/commit/9d6faf028346e1c46867241d
[
https://issues.apache.org/jira/browse/KAFKA-18694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TengYao Chi updated KAFKA-18694:
Parent: KAFKA-18696
Issue Type: Sub-task (was: Improvement)
> Convert LoadSummary to reco
chia7712 merged PR #18751:
URL: https://github.com/apache/kafka/pull/18751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TengYao Chi updated KAFKA-18696:
Description: Since most of modules are using Java 17, we could pass through
these modules and migr
TengYao Chi created KAFKA-18696:
---
Summary: Migrate suitable classes to records
Key: KAFKA-18696
URL: https://issues.apache.org/jira/browse/KAFKA-18696
Project: Kafka
Issue Type: Task
[
https://issues.apache.org/jira/browse/KAFKA-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-18695:
--
Assignee: Ming-Yen Chung (was: Chia-Ping Tsai)
> Remove quorum=kraft from all integr
Chia-Ping Tsai created KAFKA-18695:
--
Summary: Remove quorum=kraft from all integration tests
Key: KAFKA-18695
URL: https://issues.apache.org/jira/browse/KAFKA-18695
Project: Kafka
Issue Type
[
https://issues.apache.org/jira/browse/KAFKA-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923173#comment-17923173
]
Ming-Yen Chung commented on KAFKA-18695:
Hi [~chia7712] , could you assign this
chia7712 commented on PR #18770:
URL: https://github.com/apache/kafka/pull/18770#issuecomment-2630015893
open https://issues.apache.org/jira/browse/KAFKA-18695 to log the cleanup of
`quorum=kraft`
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
[
https://issues.apache.org/jira/browse/KAFKA-18694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-18694:
--
Assignee: Nick Guo (was: Chia-Ping Tsai)
> Convert LoadSummary to record
> -
mingyen066 commented on PR #18751:
URL: https://github.com/apache/kafka/pull/18751#issuecomment-2629988494
Hi @chia7712 , absolutely! I've created PR #18781, which includes a unit
test for verify invalid format in 4.0. PTAL. Thank you!"
--
This is an automated message from the Apache Git
mingyen066 opened a new pull request, #18781:
URL: https://github.com/apache/kafka/pull/18781
As in https://github.com/apache/kafka/pull/18751#issuecomment-2629747083
"The only difference from #18767 is moving the space-separated broker list
from a valid address to an invalid one."
chia7712 commented on PR #18770:
URL: https://github.com/apache/kafka/pull/18770#issuecomment-2629984162
> For this same reason @RepeatedTest does not work with @ParameterizedTest.
Given that most use cases of @ParameterizedTest are now redundant since all
integration tests are using
chia7712 commented on code in PR #18775:
URL: https://github.com/apache/kafka/pull/18775#discussion_r1938784255
##
docs/zk2kraft.html:
##
@@ -198,6 +198,9 @@ Removal metrics
kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation=topic
chia7712 commented on code in PR #18770:
URL: https://github.com/apache/kafka/pull/18770#discussion_r1938769937
##
.github/actions/run-gradle/action.yml:
##
@@ -52,15 +67,21 @@ runs:
TIMEOUT_MINUTES: ${{ inputs.timeout-minutes}}
TEST_CATALOG: ${{ inputs.test-ca
mingyen066 commented on code in PR #18767:
URL: https://github.com/apache/kafka/pull/18767#discussion_r1938760663
##
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java:
##
@@ -96,6 +100,20 @@ public void
testParseAndValidateAddressesWithReverseLookup() {
[
https://issues.apache.org/jira/browse/KAFKA-18694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923169#comment-17923169
]
Nick Guo commented on KAFKA-18694:
--
Hi [~chia7712] ,if you are not working on this,I wo
mingyen066 commented on code in PR #18767:
URL: https://github.com/apache/kafka/pull/18767#discussion_r1938760255
##
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java:
##
@@ -96,6 +100,20 @@ public void
testParseAndValidateAddressesWithReverseLookup() {
chia7712 commented on code in PR #18749:
URL: https://github.com/apache/kafka/pull/18749#discussion_r1938757450
##
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRecordSerde.java:
##
@@ -76,6 +76,11 @@ public CoordinatorRecord deserialize
Chia-Ping Tsai created KAFKA-18694:
--
Summary: Convert LoadSummary to record
Key: KAFKA-18694
URL: https://issues.apache.org/jira/browse/KAFKA-18694
Project: Kafka
Issue Type: Improvement
mjsax commented on PR #18780:
URL: https://github.com/apache/kafka/pull/18780#issuecomment-2629852948
Java 17 passed.
Java 23 had no test failures, but build did not pass. No idea what happened:
```
76 PASSED ✅, 0 FAILED ❌, 0 FLAKY ⚠️ , 1 SKIPPED 🙈, 76 QUARANTINED 😷, and 0
error
chia7712 commented on code in PR #18683:
URL: https://github.com/apache/kafka/pull/18683#discussion_r1938735858
##
clients/src/test/java/org/apache/kafka/common/security/JaasContextTest.java:
##
@@ -68,11 +70,13 @@ public void tearDown() throws Exception {
@Test
publ
chia7712 commented on code in PR #18641:
URL: https://github.com/apache/kafka/pull/18641#discussion_r1938724850
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -48,13 +48,6 @@ import scala.collection._
import scala.jdk.CollectionConverters._
/**
- * Dyn
github-actions[bot] commented on PR #17685:
URL: https://github.com/apache/kafka/pull/17685#issuecomment-2629823559
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] closed pull request #14605: KAFKA-15143: Adding in
MockFixedKeyProcessorContext and Test
URL: https://github.com/apache/kafka/pull/14605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] closed pull request #14333: MINOR: Explain need to escape
backslashes in rules
URL: https://github.com/apache/kafka/pull/14333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on PR #14605:
URL: https://github.com/apache/kafka/pull/14605#issuecomment-2629822783
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] commented on PR #14333:
URL: https://github.com/apache/kafka/pull/14333#issuecomment-2629822717
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-2629822661
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] closed pull request #13817: KAFKA-15062: Adding ppc64le
build stage
URL: https://github.com/apache/kafka/pull/13817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
chia7712 commented on code in PR #18764:
URL: https://github.com/apache/kafka/pull/18764#discussion_r1938719117
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -362,23 +361,6 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
Chia-Ping Tsai created KAFKA-18693:
--
Summary: Remove PasswordEncoder
Key: KAFKA-18693
URL: https://issues.apache.org/jira/browse/KAFKA-18693
Project: Kafka
Issue Type: Improvement
github-actions[bot] commented on PR #18709:
URL: https://github.com/apache/kafka/pull/18709#issuecomment-2629796047
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
chia7712 commented on code in PR #18196:
URL: https://github.com/apache/kafka/pull/18196#discussion_r1938692432
##
core/src/test/java/kafka/test/api/CustomQuotaCallbackTest.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
chia7712 commented on PR #18751:
URL: https://github.com/apache/kafka/pull/18751#issuecomment-2629747083
@mingyen066 could you please copy the unit test of #18767 to 4.0? the other
format should be failed in 4.0
--
This is an automated message from the Apache Git Service.
To respond to th
chia7712 commented on code in PR #18767:
URL: https://github.com/apache/kafka/pull/18767#discussion_r1938677914
##
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java:
##
@@ -96,6 +100,20 @@ public void
testParseAndValidateAddressesWithReverseLookup() {
chia7712 merged PR #18753:
URL: https://github.com/apache/kafka/pull/18753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938397250
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -146,8 +146,7 @@ public void shouldNotAllowNullNameWhenAddingProcessor() {
@Test
pu
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938397352
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -2338,7 +2338,6 @@ private TopologyDescription.Sink addSink(final String
sinkName,
re
junrao commented on PR #18770:
URL: https://github.com/apache/kafka/pull/18770#issuecomment-2629585537
@mumrah : Thanks for the PR. Before, the test report has a section "Parse
junit tests" that summarizes the test results. It seems gone in the new test
results?
--
This is an automated m
mjsax commented on code in PR #18780:
URL: https://github.com/apache/kafka/pull/18780#discussion_r1938590363
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -2338,7 +2338,6 @@ private TopologyDescription.Sink addSink(final String
sinkName,
re
mjsax commented on code in PR #18780:
URL: https://github.com/apache/kafka/pull/18780#discussion_r1938590264
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -2257,16 +2257,16 @@ private Topology topologyWithStaticTopicName() {
private TopologyDe
mjsax opened a new pull request, #18780:
URL: https://github.com/apache/kafka/pull/18780
Introduced via KIP-1106.
Needs to be cherry-picked to `4.0` branch, to avoid shipping a new feature
with this bug. \cc @dajac
--
This is an automated message from the Apache Git Service.
To re
[
https://issues.apache.org/jira/browse/KAFKA-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923143#comment-17923143
]
Matthias J. Sax commented on KAFKA-4212:
Had some more discussion with [~hartmutc
[
https://issues.apache.org/jira/browse/KAFKA-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923144#comment-17923144
]
Matthias J. Sax commented on KAFKA-4273:
Had some more discussion with [~hartmutc
mjsax commented on code in PR #18771:
URL: https://github.com/apache/kafka/pull/18771#discussion_r1938568837
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -156,11 +156,8 @@ private void registerMetrics() {
(co
ijuma commented on PR #18770:
URL: https://github.com/apache/kafka/pull/18770#issuecomment-2629534407
Makes sense. I agree that unit tests should be generally stable and, if
they're not, they should be considered integration tests.
--
This is an automated message from the Apache Git Servi
[
https://issues.apache.org/jira/browse/KAFKA-18692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923140#comment-17923140
]
Matthias J. Sax commented on KAFKA-18692:
-
Sure... Let's see how it goes.
> Con
mumrah commented on PR #18770:
URL: https://github.com/apache/kafka/pull/18770#issuecomment-2629530430
@ijuma we could do this easily for any integration tests using
`@ClusterTest` since we already have `kafka.cluster.test.repeat`. When I added
that, I looked into doing it for regular unit
ijuma commented on PR #18770:
URL: https://github.com/apache/kafka/pull/18770#issuecomment-2629507278
Very nice - I think for the "new test suite" case, we also want to run the
new tests multiple times. Perhaps 3 passes with no retries would be a
reasonable bar?
--
This is an automated m
mumrah commented on PR #18770:
URL: https://github.com/apache/kafka/pull/18770#issuecomment-2629488567
@junrao following up on our discussion from #18681. This shows how we could
run new tests separately in PRs.
Here's a run of how it might look
https://github.com/apache/kafka/action
freedge commented on PR #10333:
URL: https://github.com/apache/kafka/pull/10333#issuecomment-2629454178
did you ever find a workaround for this @iatsuk ? I posted
https://lists.apache.org/thread/z1n5vz8fd4to15rj1n0p9wt5rvlzr6j3 on the same
subject.
--
This is an automated message from th
frankvicky commented on code in PR #18767:
URL: https://github.com/apache/kafka/pull/18767#discussion_r1938520943
##
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java:
##
@@ -96,6 +100,20 @@ public void
testParseAndValidateAddressesWithReverseLookup() {
1 - 100 of 113 matches
Mail list logo
