chia7712 commented on code in PR #18683:
URL: https://github.com/apache/kafka/pull/18683#discussion_r1938735858
##########
clients/src/test/java/org/apache/kafka/common/security/JaasContextTest.java:
##########
@@ -68,11 +70,13 @@ public void tearDown() throws Exception {
@Test
public void testConfigNoOptions() throws Exception {
+ System.setProperty(ALLOWED_LOGIN_MODULES_CONFIG,
"test.testConfigNoOptions");
Review Comment:
Adding this change means we break some compatibility ...
1. print warning message if users define the
`org.apache.kafka.disallowed.login.modules`
2. adopt the `org.apache.kafka.allowed.login.modules` if it is existent
3. evaluate the modules according to `DISALLOWED_LOGIN_MODULES_DEFAULT`
Additionally, we should open a jira for 5.0 to add
`ALLOWED_LOGIN_MODULES_DEFAULT`
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
