chia7712 commented on code in PR #18764:
URL: https://github.com/apache/kafka/pull/18764#discussion_r1938719117
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -362,23 +361,6 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
dynamicConfigPasswordEncoder.getOrElse(throw new ConfigException("Password
encoder secret not configured"))
}
- private[server] def toPersistentProps(configProps: Properties,
perBrokerConfig: Boolean): Properties = {
- val props = configProps.clone().asInstanceOf[Properties]
-
- def encodePassword(configName: String, value: String): Unit = {
- if (value != null) {
- if (!perBrokerConfig)
- throw new ConfigException("Password config can be defined only at
broker level")
- props.setProperty(configName, passwordEncoder.encode(new
Password(value)))
- }
- }
- configProps.asScala.foreachEntry { (name, value) =>
- if (isPasswordConfig(name))
- encodePassword(name, value)
- }
- props
- }
Review Comment:
that is a legacy code of zk and I open
https://issues.apache.org/jira/browse/KAFKA-18693 to do fully cleanup. Hence,
could you please revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
