Re: [PR] KAFKA-18487; Remove ReplicaManager#stopReplicas [kafka]

2025-01-20 Thread via GitHub
dajac commented on PR #18647: URL: https://github.com/apache/kafka/pull/18647#issuecomment-2603882097 Resolved the conflicts and removed `StopReplicaPartitionState`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-18604; Update transaction coordinator [kafka]

2025-01-20 Thread via GitHub
dajac merged PR #18636: URL: https://github.com/apache/kafka/pull/18636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-18604) Update transaction coordinator

2025-01-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-18604. - Fix Version/s: 4.1.0 Resolution: Fixed > Update transaction coordinator > ---

Re: [PR] MINOR: Cleanup ControllerContext and StateChangeLogger [kafka]

2025-01-20 Thread via GitHub
frankvicky commented on code in PR #18588: URL: https://github.com/apache/kafka/pull/18588#discussion_r1923031399 ## core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala: ## @@ -43,25 +42,25 @@ class AddPartitionsTest extends BaseRequestTest { val partitionId = 0

[jira] [Updated] (KAFKA-18508) Remove ControllerContext

2025-01-20 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-18508: Summary: Remove ControllerContext (was: Cleanup ControllerContext) > Remove ControllerContext > -

Re: [PR] KAFKA-10462: Add ability to pass headers to ProducerPerformance. [kafka]

2025-01-20 Thread via GitHub
github-actions[bot] commented on PR #17462: URL: https://github.com/apache/kafka/pull/17462#issuecomment-2603590473 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] MINOR: Cleanup ControllerContext and StateChangeLogger [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18588: URL: https://github.com/apache/kafka/pull/18588#discussion_r1923027838 ## core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala: ## @@ -43,25 +42,25 @@ class AddPartitionsTest extends BaseRequestTest { val partitionId = 0 val

Re: [PR] KAFKA-18383: Remove reserved.broker.max.id, broker.id.generation.enable, and broker.id [kafka]

2025-01-20 Thread via GitHub
FrankYang0529 commented on PR #18478: URL: https://github.com/apache/kafka/pull/18478#issuecomment-2603581863 Hi @chia7712, I resolved conflict and CI passes. Could you take a look when you have time? Thank you. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] MINOR: Cleanup ControllerContext and StateChangeLogger [kafka]

2025-01-20 Thread via GitHub
frankvicky commented on PR #18588: URL: https://github.com/apache/kafka/pull/18588#issuecomment-2603553237 Hi @ijuma Thanks for the reminder. I have updated the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Commented] (KAFKA-18606) Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest

2025-01-20 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914825#comment-17914825 ] kangning.li commented on KAFKA-18606: - [~m1a2st]   I will take this issue.    :) >

[jira] [Assigned] (KAFKA-18606) Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest

2025-01-20 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kangning.li reassigned KAFKA-18606: --- Assignee: kangning.li > Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTe

Re: [PR] MINOR: restore `testGetAllTopicMetadataShouldNotCreateTopicOrReturnUnknownTopicPartition` [kafka]

2025-01-20 Thread via GitHub
TaiJuWu commented on code in PR #18633: URL: https://github.com/apache/kafka/pull/18633#discussion_r1923004162 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -3562,6 +3562,47 @@ class KafkaApisTest extends Logging { assertEquals(Set(0), response.brokers

[jira] [Resolved] (KAFKA-14552) Assume a baseline of 3.0 for server protocol versions

2025-01-20 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-14552. - Resolution: Fixed > Assume a baseline of 3.0 for server protocol versions >

Re: [PR] MINOR: Cleanup ControllerContext and StateChangeLogger [kafka]

2025-01-20 Thread via GitHub
ijuma commented on PR #18588: URL: https://github.com/apache/kafka/pull/18588#issuecomment-2603503446 KAFKA-18427 has been resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] KAFKA-18583 Fix getPartitionReplicaEndpoints for KRaft [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18635: URL: https://github.com/apache/kafka/pull/18635#discussion_r1922987880 ## core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala: ## @@ -511,6 +512,101 @@ class MetadataCacheTest { assertEquals(initialBrokerIds.toSet, aliveBroker

Re: [PR] KAFKA-18583 Fix getPartitionReplicaEndpoints for KRaft [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18635: URL: https://github.com/apache/kafka/pull/18635#discussion_r1922987533 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -433,7 +433,7 @@ class KRaftMetadataCache( val image = _currentImage val result = n

Re: [PR] KAFKA-18487; Remove ReplicaManager#stopReplicas [kafka]

2025-01-20 Thread via GitHub
ijuma commented on PR #18647: URL: https://github.com/apache/kafka/pull/18647#issuecomment-2603496337 Conflicts need to be resolved. Once those are done, you should be able to delete the following class in `ReplicaManager`: > case class StopReplicaPartitionState(leaderEpoch: Int, dele

[PR] KAFKA-17951: Share parition rotate strategy [kafka]

2025-01-20 Thread via GitHub
apoorvmittal10 opened a new pull request, #18651: URL: https://github.com/apache/kafka/pull/18651 Defined PartitionRotateStrategy class and round robin implementation for partitions. This is required to let not starve any single partition during share-fetch. ### Committer Checklist (

Re: [PR] KAFKA-14552: Assume a baseline of 3.0 for server protocol versions [kafka]

2025-01-20 Thread via GitHub
ijuma merged PR #18497: URL: https://github.com/apache/kafka/pull/18497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] MINOR: Improve javadoc for ListShareGroupOffsetsResult [kafka]

2025-01-20 Thread via GitHub
AndrewJSchofield opened a new pull request, #18650: URL: https://github.com/apache/kafka/pull/18650 Small improvement to the javadoc. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status -

[PR] KAFKA-18392: Ensure client sets member ID for share group [kafka]

2025-01-20 Thread via GitHub
AndrewJSchofield opened a new pull request, #18649: URL: https://github.com/apache/kafka/pull/18649 To align with KIP-1082, share group members always assign the member ID in the consumer. This was actually already the case and already being enforced by checking of the `ShareGroupHeartbeat`

Re: [PR] KAFKA-17894: Implemented broker topic metrics for Share Group 1/N (KIP-1103) [kafka]

2025-01-20 Thread via GitHub
apoorvmittal10 commented on code in PR #18444: URL: https://github.com/apache/kafka/pull/18444#discussion_r1922820173 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -598,6 +632,12 @@ void processShareFetch(ShareFetch shareFetch) { sharePa

[jira] [Commented] (KAFKA-18369) State updater's *-ratio metrics are incorrect

2025-01-20 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914788#comment-17914788 ] Rafał Sumisławski commented on KAFKA-18369: --- {quote}We sum up the actually tim

Re: [PR] [KAFKA-18454] Publish build scans to develocity.apache.org [kafka]

2025-01-20 Thread via GitHub
chia7712 commented on PR #18539: URL: https://github.com/apache/kafka/pull/18539#issuecomment-2603152098 merge trunk to run QA again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] KAFKA-18360: Remove zookeeper configurations [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18566: URL: https://github.com/apache/kafka/pull/18566#discussion_r1922794753 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -221,8 +213,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) def quotaConfig: Qu

[jira] [Commented] (KAFKA-18607) Update jfreechart dependency

2025-01-20 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914784#comment-17914784 ] Divij Vaidya commented on KAFKA-18607: -- Piggy backing in https://github.com/apache/

[jira] [Assigned] (KAFKA-18607) Update jfreechart dependency

2025-01-20 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-18607: Assignee: Divij Vaidya > Update jfreechart dependency > > >

[jira] [Commented] (KAFKA-18422) add Kafka client upgrade path

2025-01-20 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914783#comment-17914783 ] Ismael Juma commented on KAFKA-18422: - Yes, right - I meant no changes to the non te

Re: [PR] KAFKA-14552: Assume a baseline of 3.0 for server protocol versions [kafka]

2025-01-20 Thread via GitHub
ijuma commented on PR #18497: URL: https://github.com/apache/kafka/pull/18497#issuecomment-2603122568 Assuming the tests look good, I'll merge this. If @jolshan, @cmccabe and/or @jsancio have any comments (for the questions I asked or otherwise), I'll address them in a follow-up. -- This

[jira] [Created] (KAFKA-18607) Update jfreechart dependency

2025-01-20 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-18607: Summary: Update jfreechart dependency Key: KAFKA-18607 URL: https://issues.apache.org/jira/browse/KAFKA-18607 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-18404) Remove partitionMaxBytes from DelayedShareFetch

2025-01-20 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-18404: Fix Version/s: 4.1.0 (was: 4.0.0) > Remove partitionMaxBytes from DelayedSh

Re: [PR] Revert "KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch (#17870" [kafka]

2025-01-20 Thread via GitHub
AndrewJSchofield merged PR #18643: URL: https://github.com/apache/kafka/pull/18643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-14552: Assume a baseline of 3.0 for server protocol versions [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18497: URL: https://github.com/apache/kafka/pull/18497#discussion_r1922780149 ## clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java: ## @@ -144,10 +151,12 @@ public static RequestHeader parse(ByteBuffer buffer) {

Re: [PR] Revert "KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch (#17870" [kafka]

2025-01-20 Thread via GitHub
apoorvmittal10 commented on PR #18643: URL: https://github.com/apache/kafka/pull/18643#issuecomment-2603109609 Unrelated test failure on Java 17, build passed on Java 23. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-18360: Remove zookeeper configurations [kafka]

2025-01-20 Thread via GitHub
chia7712 commented on code in PR #18566: URL: https://github.com/apache/kafka/pull/18566#discussion_r1922782866 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -221,8 +213,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) def quotaConfig:

Re: [PR] KAFKA-18383: Remove reserved.broker.max.id, broker.id.generation.enable, and broker.id [kafka]

2025-01-20 Thread via GitHub
chia7712 commented on PR #18478: URL: https://github.com/apache/kafka/pull/18478#issuecomment-2603108549 pending for the discussion https://github.com/apache/kafka/pull/18566/files#r1922782866 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] KAFKA-14552: Assume a baseline of 3.0 for server protocol versions [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18497: URL: https://github.com/apache/kafka/pull/18497#discussion_r1922781434 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -35,7 +35,6 @@ import scala.jdk.CollectionConverters._ import scala.collection._ import scala.collection.mutabl

Re: [PR] KAFKA-18585 Fix fail test ValuesTest#shouldConvertDateValues [kafka]

2025-01-20 Thread via GitHub
AndrewJSchofield commented on code in PR #18611: URL: https://github.com/apache/kafka/pull/18611#discussion_r1922780851 ## connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java: ## @@ -901,8 +902,12 @@ public void shouldConvertDateValues() { assertEqua

[PR] MINOR: Update dependencies [kafka]

2025-01-20 Thread via GitHub
divijvaidya opened a new pull request, #18648: URL: https://github.com/apache/kafka/pull/18648 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Updated] (KAFKA-18383) Remove reserved.broker.max.id, broker.id.generation.enable, and broker.id

2025-01-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18383: --- Fix Version/s: 4.0.0 > Remove reserved.broker.max.id, broker.id.generation.enable, and broke

[jira] [Updated] (KAFKA-18383) Remove reserved.broker.max.id, broker.id.generation.enable, and broker.id

2025-01-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18383: --- Priority: Blocker (was: Major) > Remove reserved.broker.max.id, broker.id.generation.enable

Re: [PR] KAFKA-18383: Remove reserved.broker.max.id, broker.id.generation.enable, and broker.id [kafka]

2025-01-20 Thread via GitHub
chia7712 commented on PR #18478: URL: https://github.com/apache/kafka/pull/18478#issuecomment-2603092406 @FrankYang0529 please fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-18585 Fix fail test ValuesTest#shouldConvertDateValues [kafka]

2025-01-20 Thread via GitHub
divijvaidya commented on code in PR #18611: URL: https://github.com/apache/kafka/pull/18611#discussion_r1922774801 ## connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java: ## @@ -901,8 +902,12 @@ public void shouldConvertDateValues() { assertEquals(cu

[jira] [Commented] (KAFKA-18422) add Kafka client upgrade path

2025-01-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914775#comment-17914775 ] Chia-Ping Tsai commented on KAFKA-18422: {quote} Also, no code changes are requ

[jira] [Updated] (KAFKA-18591) Remove QuotaConfgHandler

2025-01-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18591: --- Fix Version/s: 4.1.0 (was: 4.0.0) > Remove QuotaConfgHandler > --

[jira] [Resolved] (KAFKA-18591) Remove QuotaConfgHandler

2025-01-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18591. Resolution: Fixed trunk: https://github.com/apache/kafka/commit/837fb1ed0250837c2d9578ce0

Re: [PR] KAFKA-18591: Remove unused QuotaConfgHandler [kafka]

2025-01-20 Thread via GitHub
chia7712 merged PR #18617: URL: https://github.com/apache/kafka/pull/18617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18530 Rename ZooKeeperInternals [kafka]

2025-01-20 Thread via GitHub
chia7712 commented on code in PR #18641: URL: https://github.com/apache/kafka/pull/18641#discussion_r1922770484 ## server-common/src/main/java/org/apache/kafka/server/config/KraftInternals.java: ## @@ -16,12 +16,11 @@ */ package org.apache.kafka.server.config; -public class

Re: [PR] KAFKA-14552: Assume a baseline of 3.0 for server protocol versions [kafka]

2025-01-20 Thread via GitHub
chia7712 commented on code in PR #18497: URL: https://github.com/apache/kafka/pull/18497#discussion_r1922745759 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -35,7 +35,6 @@ import scala.jdk.CollectionConverters._ import scala.collection._ import scala.collection.mut

Re: [PR] KAFKA-14552: Assume a baseline of 3.0 for server protocol versions [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18497: URL: https://github.com/apache/kafka/pull/18497#discussion_r1922647268 ## generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java: ## @@ -355,28 +362,9 @@ private void generateHeaderVersion(String type) {

[jira] [Updated] (KAFKA-18089) RemoteIndexCacheTest fails with caffeine > 3.1.1

2025-01-20 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-18089: - Labels: newbie (was: ) > RemoteIndexCacheTest fails with caffeine > 3.1.1 > ---

Re: [PR] KAFKA-18519: Remove Json.scala, cleanup AclEntry.scala [kafka]

2025-01-20 Thread via GitHub
mimaison commented on code in PR #18614: URL: https://github.com/apache/kafka/pull/18614#discussion_r1922719641 ## server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java: ## @@ -55,96 +44,17 @@ import static org.apache.kafka.common.acl.AclOperation.WRITE; pu

[jira] [Commented] (KAFKA-18422) add Kafka client upgrade path

2025-01-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914749#comment-17914749 ] David Jacot commented on KAFKA-18422: - Making an exception for this one makes sense.

[jira] [Updated] (KAFKA-18422) add Kafka client upgrade path

2025-01-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18422: Fix Version/s: 4.0.0 (was: 4.1.0) > add Kafka client upgrade path > ---

Re: [PR] KAFKA-18604; Update transaction coordinator [kafka]

2025-01-20 Thread via GitHub
dajac commented on code in PR #18636: URL: https://github.com/apache/kafka/pull/18636#discussion_r1922713369 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionCoordinatorRecordSerde.java: ## @@ -16,32 +16,29 @@ */ package org.apache.

[jira] [Comment Edited] (KAFKA-18487) Remove ReplicaManager#stopReplicas

2025-01-20 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914747#comment-17914747 ] Ismael Juma edited comment on KAFKA-18487 at 1/20/25 5:34 PM:

[jira] [Commented] (KAFKA-18487) Remove ReplicaManager#stopReplicas

2025-01-20 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914747#comment-17914747 ] Ismael Juma commented on KAFKA-18487: - Makes sense - I wasn't sure if this would lan

[jira] [Commented] (KAFKA-18487) Remove ReplicaManager#stopReplicas

2025-01-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914745#comment-17914745 ] David Jacot commented on KAFKA-18487: - Sorry, I meant that I cannot remove it withou

[jira] [Resolved] (KAFKA-18363) Clean up Server config documents which contained zookeeper

2025-01-20 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-18363. Resolution: Fixed > Clean up Server config documents which contained zookeeper >

Re: [PR] KAFKA-18363 Clean up Server config documents which contained zookeeper [kafka]

2025-01-20 Thread via GitHub
mimaison commented on PR #18346: URL: https://github.com/apache/kafka/pull/18346#issuecomment-2602957837 Applied to 4.0 too: https://github.com/apache/kafka/commit/9e80d7ed56439356d73846f479a91c7082e0b9c2 -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] KAFKA-18487; Remove ReplicaManager#stopReplicas [kafka]

2025-01-20 Thread via GitHub
dajac commented on code in PR #18647: URL: https://github.com/apache/kafka/pull/18647#discussion_r1922706139 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2146,101 +2144,6 @@ class ReplicaManagerTest { } } - @Test Review Comment: It is

Re: [PR] KAFKA-18487; Remove ReplicaManager#stopReplicas [kafka]

2025-01-20 Thread via GitHub
dajac commented on code in PR #18647: URL: https://github.com/apache/kafka/pull/18647#discussion_r1922706349 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2146,101 +2144,6 @@ class ReplicaManagerTest { } } - @Test - def testClearFetchPurga

[jira] [Created] (KAFKA-18606) Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest

2025-01-20 Thread Jira
黃竣陽 created KAFKA-18606: --- Summary: Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest Key: KAFKA-18606 URL: https://issues.apache.org/jira/browse/KAFKA-18606 Project: Kafka Issue Ty

Re: [PR] KAFKA-18487; Remove ReplicaManager#stopReplicas [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18647: URL: https://github.com/apache/kafka/pull/18647#discussion_r1922703177 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2146,101 +2144,6 @@ class ReplicaManagerTest { } } - @Test Review Comment: Since

[jira] [Commented] (KAFKA-18487) Remove ReplicaManager#stopReplicas

2025-01-20 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914743#comment-17914743 ] Ismael Juma commented on KAFKA-18487: - PR: https://github.com/apache/kafka/pull/1849

Re: [PR] KAFKA-18363 Clean up Server config documents which contained zookeeper [kafka]

2025-01-20 Thread via GitHub
mimaison merged PR #18346: URL: https://github.com/apache/kafka/pull/18346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-18487) Remove ReplicaManager#stopReplicas

2025-01-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914739#comment-17914739 ] David Jacot commented on KAFKA-18487: - [~ijuma] Did you mean StopReplicaRequest? Sto

[PR] KAFKA-18487; Remove ReplicaManager#stopReplicas [kafka]

2025-01-20 Thread via GitHub
dajac opened a new pull request, #18647: URL: https://github.com/apache/kafka/pull/18647 This patch removes `ReplicaManager#stopReplicas`. I have ensured that removed unit tests are covered by other existing tests or updated to use kraft. ### Committer Checklist (excluded from commit

[jira] [Comment Edited] (KAFKA-18422) add Kafka client upgrade path

2025-01-20 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914736#comment-17914736 ] Ismael Juma edited comment on KAFKA-18422 at 1/20/25 5:15 PM:

[jira] [Commented] (KAFKA-18422) add Kafka client upgrade path

2025-01-20 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914736#comment-17914736 ] Ismael Juma commented on KAFKA-18422: - To be clear, we cannot change the client upgr

Re: [PR] KAFKA-18023: Enforcing Explicit Naming for Kafka Streams Internal Topics [kafka]

2025-01-20 Thread via GitHub
lucasbru commented on code in PR #18233: URL: https://github.com/apache/kafka/pull/18233#discussion_r1922600453 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -592,6 +592,10 @@ public class StreamsConfig extends AbstractConfig { public static fi

[PR] MINOR: clean up zk comment [kafka]

2025-01-20 Thread via GitHub
m1a2st opened a new pull request, #18646: URL: https://github.com/apache/kafka/pull/18646 as title ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (includin

Re: [PR] MINOR: restore `testGetAllTopicMetadataShouldNotCreateTopicOrReturnUnknownTopicPartition` [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18633: URL: https://github.com/apache/kafka/pull/18633#discussion_r1922661143 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -3562,6 +3562,47 @@ class KafkaApisTest extends Logging { assertEquals(Set(0), response.brokers.a

[PR] MINOR: Update the Outdated method name [kafka]

2025-01-20 Thread via GitHub
m1a2st opened a new pull request, #18645: URL: https://github.com/apache/kafka/pull/18645 this method name is contained "UnlessZkMode", this is Outdated when we deprecate Zookeeper ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

Re: [PR] KAFKA-14552: Assume a baseline of 3.0 for server protocol versions [kafka]

2025-01-20 Thread via GitHub
ijuma commented on PR #18497: URL: https://github.com/apache/kafka/pull/18497#issuecomment-2602852971 @chia7712 Thanks for the review. Pushed a commit that addresses the comments. Also merged master to this branch for the flaky test fix. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-16495 Fix flaky TransactionsWithTieredStoreTest#testCommitTransactionTimeout [kafka]

2025-01-20 Thread via GitHub
m1a2st closed pull request #17254: KAFKA-16495 Fix flaky TransactionsWithTieredStoreTest#testCommitTransactionTimeout URL: https://github.com/apache/kafka/pull/17254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] KAFKA-18600 Cleanup NetworkClient zk related logging [kafka]

2025-01-20 Thread via GitHub
m1a2st opened a new pull request, #18644: URL: https://github.com/apache/kafka/pull/18644 Jira: Cleanup NetworkClient zk related logging ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status

Re: [PR] MINOR: Remove zk related statement from ControllerConfigruationValidator [kafka]

2025-01-20 Thread via GitHub
mimaison commented on PR #18637: URL: https://github.com/apache/kafka/pull/18637#issuecomment-2602807678 Applied to 4.0 too: https://github.com/apache/kafka/commit/5c5876808e9f94881eedc9f91669e498c036a1ed -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] MINOR: Remove zk related statement from ControllerConfigruationValidator [kafka]

2025-01-20 Thread via GitHub
mimaison merged PR #18637: URL: https://github.com/apache/kafka/pull/18637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] Revert "KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch (#17870" [kafka]

2025-01-20 Thread via GitHub
apoorvmittal10 opened a new pull request, #18643: URL: https://github.com/apache/kafka/pull/18643 This reverts commit b021b515952153a8876b48dda134ef3d81781c13. The commit was cherry-picked as it was easier to merge subsequent commits in 4.0: https://github.com/apache/kafka/pull/17870#

[jira] [Assigned] (KAFKA-18572) Update Kafka Streams metric documenation

2025-01-20 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ukpa Uchechi reassigned KAFKA-18572: Assignee: Ukpa Uchechi > Update Kafka Streams metric documenation > -

Re: [PR] KAFKA-14552: Assume a baseline of 3.0 for server protocol versions [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18497: URL: https://github.com/apache/kafka/pull/18497#discussion_r1922579707 ## generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java: ## @@ -355,28 +362,9 @@ private void generateHeaderVersion(String type) {

Re: [PR] KAFKA-18585 Fix fail test ValuesTest#shouldConvertDateValues [kafka]

2025-01-20 Thread via GitHub
m1a2st commented on PR #18611: URL: https://github.com/apache/kafka/pull/18611#issuecomment-2602726756 Hello @AndrewJSchofield, if you have free cycle, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-14552: Assume a baseline of 3.0 for server protocol versions [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18497: URL: https://github.com/apache/kafka/pull/18497#discussion_r1922576857 ## clients/src/main/resources/common/message/LeaderAndIsrRequest.json: ## @@ -16,84 +16,6 @@ { "apiKey": 4, "type": "request", - "listeners": ["zkBroker"], "na

Re: [PR] KAFKA-18595: Remove AuthorizerUtils#sessionToRequestContext [kafka]

2025-01-20 Thread via GitHub
clolov merged PR #18631: URL: https://github.com/apache/kafka/pull/18631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-14552: Assume a baseline of 3.0 for server protocol versions [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18497: URL: https://github.com/apache/kafka/pull/18497#discussion_r1921669453 ## clients/src/test/java/org/apache/kafka/common/protocol/ProtocolTest.java: ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] HOTFIX: ListShareGroupOffsetResult javadoc [kafka]

2025-01-20 Thread via GitHub
AndrewJSchofield merged PR #18642: URL: https://github.com/apache/kafka/pull/18642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18232: Add share group state topic prune metrics. [kafka]

2025-01-20 Thread via GitHub
AndrewJSchofield commented on code in PR #18174: URL: https://github.com/apache/kafka/pull/18174#discussion_r1922553367 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/metrics/ShareCoordinatorMetrics.java: ## @@ -153,4 +158,31 @@ public void record(String s

Re: [PR] KAFKA-18530 Rename ZooKeeperInternals [kafka]

2025-01-20 Thread via GitHub
m1a2st commented on code in PR #18641: URL: https://github.com/apache/kafka/pull/18641#discussion_r1922566817 ## server-common/src/main/java/org/apache/kafka/server/config/KraftInternals.java: ## @@ -16,12 +16,11 @@ */ package org.apache.kafka.server.config; -public class Z

Re: [PR] [KAFKA-18266]: Re-order validation for TimeIndex sanity check [kafka]

2025-01-20 Thread via GitHub
pramithas commented on code in PR #18482: URL: https://github.com/apache/kafka/pull/18482#discussion_r1922566089 ## storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java: ## @@ -76,16 +76,16 @@ public void sanityCheck() { TimestampOffset entry = la

Re: [PR] [KAFKA-18266]: Re-order validation for TimeIndex sanity check [kafka]

2025-01-20 Thread via GitHub
pramithas closed pull request #18482: [KAFKA-18266]: Re-order validation for TimeIndex sanity check URL: https://github.com/apache/kafka/pull/18482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-18311: Internal Topic Manager (5/5) [kafka]

2025-01-20 Thread via GitHub
lucasbru commented on code in PR #18442: URL: https://github.com/apache/kafka/pull/18442#discussion_r1922564511 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/InternalTopicManager.java: ## @@ -148,6 +148,19 @@ private static Map decideParti

Re: [PR] KAFKA-16368: Constraints update for segment.index.bytes [kafka]

2025-01-20 Thread via GitHub
divijvaidya commented on code in PR #18596: URL: https://github.com/apache/kafka/pull/18596#discussion_r1922561578 ## storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java: ## @@ -178,6 +178,8 @@ public static Map createTopicConfigForRemoteStor

Re: [PR] KAFKA-18232: Add share group state topic prune metrics. [kafka]

2025-01-20 Thread via GitHub
AndrewJSchofield merged PR #18174: URL: https://github.com/apache/kafka/pull/18174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-17968) Create VerifiableShareConsumer

2025-01-20 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-17968. -- Fix Version/s: 4.1.0 Resolution: Fixed > Create VerifiableShareConsumer > -

Re: [PR] KAFKA-18530 Rename ZooKeeperInternals [kafka]

2025-01-20 Thread via GitHub
ijuma commented on code in PR #18641: URL: https://github.com/apache/kafka/pull/18641#discussion_r1922560281 ## server-common/src/main/java/org/apache/kafka/server/config/KraftInternals.java: ## @@ -16,12 +16,11 @@ */ package org.apache.kafka.server.config; -public class Zo

[jira] [Resolved] (KAFKA-18568) Flaky test ClientIdQuotaTest

2025-01-20 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-18568. -- Resolution: Fixed > Flaky test ClientIdQuotaTest > > >

[jira] [Updated] (KAFKA-18568) Flaky test ClientIdQuotaTest

2025-01-20 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-18568: - Affects Version/s: 4.0.0 > Flaky test ClientIdQuotaTest > > >

Re: [PR] Infrastructure for system tests for the new share consumer client [kafka]

2025-01-20 Thread via GitHub
AndrewJSchofield commented on PR #18209: URL: https://github.com/apache/kafka/pull/18209#issuecomment-2602690747 This resolves KAFKA-17968. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Resolved] (KAFKA-18232) Prune share state topic metrics

2025-01-20 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-18232. -- Fix Version/s: 4.1.0 Resolution: Fixed > Prune share state topic metrics >

  1   2   3   >