divijvaidya commented on code in PR #18596:
URL: https://github.com/apache/kafka/pull/18596#discussion_r1922561578
##########
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##########
@@ -178,6 +178,8 @@ public static Map<String, String>
createTopicConfigForRemoteStorage(boolean enab
// a "small" number of records (i.e. such that the average record size
times the number of records is
// much less than the segment size), the number of records which hold
in a segment is the multiple of 12
// defined below.
+
+ // TODO: WIP - Need to consider options for dealing with this segment
roll approach not being valid for this PR.
topicProps.put(TopicConfig.SEGMENT_INDEX_BYTES_CONFIG,
String.valueOf(12 * maxRecordBatchPerSegment));
Review Comment:
The motivation of this code in this test infra is to rotate segments after a
fixed amount of data is written to it. An alternative way to do it is to call
UnifiedLog.roll(). We need to add utility method to do that in this test infra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
