chia7712 commented on code in PR #18641:
URL: https://github.com/apache/kafka/pull/18641#discussion_r1922770484
##########
server-common/src/main/java/org/apache/kafka/server/config/KraftInternals.java:
##########
@@ -16,12 +16,11 @@
*/
package org.apache.kafka.server.config;
-public class ZooKeeperInternals {
+public class KraftInternals {
Review Comment:
@m1a2st Could you please clean up the usage of
`ZooKeeperInternals.DEFAULT_STRING` first? We are currently using
`ZooKeeperInternals.DEFAULT_STRING` as a specific string for compatibility with
the zk handler (QuotaConfigHandler). Since #18617 will remove
`QuotaConfigHandler`, the kraft `ClientQuotaMetadataManager` no longer needs to
use `ZooKeeperInternals.DEFAULT_STRING`.
After addressing above comment, we can move `<default>` to be a internal
constant of `ClientQuotaManager` to ensure the compatibility of metrics
`kafka.server:type={Produce|Fetch},user=([-.\w]+),client-id=([-.\w]+)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
