m1a2st commented on code in PR #18641: URL: https://github.com/apache/kafka/pull/18641#discussion_r1922566817
########## server-common/src/main/java/org/apache/kafka/server/config/KraftInternals.java: ########## @@ -16,12 +16,11 @@ */ package org.apache.kafka.server.config; -public class ZooKeeperInternals { +public class KraftInternals { Review Comment: Removing this would affect the default username and default client-id. Since this is a breaking change, I suggest we maintain consistency by keeping these default values. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org