Re: [PR] KAFKA-18156: VerifiableConsumer should ignore "--session-timeout" when using CONSUMER protocol [kafka]

2024-12-06 Thread via GitHub
brandboat commented on code in PR #18036: URL: https://github.com/apache/kafka/pull/18036#discussion_r1874347462 ## tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java: ## @@ -664,7 +664,11 @@ public static VerifiableConsumer createFromArgs(ArgumentParser parser,

Re: [PR] KAFKA-18156: VerifiableConsumer should ignore "--session-timeout" when using CONSUMER protocol [kafka]

2024-12-06 Thread via GitHub
chia7712 commented on code in PR #18036: URL: https://github.com/apache/kafka/pull/18036#discussion_r1874339355 ## tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java: ## @@ -664,7 +664,11 @@ public static VerifiableConsumer createFromArgs(ArgumentParser parser,

Re: [PR] KAFKA-18156: VerifiableConsumer should ignore "--session-timeout" when using CONSUMER protocol [kafka]

2024-12-06 Thread via GitHub
brandboat commented on code in PR #18036: URL: https://github.com/apache/kafka/pull/18036#discussion_r1874335812 ## tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java: ## @@ -664,7 +664,11 @@ public static VerifiableConsumer createFromArgs(ArgumentParser parser,

[jira] [Commented] (KAFKA-18173) Remove duplicate assertFutureError

2024-12-06 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903793#comment-17903793 ] Peter Lee commented on KAFKA-18173: --- Hi [~chia7712], I was previously working on the r

Re: [PR] KAFKA-18156: VerifiableConsumer should ignore "--session-timeout" when using CONSUMER protocol [kafka]

2024-12-06 Thread via GitHub
chia7712 commented on code in PR #18036: URL: https://github.com/apache/kafka/pull/18036#discussion_r1874333999 ## tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java: ## @@ -664,7 +664,11 @@ public static VerifiableConsumer createFromArgs(ArgumentParser parser,

Re: [PR] KAFKA-17750: Extend kafka-consumer-groups command line tool to support new consumer group (part 2) [kafka]

2024-12-06 Thread via GitHub
FrankYang0529 commented on code in PR #18034: URL: https://github.com/apache/kafka/pull/18034#discussion_r1874333440 ## clients/src/test/java/org/apache/kafka/clients/admin/internals/DescribeConsumerGroupsHandlerTest.java: ## @@ -164,17 +165,21 @@ public void testSuccessfulHandl

[jira] [Commented] (KAFKA-18084) Null and leaked AcquisitionLockTimerTask causes hanging AcknowledgeRequest and corrupted state of batch

2024-12-06 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903792#comment-17903792 ] Abhinav Dixit commented on KAFKA-18084: --- [~chia7712] thanks for your guidance :).

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

2024-12-06 Thread via GitHub
mjsax commented on code in PR #17973: URL: https://github.com/apache/kafka/pull/17973#discussion_r1874247047 ## streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java: ## @@ -99,8 +99,8 @@ protected Consumed(final Consumed consumed) { public static Consumed w

[jira] [Updated] (KAFKA-18160) Interrupting or waking up onPartitionsAssigned in AsyncConsumer can cause the ConsumerRebalanceListenerCallbackCompletedEvent to be skipped

2024-12-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18160: --- Summary: Interrupting or waking up onPartitionsAssigned in AsyncConsumer can cause the Consu

[jira] [Updated] (KAFKA-18160) Interrupting or waking up onPartitionsAssigned in AsyncConsumer can cause the ConsumerRebalanceListenerCallbackCompletedEvent to be skipped, potentially leading to corru

2024-12-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18160: --- Description: I noticed this issue when testing KAFKA-17962. It includes two bugs listed bel

Re: [PR] KAFKA-18160: Interrupting or waking up onPartitionsAssigned in AsyncConsumer can cause the ConsumerRebalanceListenerCallbackCompletedEvent to be skipped, potentially leading to corrupted adde

2024-12-06 Thread via GitHub
chia7712 commented on PR #18089: URL: https://github.com/apache/kafka/pull/18089#issuecomment-2524852986 I discussed this with @brandboat offline. The second issue is expected behavior, as the classic consumer also passes empty partitions. Therefore, we should update the listener's document

Re: [PR] MINOR: Replace assertUnorderedListEquals by assertUnorderedRecordsEquals in group-coordinator module [kafka]

2024-12-06 Thread via GitHub
chia7712 merged PR #18076: URL: https://github.com/apache/kafka/pull/18076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] KAFKA-18160: Interrupting or waking up onPartitionsAssigned in AsyncConsumer can cause the ConsumerRebalanceListenerCallbackCompletedEvent to be skipped, potentially leading to corrupted added pa

2024-12-06 Thread via GitHub
brandboat opened a new pull request, #18089: URL: https://github.com/apache/kafka/pull/18089 related to https://issues.apache.org/jira/browse/KAFKA-18160 This pr fix two issues as described below: - ConsumerRebalanceListenerCallbackCompletedEvent is skipped `invokeRebalanceCa

[jira] [Commented] (KAFKA-17960) PlaintextAdminIntegrationTest.testConsumerGroups fails with CONSUMER group protocol

2024-12-06 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903789#comment-17903789 ] Kirk True commented on KAFKA-17960: --- It doesn't appear that KAFKA-18116 fixed this. I

[jira] [Commented] (KAFKA-18040) PlaintextProducerSendTest.testSendToPartitionWithFollowerShutdownShouldNotTimeout fails with CONSUMER group protocol

2024-12-06 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903787#comment-17903787 ] Kirk True commented on KAFKA-18040: --- In this test there are two brokers: a leader and

Re: [PR] KAFKA-14470: Move the storage exceptions out of the core module [kafka]

2024-12-06 Thread via GitHub
chia7712 commented on code in PR #18021: URL: https://github.com/apache/kafka/pull/18021#discussion_r1874220951 ## storage/src/main/java/org/apache/kafka/storage/internals/log/OffsetsOutOfOrderException.java: ## @@ -14,16 +14,14 @@ * See the License for the specific language g

[jira] [Resolved] (KAFKA-18162) Move LocalLogTest to storage module

2024-12-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18162. Fix Version/s: 4.0.0 Resolution: Fixed > Move LocalLogTest to storage module >

Re: [PR] KAFKA-18162: Move LocalLogTest to storage module [kafka]

2024-12-06 Thread via GitHub
chia7712 merged PR #18057: URL: https://github.com/apache/kafka/pull/18057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18156: VerifiableConsumer should ignore "--session-timeout" when using CONSUMER protocol [kafka]

2024-12-06 Thread via GitHub
brandboat commented on code in PR #18036: URL: https://github.com/apache/kafka/pull/18036#discussion_r1874217495 ## tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java: ## @@ -664,7 +664,11 @@ public static VerifiableConsumer createFromArgs(ArgumentParser parser,

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

2024-12-06 Thread via GitHub
KApolinario1120 commented on code in PR #17973: URL: https://github.com/apache/kafka/pull/17973#discussion_r1874205823 ## streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java: ## @@ -99,8 +99,8 @@ protected Consumed(final Consumed consumed) { public static

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

2024-12-06 Thread via GitHub
KApolinario1120 commented on code in PR #17973: URL: https://github.com/apache/kafka/pull/17973#discussion_r1874206457 ## streams/src/test/java/org/apache/kafka/streams/AutoOffsetResetTest.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

2024-12-06 Thread via GitHub
KApolinario1120 commented on code in PR #17973: URL: https://github.com/apache/kafka/pull/17973#discussion_r1874204920 ## streams/src/main/java/org/apache/kafka/streams/AutoOffsetReset.java: ## @@ -0,0 +1,76 @@ +package org.apache.kafka.streams; + +import java.time.Duration; +im

Re: [PR] KAFKA-17696 New consumer background operations unaware of metadata errors [kafka]

2024-12-06 Thread via GitHub
m1a2st commented on code in PR #17440: URL: https://github.com/apache/kafka/pull/17440#discussion_r1874197149 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -150,7 +155,11 @@ private void maybePropagateMetadataError() {

[jira] [Commented] (KAFKA-18177) generate better helper code to support changing keys in request/response schema

2024-12-06 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903783#comment-17903783 ] Jun Rao commented on KAFKA-18177: - [~frankvicky] : Thanks for helping out. Feel free to

[jira] [Assigned] (KAFKA-18177) generate better helper code to support changing keys in request/response schema

2024-12-06 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18177: --- Assignee: TengYao Chi > generate better helper code to support changing keys in request/res

Re: [PR] KAFKA-12829: Remove deprecated KStream.process() for old Processor API [kafka]

2024-12-06 Thread via GitHub
mjsax commented on code in PR #18088: URL: https://github.com/apache/kafka/pull/18088#discussion_r1874182211 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java: ## @@ -2233,72 +2228,6 @@ public Set> stores() { } } -@Test

[PR] KAFKA-12829: Remove deprecated KStream.process() for old Processor API [kafka]

2024-12-06 Thread via GitHub
mjsax opened a new pull request, #18088: URL: https://github.com/apache/kafka/pull/18088 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] KAFKA-12829: Remove deprecated Topology#addProcessor of old Processor API [kafka]

2024-12-06 Thread via GitHub
mjsax commented on PR #17190: URL: https://github.com/apache/kafka/pull/17190#issuecomment-2524671461 Your PR update does not seem to be right/complete? I am wondering if we have some communication gap and going somewhat in cycles? -- Would you mind if we close this PR and I work on a PR on

Re: [PR] KAFKA-18030 Remove old upgrade-system-tests modules [kafka]

2024-12-06 Thread via GitHub
mjsax commented on PR #17843: URL: https://github.com/apache/kafka/pull/17843#issuecomment-2524651601 I am personally ok to remove 0.10.0 and 0.10.1 -- both are _really_ old... We just had a similar discussion about this on https://github.com/apache/kafka/pull/18055 -- not sure if @ca

[jira] [Commented] (KAFKA-18177) generate better helper code to support changing keys in request/response schema

2024-12-06 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903777#comment-17903777 ] TengYao Chi commented on KAFKA-18177: - Hello [~junrao]  May I take over this issue

Re: [PR] MINOR: improve Kafka Streams config docs [kafka]

2024-12-06 Thread via GitHub
mjsax commented on code in PR #18087: URL: https://github.com/apache/kafka/pull/18087#discussion_r1874114332 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -974,28 +974,6 @@ public class StreamsConfig extends AbstractConfig { Def

Re: [PR] MINOR: improve Kafka Streams config docs [kafka]

2024-12-06 Thread via GitHub
mjsax commented on code in PR #18087: URL: https://github.com/apache/kafka/pull/18087#discussion_r1874113897 ## docs/streams/developer-guide/config-streams.html: ## @@ -416,68 +417,91 @@ num.standby.replicaspoll.ms Low The amount of time in milliseconds

Re: [PR] MINOR: improve Kafka Streams config docs [kafka]

2024-12-06 Thread via GitHub
mjsax commented on code in PR #18087: URL: https://github.com/apache/kafka/pull/18087#discussion_r1874113374 ## docs/streams/developer-guide/config-streams.html: ## @@ -403,10 +404,10 @@ num.standby.replicasprocessing.guarantee Medium -The processing mod

Re: [PR] MINOR: improve Kafka Streams config docs [kafka]

2024-12-06 Thread via GitHub
mjsax commented on code in PR #18087: URL: https://github.com/apache/kafka/pull/18087#discussion_r1874112266 ## docs/streams/developer-guide/config-streams.html: ## @@ -301,8 +301,9 @@ num.standby.replicasdefault.timestamp.extractor Medium -Timestamp ext

Re: [PR] MINOR: improve Kafka Streams config docs [kafka]

2024-12-06 Thread via GitHub
mjsax commented on code in PR #18087: URL: https://github.com/apache/kafka/pull/18087#discussion_r1874112001 ## docs/streams/developer-guide/config-streams.html: ## @@ -265,12 +265,12 @@ num.standby.replicasstatestore.cache.max.bytes Medium Maximum numb

Re: [PR] MINOR: improve Kafka Streams config docs [kafka]

2024-12-06 Thread via GitHub
mjsax commented on code in PR #18087: URL: https://github.com/apache/kafka/pull/18087#discussion_r1874111813 ## docs/streams/developer-guide/config-streams.html: ## @@ -265,12 +265,12 @@ num.standby.replicasstatestore.cache.max.bytes Medium Maximum numb

Re: [PR] MINOR: improve Kafka Streams config docs [kafka]

2024-12-06 Thread via GitHub
mjsax commented on code in PR #18087: URL: https://github.com/apache/kafka/pull/18087#discussion_r1874111595 ## docs/streams/developer-guide/config-streams.html: ## @@ -231,9 +231,9 @@ num.standby.replicasStreams javadocs, sorted by level of importance: -

Re: [PR] Kafka-16540 set up the min ISR configs if ELR is enabled. [kafka]

2024-12-06 Thread via GitHub
cmccabe commented on PR #17952: URL: https://github.com/apache/kafka/pull/17952#issuecomment-2524572811 Also, I think we should generate the configuration record for the cluster config as part of the activation event rather than right afterwards. That will ensure that it happens before anyt

Re: [PR] Kafka-16540 set up the min ISR configs if ELR is enabled. [kafka]

2024-12-06 Thread via GitHub
cmccabe commented on PR #17952: URL: https://github.com/apache/kafka/pull/17952#issuecomment-2524568957 Thanks for the PR. Thoughts: I think feature control should not have a reference to cluster control. in general many things reference feature control to know the MV and I don’t want

Re: [PR] KAFKA-18176: Fix verifiable consumer with unsupported protocol configs [kafka]

2024-12-06 Thread via GitHub
lianetm commented on PR #18085: URL: https://github.com/apache/kafka/pull/18085#issuecomment-2524550376 Perfect! no worries, I'll close this one then, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-18176: Fix verifiable consumer with unsupported protocol configs [kafka]

2024-12-06 Thread via GitHub
lianetm closed pull request #18085: KAFKA-18176: Fix verifiable consumer with unsupported protocol configs URL: https://github.com/apache/kafka/pull/18085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] KAFKA-18156: VerifiableConsumer should ignore "--session-timeout" when using CONSUMER protocol [kafka]

2024-12-06 Thread via GitHub
chia7712 commented on code in PR #18036: URL: https://github.com/apache/kafka/pull/18036#discussion_r1874096289 ## tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java: ## @@ -664,7 +664,11 @@ public static VerifiableConsumer createFromArgs(ArgumentParser parser,

Re: [PR] KAFKA-18030 Remove old upgrade-system-tests modules [kafka]

2024-12-06 Thread via GitHub
chia7712 commented on PR #17843: URL: https://github.com/apache/kafka/pull/17843#issuecomment-2524516632 I ran all Streams end-to-end tests with this PR, and `streams_eos_test.py` failed on both the trunk and this PR. @mjsax @ableegoldman any concerns about removing 0.10.x code? If not, I'd

Re: [PR] MINOR: improve Kafka Streams config docs [kafka]

2024-12-06 Thread via GitHub
mjsax commented on code in PR #18087: URL: https://github.com/apache/kafka/pull/18087#discussion_r1874091117 ## docs/streams/developer-guide/config-streams.html: ## @@ -432,7 +432,7 @@ num.standby.replicas-1 retry.backoff.ms -Medium +

[PR] MINOR: improve Kafka Streams config docs [kafka]

2024-12-06 Thread via GitHub
mjsax opened a new pull request, #18087: URL: https://github.com/apache/kafka/pull/18087 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Base PR with Plugin Loading Isolation Changes) [kafka]

2024-12-06 Thread via GitHub
gharris1727 commented on code in PR #16984: URL: https://github.com/apache/kafka/pull/16984#discussion_r1874058107 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java: ## @@ -168,11 +174,21 @@ protected static Class pluginClass(

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Base PR with Plugin Loading Isolation Changes) [kafka]

2024-12-06 Thread via GitHub
gharris1727 commented on code in PR #16984: URL: https://github.com/apache/kafka/pull/16984#discussion_r1874057246 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java: ## @@ -69,36 +75,117 @@ public DelegatingClassLoader() {

[jira] [Created] (KAFKA-18177) generate better helper code to support changing keys in request/response schema

2024-12-06 Thread Jun Rao (Jira)
Jun Rao created KAFKA-18177: --- Summary: generate better helper code to support changing keys in request/response schema Key: KAFKA-18177 URL: https://issues.apache.org/jira/browse/KAFKA-18177 Project: Kafka

[jira] [Commented] (KAFKA-18073) Data loss when Kafka Connect retriable exception raised

2024-12-06 Thread Tom Thornton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903763#comment-17903763 ] Tom Thornton commented on KAFKA-18073: -- The issue appears to be from errors.toleran

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Base PR with Plugin Loading Isolation Changes) [kafka]

2024-12-06 Thread via GitHub
snehashisp commented on PR #16984: URL: https://github.com/apache/kafka/pull/16984#issuecomment-2524226369 Thanks for the reviews on this PR @gharris1727. I think I have addressed most of the comments here and made the changes to the other PRs based on your suggestions. Please review the ot

Re: [PR] KAFKA-17796: Persist higher leaderEpoch in read state call. [kafka]

2024-12-06 Thread via GitHub
smjn commented on code in PR #17580: URL: https://github.com/apache/kafka/pull/17580#discussion_r1874004711 ## build.gradle: ## @@ -203,6 +203,11 @@ allprojects { options.links "https://docs.oracle.com/en/java/javase/${JavaVersion.current().majorVersion}/docs/api/" }

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Base PR with Plugin Loading Isolation Changes) [kafka]

2024-12-06 Thread via GitHub
snehashisp commented on code in PR #16984: URL: https://github.com/apache/kafka/pull/16984#discussion_r1873998808 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java: ## @@ -69,36 +75,117 @@ public DelegatingClassLoader() {

[jira] [Updated] (KAFKA-18156) VerifiableConsumer should ignore "--session-timeout" when using CONSUMER protocol

2024-12-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18156: --- Parent: KAFKA-18161 Issue Type: Sub-task (was: Bug) > VerifiableConsumer should ign

Re: [PR] KAFKA-18176: Fix verifiable consumer with unsupported protocol configs [kafka]

2024-12-06 Thread via GitHub
chia7712 commented on PR #18085: URL: https://github.com/apache/kafka/pull/18085#issuecomment-2524162850 @lianetm thanks for this patch, but it is duplicate to #18036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-17796: Persist higher leaderEpoch in read state call. [kafka]

2024-12-06 Thread via GitHub
AndrewJSchofield commented on code in PR #17580: URL: https://github.com/apache/kafka/pull/17580#discussion_r1873972293 ## build.gradle: ## @@ -203,6 +203,11 @@ allprojects { options.links "https://docs.oracle.com/en/java/javase/${JavaVersion.current().majorVersion}/docs/a

Re: [PR] [KAFKA-17030] Unattached voters will fetch from bootstrap voters [kafka]

2024-12-06 Thread via GitHub
jsancio commented on PR #17352: URL: https://github.com/apache/kafka/pull/17352#issuecomment-2524154304 > I just want to confirm we _do_ want Unattached nodes who have already voted to fetch from bootstrap voters? If so I will remove this comment It makes sense to me that replicas tha

[jira] [Updated] (KAFKA-17030) Voters should not assume that the leader will send them BeginQuorumEpoch requests

2024-12-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-17030: --- Fix Version/s: 3.9.1 > Voters should not assume that the leader will

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Base PR with Plugin Loading Isolation Changes) [kafka]

2024-12-06 Thread via GitHub
snehashisp commented on code in PR #16984: URL: https://github.com/apache/kafka/pull/16984#discussion_r1873971077 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/VersionedPluginLoadingException.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[jira] [Updated] (KAFKA-17030) Voters should not assume that the leader will send them BeginQuorumEpoch requests

2024-12-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-17030: --- Description: This issues depends on implementing https://issues.apa

Re: [PR] KAFKA-18176: Fix verifiable consumer with unsupported protocol configs [kafka]

2024-12-06 Thread via GitHub
lianetm commented on PR #18085: URL: https://github.com/apache/kafka/pull/18085#issuecomment-2524128539 Validated the fix with some specific tests. Before the PR: `OffsetValidationTest/test_consumer_failure/clean_shutdown=True.enable_autocommit=False.metadata_quorum=ISOLATED_KRAFT

[PR] KAFKA-18176: Fix verifiable consumer with unsupported protocol configs [kafka]

2024-12-06 Thread via GitHub
lianetm opened a new pull request, #18085: URL: https://github.com/apache/kafka/pull/18085 Ensure session timeout is only provided if the CLASSIC protocol is used, as it is not allowed under CONSUMER and makes the consumer creation fail. -- This is an automated message from the Apache

[jira] [Updated] (KAFKA-18176) Consumer system tests failure due to unsupported protocol configs

2024-12-06 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18176: -- Component/s: clients consumer > Consumer system tests failure due to unsupported prot

[jira] [Updated] (KAFKA-18150) Maybe downgrade the consumer group if a consumer member leaves the group though admin client

2024-12-06 Thread Dongnuo Lyu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongnuo Lyu updated KAFKA-18150: Component/s: group-coordinator > Maybe downgrade the consumer group if a consumer member leaves th

[jira] [Assigned] (KAFKA-18176) Consumer system tests failure due to unsupported protocol configs

2024-12-06 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans reassigned KAFKA-18176: -- Assignee: Lianet Magrans > Consumer system tests failure due to unsupported protocol

[jira] [Commented] (KAFKA-18173) Remove duplicate assertFutureError

2024-12-06 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903741#comment-17903741 ] Dmitry Werner commented on KAFKA-18173: --- [~chia7712] can I take this? > Remove du

Re: [PR] Trunk rebase 12 6 [kafka]

2024-12-06 Thread via GitHub
bbejeck closed pull request #18084: Trunk rebase 12 6 URL: https://github.com/apache/kafka/pull/18084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: ji

[PR] Trunk rebase 12 6 [kafka]

2024-12-06 Thread via GitHub
bbejeck opened a new pull request, #18084: URL: https://github.com/apache/kafka/pull/18084 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[jira] [Updated] (KAFKA-18176) Consumer system tests failure due to unsupported protocol configs

2024-12-06 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18176: --- Description: Consumer system tests are failing with the validation that Classic protocol co

[jira] [Assigned] (KAFKA-18147) kraft version of standalone KIP-853. controller should be 1 not 0

2024-12-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio reassigned KAFKA-18147: -- Assignee: José Armando García Sancio > kraft version of stand

Re: [PR] KAFKA-17338 ConsumerConfig should prevent using partition assignors with CONSUMER group protocol [kafka]

2024-12-06 Thread via GitHub
lianetm commented on PR #16899: URL: https://github.com/apache/kafka/pull/16899#issuecomment-2524076756 FYI @m1a2st / @chia7712 , found similar situation with consumer system tests that need to be updated, filed https://issues.apache.org/jira/browse/KAFKA-18176 -- This is an automated m

[jira] [Created] (KAFKA-18176) Consumer system tests failure due to unsupported protocol configs

2024-12-06 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-18176: -- Summary: Consumer system tests failure due to unsupported protocol configs Key: KAFKA-18176 URL: https://issues.apache.org/jira/browse/KAFKA-18176 Project: Kafka

[jira] [Updated] (KAFKA-18147) kraft version of standalone KIP-853. controller should be 1 not 0

2024-12-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18147: --- Component/s: kraft > kraft version of standalone KIP-853. controller

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Base PR with Plugin Loading Isolation Changes) [kafka]

2024-12-06 Thread via GitHub
snehashisp commented on code in PR #16984: URL: https://github.com/apache/kafka/pull/16984#discussion_r1873908658 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/PluginVersionUtils.java: ## @@ -0,0 +1,30 @@ +package org.apache.kafka.connect.util; + +import org.apa

[PR] KAFKA-18174: Subsequent write event completions should be a noop [kafka]

2024-12-06 Thread via GitHub
jeffkbkim opened a new pull request, #18083: URL: https://github.com/apache/kafka/pull/18083 In CoordinatorWriteEvent/CoordinatorCompleteTransactionEvent#complete, we record the event purgatory time. This can throw an exception if a value that is greater than 1 minute is recorded. Handle th

[jira] [Commented] (KAFKA-10043) Some parameters will be overwritten which was configured in consumer.config where running "ConsumerPerformance.scala"

2024-12-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903736#comment-17903736 ] Chia-Ping Tsai commented on KAFKA-10043: [~yung] Thank you for sharing. It would

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2024-12-06 Thread via GitHub
junrao commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1873883681 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java: ## @@ -172,6 +186,387 @@ private PollResult pollInternal(FetchRequestPrepa

Re: [PR] KAFKA-14619: KRaft validate snapshot id are at batch boundries [kafka]

2024-12-06 Thread via GitHub
jsancio commented on code in PR #17500: URL: https://github.com/apache/kafka/pull/17500#discussion_r1873873925 ## core/src/test/scala/kafka/raft/KafkaMetadataLogTest.scala: ## @@ -206,7 +217,7 @@ final class KafkaMetadataLogTest { val snapshotId = new OffsetAndEpoch(numberO

[jira] [Commented] (KAFKA-18175) Breaking change for SystemTime usages

2024-12-06 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903730#comment-17903730 ] Mickael Maison commented on KAFKA-18175: I'm not going to comment on the reasons

Re: [PR] KAFKA-18162: Move LocalLogTest to storage module [kafka]

2024-12-06 Thread via GitHub
mimaison commented on code in PR #18057: URL: https://github.com/apache/kafka/pull/18057#discussion_r1873837889 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LocalLogTest.java: ## @@ -0,0 +1,785 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-06 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1873751724 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: Hi @cadonn

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-06 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1873751724 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: @cadonna T

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-06 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1873751724 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: That is st

Re: [PR] KAFKA-18162: Move LocalLogTest to storage module [kafka]

2024-12-06 Thread via GitHub
mimaison commented on code in PR #18057: URL: https://github.com/apache/kafka/pull/18057#discussion_r1873833465 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LocalLogTest.java: ## @@ -0,0 +1,785 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Resolved] (KAFKA-18163) Move VerificationGuardTest to storage module

2024-12-06 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-18163. Resolution: Fixed > Move VerificationGuardTest to storage module > ---

Re: [PR] Add PR triage workflow [kafka]

2024-12-06 Thread via GitHub
mumrah commented on PR #17881: URL: https://github.com/apache/kafka/pull/17881#issuecomment-2523909958 @chia7712 or @mimaison any feedback on this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (KAFKA-18175) Breaking change for SystemTime usages

2024-12-06 Thread Calvin MongoDB (Jira)
Calvin MongoDB created KAFKA-18175: -- Summary: Breaking change for SystemTime usages Key: KAFKA-18175 URL: https://issues.apache.org/jira/browse/KAFKA-18175 Project: Kafka Issue Type: Bug

Re: [PR] Testing checkstyle OOM [kafka]

2024-12-06 Thread via GitHub
mumrah closed pull request #18078: Testing checkstyle OOM URL: https://github.com/apache/kafka/pull/18078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] KAFKA-18163: Move VerificationGuardTest to storage module [kafka]

2024-12-06 Thread via GitHub
jolshan merged PR #18058: URL: https://github.com/apache/kafka/pull/18058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18162: Move LocalLogTest to storage module [kafka]

2024-12-06 Thread via GitHub
chia7712 commented on code in PR #18057: URL: https://github.com/apache/kafka/pull/18057#discussion_r1873793851 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LocalLogTest.java: ## @@ -0,0 +1,785 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Base PR with Plugin Loading Isolation Changes) [kafka]

2024-12-06 Thread via GitHub
gharris1727 commented on code in PR #16984: URL: https://github.com/apache/kafka/pull/16984#discussion_r1873720403 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java: ## @@ -112,21 +199,70 @@ public void installDiscoveredPlugin

[jira] [Created] (KAFKA-18174) Handle hdr histogram exceptions gracefully

2024-12-06 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-18174: Summary: Handle hdr histogram exceptions gracefully Key: KAFKA-18174 URL: https://issues.apache.org/jira/browse/KAFKA-18174 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-18101: Merge duplicate assertFutureThrows and assertFutureExceptionTypeEquals [kafka]

2024-12-06 Thread via GitHub
chia7712 commented on code in PR #17991: URL: https://github.com/apache/kafka/pull/17991#discussion_r1873787650 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -563,7 +563,7 @@ public static void assertFutureThrows( String expectedMessage ) {

[jira] [Updated] (KAFKA-17548) Improve admin client integration tests

2024-12-06 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-17548: - Summary: Improve admin client integration tests (was: Create admin client integration t

[PR] KAFKA-17548: Improve group listing integration test [kafka]

2024-12-06 Thread via GitHub
AndrewJSchofield opened a new pull request, #18081: URL: https://github.com/apache/kafka/pull/18081 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[PR] test deadlockDection [kafka]

2024-12-06 Thread via GitHub
TaiJuWu opened a new pull request, #18082: URL: https://github.com/apache/kafka/pull/18082 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[jira] [Created] (KAFKA-18173) Remove duplicate assertFutureError

2024-12-06 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18173: -- Summary: Remove duplicate assertFutureError Key: KAFKA-18173 URL: https://issues.apache.org/jira/browse/KAFKA-18173 Project: Kafka Issue Type: Improvemen

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

2024-12-06 Thread via GitHub
swikarpat commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1873751724 ## README.md: ## @@ -1,5 +1,14 @@ -Apache Kafka -= +# Apache Kafka + +https://kafka.apache.org/";> + + + + + + + Review Comment: That is st

[jira] [Resolved] (KAFKA-18084) Null and leaked AcquisitionLockTimerTask causes hanging AcknowledgeRequest and corrupted state of batch

2024-12-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18084. Fix Version/s: 4.0.0 Resolution: Fixed [~adixitconfluent] thanks for all your contr

Re: [PR] MINOR: Fix broken javadoc in NetworkClientTest [kafka]

2024-12-06 Thread via GitHub
chia7712 merged PR #18075: URL: https://github.com/apache/kafka/pull/18075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18084: Added usage for rollback state while SharePartition acquires records [kafka]

2024-12-06 Thread via GitHub
chia7712 merged PR #17965: URL: https://github.com/apache/kafka/pull/17965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

  1   2   >