KApolinario1120 commented on code in PR #17973:
URL: https://github.com/apache/kafka/pull/17973#discussion_r1874205823


##########
streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java:
##########
@@ -99,8 +99,8 @@ protected Consumed(final Consumed<K, V> consumed) {
     public static <K, V> Consumed<K, V> with(final Serde<K> keySerde,
                                              final Serde<V> valueSerde,
                                              final TimestampExtractor 
timestampExtractor,
-                                             final Topology.AutoOffsetReset 
resetPolicy) {

Review Comment:
   Okay - this makes good sense to me. How/when does the old deprecated version 
get removed in this case then? Is there a point where a deprecated change gets 
cleaned out? 
   
   I am working now to fix - redacting the change I made and refactoring to two 
'versions', as you pointed out was correct. Thank you for helping me understand



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to