brandboat commented on code in PR #18036:
URL: https://github.com/apache/kafka/pull/18036#discussion_r1874347462
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java:
##########
@@ -664,7 +664,11 @@ public static VerifiableConsumer
createFromArgs(ArgumentParser parser, String[]
consumerProps.put(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG,
useAutoCommit);
consumerProps.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG,
res.getString("resetPolicy"));
- consumerProps.put(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG,
Integer.toString(res.getInt("sessionTimeout")));
+
+ // session.timeout.ms cannot be set when group.protocol=CONSUMER
+ if (!groupProtocol.equalsIgnoreCase(GroupProtocol.CONSUMER.name)) {
Review Comment:
Thanks, I already addressed the comment in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
