mjsax commented on code in PR #17973:
URL: https://github.com/apache/kafka/pull/17973#discussion_r1874247047


##########
streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java:
##########
@@ -99,8 +99,8 @@ protected Consumed(final Consumed<K, V> consumed) {
     public static <K, V> Consumed<K, V> with(final Serde<K> keySerde,
                                              final Serde<V> valueSerde,
                                              final TimestampExtractor 
timestampExtractor,
-                                             final Topology.AutoOffsetReset 
resetPolicy) {

Review Comment:
   In general (ie, for most software project), deprecated APIs are only removed 
in major releases, so for this case, maybe in Apache Kafka 5.0.0. (We are 
currently removing a lot of previously deprecated APIs for the upcoming 4.0.0 
release.)
   
   For Kafka, we also keep deprecated APIs for at least 3 minor release, ie, if 
something is deprecated in Kafka 3.7/3.8/3.9, we cannot remove it in 4.0.0 
release but keep it as well. This is a Kafka specific approach, and different 
projects do this differently.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to