Re: [PR] KAFKA-4915: do not use word "error" while logging with non-error level [kafka]

2024-10-14 Thread via GitHub
dernasherbrezon commented on PR #3751: URL: https://github.com/apache/kafka/pull/3751#issuecomment-2413040089 Can someone review please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] KAFKA-16564: Apply `Xlint` to java code in core module [kafka]

2024-10-14 Thread via GitHub
chia7712 commented on PR #16965: URL: https://github.com/apache/kafka/pull/16965#issuecomment-2413036726 @m1a2st could you please rebase code and fix conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-17741: Cleanup code base for JDK 11 [kafka]

2024-10-14 Thread via GitHub
chia7712 commented on code in PR #17441: URL: https://github.com/apache/kafka/pull/17441#discussion_r1800552621 ## clients/src/main/java/org/apache/kafka/common/utils/Java.java: ## @@ -22,8 +22,6 @@ public final class Java { private Java() { } -private static final

Re: [PR] KAFKA-17766: Fixing deadlock in TopicBasedRemoteLogMetadataManager [kafka]

2024-10-14 Thread via GitHub
kamalcph commented on code in PR #17492: URL: https://github.com/apache/kafka/pull/17492#discussion_r1800542225 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -391,6 +391,8 @@ private void initializeRes

Re: [PR] KAFKA-17766: Fixing deadlock in TopicBasedRemoteLogMetadataManager [kafka]

2024-10-14 Thread via GitHub
kamalcph commented on code in PR #17492: URL: https://github.com/apache/kafka/pull/17492#discussion_r1800548833 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -449,14 +450,13 @@ private void initializeR

Re: [PR] KAFKA-17766: Fixing deadlock in TopicBasedRemoteLogMetadataManager [kafka]

2024-10-14 Thread via GitHub
kamalcph commented on code in PR #17492: URL: https://github.com/apache/kafka/pull/17492#discussion_r1800542225 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -391,6 +391,8 @@ private void initializeRes

[jira] [Updated] (KAFKA-17783) Remove sharePartition from SharePartitionManager if the partition is deleted or becomes a follower

2024-10-14 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit updated KAFKA-17783: -- Summary: Remove sharePartition from SharePartitionManager if the partition is deleted or becom

Re: [PR] KAFKA-17633: Add share group record formatter and parser. [kafka]

2024-10-14 Thread via GitHub
omkreddy merged PR #17467: URL: https://github.com/apache/kafka/pull/17467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: remove unused method in IntegrationTestUtils [kafka]

2024-10-14 Thread via GitHub
chia7712 merged PR #17469: URL: https://github.com/apache/kafka/pull/17469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17742: Move DelayedShareFetchPurgatory declaration to ReplicaManager [kafka]

2024-10-14 Thread via GitHub
adixitconfluent commented on code in PR #17437: URL: https://github.com/apache/kafka/pull/17437#discussion_r1800505275 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1425,7 +1428,8 @@ class ReplicaManager(val config: KafkaConfig,

Re: [PR] KAFKA-17773: Upgrade spotbug to work under java 23 [kafka]

2024-10-14 Thread via GitHub
chia7712 commented on code in PR #17483: URL: https://github.com/apache/kafka/pull/17483#discussion_r1800487655 ## build.gradle: ## @@ -39,10 +39,7 @@ plugins { id 'org.nosphere.apache.rat' version "0.8.1" id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVer

Re: [PR] KAFKA-17781 add `psutil` to e2e dockerfile and upgrade ducktape version [kafka]

2024-10-14 Thread via GitHub
chia7712 commented on code in PR #17480: URL: https://github.com/apache/kafka/pull/17480#discussion_r1800485519 ## tests/docker/Dockerfile: ## @@ -62,8 +62,8 @@ LABEL ducker.creator=$ducker_creator # Update Linux and install necessary utilities. RUN apt update && apt install -

[jira] [Resolved] (KAFKA-17748) Remove scala-java8-compat

2024-10-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17748. Resolution: Fixed > Remove scala-java8-compat > -- > >

Re: [PR] KAFKA-17748: Remove scala-java8-compat [kafka]

2024-10-14 Thread via GitHub
chia7712 merged PR #17497: URL: https://github.com/apache/kafka/pull/17497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17776: Capability for connection disconnect listeners in socket server [kafka]

2024-10-14 Thread via GitHub
chia7712 commented on code in PR #17473: URL: https://github.com/apache/kafka/pull/17473#discussion_r1800477268 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -1248,6 +1257,8 @@ private[kafka] class Processor( if (address != null) connectionQuotas

[jira] [Resolved] (KAFKA-17693) Remove testCheckEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion

2024-10-14 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17693. Fix Version/s: 4.0.0 Resolution: Fixed > Remove testCheckEarliestLocalTimestampVers

Re: [PR] KAFKA-17693: Remove testEarliestLocalTimestampVersion and testCheckLatestTieredTimestampVersion [kafka]

2024-10-14 Thread via GitHub
chia7712 merged PR #17456: URL: https://github.com/apache/kafka/pull/17456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16985: Ensure consumer sends leave request on close even if interrupted [kafka]

2024-10-14 Thread via GitHub
chia7712 commented on PR #16686: URL: https://github.com/apache/kafka/pull/16686#issuecomment-2412844022 > I am pretty sure we never had logic to do even a best-effort LeaveGroup after an interrupt, so all of the trickery in this patch to try and handle interrupts makes me suspicious.

Re: [PR] KAFKA-5802 : ScramServerCallbackHandler#handle should check username not being null before calling credentialCache.get() [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3946: URL: https://github.com/apache/kafka/pull/3946#issuecomment-2412828616 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] MINOR: Move ChannelState.exception() to its own class [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3945: URL: https://github.com/apache/kafka/pull/3945#issuecomment-2412828591 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-3999: Record raw size of fetch responses as part of consumer metrics (KIP-264) [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3941: URL: https://github.com/apache/kafka/pull/3941#issuecomment-2412828569 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] MINOR: fix the information states in the log [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3933: URL: https://github.com/apache/kafka/pull/3933#issuecomment-2412828555 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-5911 Avoid creation of extra Map for futures in KafkaAdminClient [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3925: URL: https://github.com/apache/kafka/pull/3925#issuecomment-2412828539 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-5933: Move timeout and validate_only protocol fields into CommonFields class [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3908: URL: https://github.com/apache/kafka/pull/3908#issuecomment-2412828520 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-4320: Clarify the log compaction config property per-topic and per-broker [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3900: URL: https://github.com/apache/kafka/pull/3900#issuecomment-2412828505 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-5914: add message format version and message max bytes to metadata response [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3896: URL: https://github.com/apache/kafka/pull/3896#issuecomment-2412828494 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-5716: Recent polled offsets may not be written/flushed at SourceTask.commit [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3872: URL: https://github.com/apache/kafka/pull/3872#issuecomment-2412828476 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-4915: do not use word "error" while logging with non-error level [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3751: URL: https://github.com/apache/kafka/pull/3751#issuecomment-2412828406 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-5874: TopicCommand should check at least one parameter is given... [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3866: URL: https://github.com/apache/kafka/pull/3866#issuecomment-2412828458 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] MINOR: Logging changes [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3855: URL: https://github.com/apache/kafka/pull/3855#issuecomment-2412828440 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] MINOR: Capitalise topicPurgatory name [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3853: URL: https://github.com/apache/kafka/pull/3853#issuecomment-2412828418 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] Add group-id to the metrics tags [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3744: URL: https://github.com/apache/kafka/pull/3744#issuecomment-2412828396 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] Fixed file URI path to log4j in bin/windows batch files [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3270: URL: https://github.com/apache/kafka/pull/3270#issuecomment-2412828308 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] Fixed file URI path to log4j in bin/windows batch files [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] closed pull request #3270: Fixed file URI path to log4j in bin/windows batch files URL: https://github.com/apache/kafka/pull/3270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Fixed path to log4j config file [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] closed pull request #3260: Fixed path to log4j config file URL: https://github.com/apache/kafka/pull/3260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fixed path to log4j config file [kafka]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #3260: URL: https://github.com/apache/kafka/pull/3260#issuecomment-2412828283 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-16143: New JMX metrics for AsyncKafkaConsumer [kafka]

2024-10-14 Thread via GitHub
kirktrue commented on code in PR #17199: URL: https://github.com/apache/kafka/pull/17199#discussion_r1800283720 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1740,14 +1742,19 @@ private void subscribeInternal(Collection top

Re: [PR] KAKFA-17173: move quota config params from KafkaConfig to QuotaConfig [kafka]

2024-10-14 Thread via GitHub
unknowntpo commented on PR #17505: URL: https://github.com/apache/kafka/pull/17505#issuecomment-2412606542 @chia7712 Would you like to review this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Updated] (KAFKA-17456) Make sure FindCoordinatorResponse get created before consumer

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17456: -- Labels: flaky-test kip-848-client-support (was: kip-848-client-support) > Make sure FindCoordinatorRe

Re: [PR] KAFKA-17536: Ensure clear error message when new consumer used with incompatible cluster [kafka]

2024-10-14 Thread via GitHub
kirktrue commented on code in PR #17411: URL: https://github.com/apache/kafka/pull/17411#discussion_r1800275825 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java: ## @@ -378,11 +378,17 @@ private void onErrorResponse(final

Re: [PR] KAFKA-17536: Ensure clear error message when new consumer used with incompatible cluster [kafka]

2024-10-14 Thread via GitHub
kirktrue commented on code in PR #17411: URL: https://github.com/apache/kafka/pull/17411#discussion_r1800266192 ## checkstyle/import-control-core.xml: ## @@ -142,4 +142,8 @@ + + + + Review Comment: Is this necessary? We have other, existing integratio

Re: [PR] KAFKA-17778: Add listener to remove client instances on connection disconnect [kafka]

2024-10-14 Thread via GitHub
junrao commented on code in PR #17474: URL: https://github.com/apache/kafka/pull/17474#discussion_r1800244484 ## server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java: ## @@ -114,13 +117,15 @@ public ClientMetricsManager(ClientMetricsReceiverPlugin receiverPlug

[jira] [Updated] (KAFKA-17788) During ZK migration, always include control.plane.listener.name in advertisedBrokerListeners

2024-10-14 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-17788: - Summary: During ZK migration, always include control.plane.listener.name in advertisedBrokerList

Re: [PR] KAFKA-17794: kafka-storage format must require KIP-853 flags unless controller.quorum.voters is set [kafka]

2024-10-14 Thread via GitHub
cmccabe commented on PR #17504: URL: https://github.com/apache/kafka/pull/17504#issuecomment-2412527849 I added a test. Thanks, @jsancio . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Reopened] (KAFKA-17788) Migration fails in Kafka 3.9.0-RC2 when control plane listener is used

2024-10-14 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reopened KAFKA-17788: -- Assignee: Colin McCabe > Migration fails in Kafka 3.9.0-RC2 when control plane listener is u

[jira] [Comment Edited] (KAFKA-17788) Migration fails in Kafka 3.9.0-RC2 when control plane listener is used

2024-10-14 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889367#comment-17889367 ] Colin McCabe edited comment on KAFKA-17788 at 10/14/24 11:35 PM: -

[jira] [Commented] (KAFKA-17788) Migration fails in Kafka 3.9.0-RC2 when control plane listener is used

2024-10-14 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889367#comment-17889367 ] Colin McCabe commented on KAFKA-17788: -- Kafka wants to divide up all listeners into

[jira] [Commented] (KAFKA-16143) New JMX metrics for AsyncKafkaConsumer

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889365#comment-17889365 ] Kirk True commented on KAFKA-16143: --- [~yangpoan]—would you kindly update the status on

[jira] [Updated] (KAFKA-17456) Make sure FindCoordinatorResponse get created before consumer

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17456: -- Labels: kip-848-client-support (was: ) > Make sure FindCoordinatorResponse get created before consume

[jira] [Comment Edited] (KAFKA-17627) ConfigProvider TTLs do not restart Tasks

2024-10-14 Thread Spacrocket (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889356#comment-17889356 ] Spacrocket edited comment on KAFKA-17627 at 10/14/24 10:58 PM: ---

Re: [PR] KAFKA-14619: KRaft validate snapshot id are at batch boundries [kafka]

2024-10-14 Thread via GitHub
kevin-wu24 commented on code in PR #17500: URL: https://github.com/apache/kafka/pull/17500#discussion_r1800207969 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -258,7 +260,8 @@ public KafkaRaftClient( localSupportedKRaftVersion,

[PR] KAKFA-17173: move quota config params from KafkaConfig to QuotaConfig [kafka]

2024-10-14 Thread via GitHub
unknowntpo opened a new pull request, #17505: URL: https://github.com/apache/kafka/pull/17505 This PR rename `QuotaConfigs` to `QuotaConfig`, and move quota config related val from `KafkaConfig` to `QuotaConfig`. ### Committer Checklist (excluded from commit message) - [ ] Verify

[jira] [Commented] (KAFKA-17724) Clients - resolve race condition for SubscriptionState in share group consumer

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889363#comment-17889363 ] Kirk True commented on KAFKA-17724: --- [~schofielaj]—would you kindly update the status

[jira] [Updated] (KAFKA-17724) Clients - resolve race condition for SubscriptionState in share group consumer

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17724: -- Component/s: consumer > Clients - resolve race condition for SubscriptionState in share group consumer

[jira] [Updated] (KAFKA-17724) Clients - resolve race condition for SubscriptionState in share group consumer

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17724: -- Labels: kip-848-client-support (was: ) > Clients - resolve race condition for SubscriptionState in sh

[jira] [Updated] (KAFKA-17363) Flaky test: kafka.api.PlaintextConsumerCommitTest.testAutoCommitOnRebalance(String, String).quorum=kraft+kip848.groupProtocol=consumer

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17363: -- Labels: flaky-test integration-tests kip-848-client-support (was: integration-tests kip-848-client-su

[jira] [Updated] (KAFKA-17769) Fix flaky PlaintextConsumerSubscriptionTest.testSubscribeInvalidTopicCanUnsubscribe

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17769: -- Labels: flaky-test integration-test kip-848-client-support (was: integration-test kip-848-client-supp

[jira] [Updated] (KAFKA-17681) Fix unstable consumer_test.py#test_fencing_static_consumer

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17681: -- Labels: flaky-test kip-848-client-support (was: kip-848-client-support) > Fix unstable consumer_test.

[jira] [Updated] (KAFKA-17623) Flaky testSeekPositionAndPauseNewlyAssignedPartitionOnPartitionsAssignedCallback

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17623: -- Labels: consumer-threading-refactor flaky-test (was: consumer-threading-refactor) > Flaky > testSee

Re: [PR] KAFKA-14619: KRaft validate snapshot id are at batch boundries [kafka]

2024-10-14 Thread via GitHub
kevin-wu24 commented on code in PR #17500: URL: https://github.com/apache/kafka/pull/17500#discussion_r1800207969 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -258,7 +260,8 @@ public KafkaRaftClient( localSupportedKRaftVersion,

[jira] [Updated] (KAFKA-17769) Fix flaky PlaintextConsumerSubscriptionTest.testSubscribeInvalidTopicCanUnsubscribe

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17769: -- Fix Version/s: 4.0.0 > Fix flaky > PlaintextConsumerSubscriptionTest.testSubscribeInvalidTopicCanUnsu

[jira] [Updated] (KAFKA-17777) Flaky KafkaConsumerTest testReturnRecordsDuringRebalance

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-1: -- Fix Version/s: 4.0.0 > Flaky KafkaConsumerTest testReturnRecordsDuringRebalance >

[jira] [Updated] (KAFKA-17732) System test coverage for new consumer positions not getting behind committed offsets

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17732: -- Fix Version/s: 4.0.0 > System test coverage for new consumer positions not getting behind committed >

Re: [PR] KAFKA-17248: Override admin client to push metrics true, test for case where streams metrics [4/N] [kafka]

2024-10-14 Thread via GitHub
bbejeck commented on PR #17422: URL: https://github.com/apache/kafka/pull/17422#issuecomment-2412465864 @mjsax updated for comments - there's a known checkstyle issue that I'll address, but the core logic from this update won't change (will be refactored to reduce cyclomatic complexity) -

[jira] [Updated] (KAFKA-17769) Fix flaky PlaintextConsumerSubscriptionTest.testSubscribeInvalidTopicCanUnsubscribe

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17769: -- Labels: integration-test (was: ) > Fix flaky > PlaintextConsumerSubscriptionTest.testSubscribeInvali

[jira] [Updated] (KAFKA-17769) Fix flaky PlaintextConsumerSubscriptionTest.testSubscribeInvalidTopicCanUnsubscribe

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17769: -- Labels: integration-test kip-848-client-support (was: integration-test) > Fix flaky > PlaintextConsu

[jira] [Updated] (KAFKA-17777) Flaky KafkaConsumerTest testReturnRecordsDuringRebalance

2024-10-14 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-1: -- Labels: flaky-test kip-848-client-support (was: flaky-test) > Flaky KafkaConsumerTest testReturnRecor

[jira] [Comment Edited] (KAFKA-17627) ConfigProvider TTLs do not restart Tasks

2024-10-14 Thread Spacrocket (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889356#comment-17889356 ] Spacrocket edited comment on KAFKA-17627 at 10/14/24 10:17 PM: ---

[jira] [Comment Edited] (KAFKA-17627) ConfigProvider TTLs do not restart Tasks

2024-10-14 Thread Spacrocket (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889356#comment-17889356 ] Spacrocket edited comment on KAFKA-17627 at 10/14/24 10:17 PM: ---

[jira] [Commented] (KAFKA-17627) ConfigProvider TTLs do not restart Tasks

2024-10-14 Thread Spacrocket (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889356#comment-17889356 ] Spacrocket commented on KAFKA-17627: Thanks Greg for the advice, it's very useful. I

Re: [PR] KAFKA-17742: Move DelayedShareFetchPurgatory declaration to ReplicaManager [kafka]

2024-10-14 Thread via GitHub
junrao commented on code in PR #17437: URL: https://github.com/apache/kafka/pull/17437#discussion_r1800168918 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1425,7 +1428,8 @@ class ReplicaManager(val config: KafkaConfig, entriesP

[PR] KAFKA-17794: kafka-storage format must require KIP-853 flags unless controller.quorum.voters is set [kafka]

2024-10-14 Thread via GitHub
cmccabe opened a new pull request, #17504: URL: https://github.com/apache/kafka/pull/17504 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[jira] [Updated] (KAFKA-17794) kafka-storage format must require KIP-853 flags unless controller.quorum.voters is set

2024-10-14 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-17794: - Priority: Blocker (was: Major) > kafka-storage format must require KIP-853 flags unless > cont

[jira] [Created] (KAFKA-17794) kafka-storage format must require KIP-853 flags unless controller.quorum.voters is set

2024-10-14 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-17794: Summary: kafka-storage format must require KIP-853 flags unless controller.quorum.voters is set Key: KAFKA-17794 URL: https://issues.apache.org/jira/browse/KAFKA-17794

Re: [PR] KAFKA-15859: Complete delayed RemoteListOffsets requests when replica moves away from broker [kafka]

2024-10-14 Thread via GitHub
junrao commented on code in PR #17487: URL: https://github.com/apache/kafka/pull/17487#discussion_r1800153408 ## core/src/main/scala/kafka/server/DelayedRemoteListOffsets.scala: ## @@ -31,7 +31,7 @@ import java.util.concurrent.TimeUnit import scala.collection.{Map, mutable} im

Re: [PR] KAFKA-15859: Make RemoteListOffsets call an async operation [kafka]

2024-10-14 Thread via GitHub
junrao commented on code in PR #16602: URL: https://github.com/apache/kafka/pull/16602#discussion_r1800151731 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1447,11 +1466,123 @@ class ReplicaManager(val config: KafkaConfig, } } + def fetchOffset(topi

[jira] [Updated] (KAFKA-17789) State updater stuck when starting with empty state folder

2024-10-14 Thread Antoine Michaud (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antoine Michaud updated KAFKA-17789: Description: In an application with multiple clients, each having multiple threads, when t

Re: [PR] KAFKA-16339: [1/4 KStream#transform] Remove Deprecated "transformer" methods and classes [kafka]

2024-10-14 Thread via GitHub
fonsdant commented on PR #17198: URL: https://github.com/apache/kafka/pull/17198#issuecomment-2412355052 I have rebased my branch on trunk and this caused GitHub to close the PR. I am implementing the last review points again. -- This is an automated message from the Apache Git Service.

[PR] KAFKA-16339: [1/4 KStream#transform] Remove Deprecated "transformer" methods and classes [kafka]

2024-10-14 Thread via GitHub
fonsdant opened a new pull request, #17198: URL: https://github.com/apache/kafka/pull/17198 Hi, @mjsax! I have removed the `transform` methods from the main and test classes. However, I have asked myself whether the approach I have used for `StandbyTaskEOSIntegrationTest` and `StreamThreadT

Re: [PR] KAFKA-15859: Make RemoteListOffsets call an async operation [kafka]

2024-10-14 Thread via GitHub
junrao commented on code in PR #16602: URL: https://github.com/apache/kafka/pull/16602#discussion_r1800123024 ## core/src/main/scala/kafka/server/DelayedRemoteListOffsets.scala: ## @@ -0,0 +1,174 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-17272 [2/2]: System tests for protocol migration [kafka]

2024-10-14 Thread via GitHub
dongnuo123 commented on code in PR #17503: URL: https://github.com/apache/kafka/pull/17503#discussion_r1800120007 ## tests/kafkatest/tests/client/consumer_protocol_migration_test.py: ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# co

Re: [PR] KAFKA-16339: [1/4 KStream#transform] Remove Deprecated "transformer" methods and classes [kafka]

2024-10-14 Thread via GitHub
fonsdant closed pull request #17198: KAFKA-16339: [1/4 KStream#transform] Remove Deprecated "transformer" methods and classes URL: https://github.com/apache/kafka/pull/17198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-15859: Make RemoteListOffsets call an async operation [kafka]

2024-10-14 Thread via GitHub
junrao commented on code in PR #16602: URL: https://github.com/apache/kafka/pull/16602#discussion_r1800109844 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -263,6 +270,10 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig, ); } +

[jira] [Assigned] (KAFKA-17576) Fix all references to kraft/server.properties to use reconfig-server.properties

2024-10-14 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu reassigned KAFKA-17576: Assignee: Kevin Wu > Fix all references to kraft/server.properties to use > reconfig-server.prop

[jira] [Assigned] (KAFKA-16964) Integration tests for adding and removing voters

2024-10-14 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu reassigned KAFKA-16964: Assignee: Kevin Wu > Integration tests for adding and removing voters > -

Re: [PR] KAFKA-17272 [2/2]: System tests for protocol migration [kafka]

2024-10-14 Thread via GitHub
dongnuo123 commented on code in PR #17503: URL: https://github.com/apache/kafka/pull/17503#discussion_r178701 ## tests/kafkatest/tests/kafka_test.py: ## @@ -28,18 +28,20 @@ class KafkaTest(Test): setUp. The Zookeeper and Kafka services are available as the fields K

[PR] [KAFKA-17272](https://issues.apache.org/jira/browse/KAFKA-17272) [2/2]: System tests for protocol migration [kafka]

2024-10-14 Thread via GitHub
dongnuo123 opened a new pull request, #17503: URL: https://github.com/apache/kafka/pull/17503 This patch adds `consumer_protocol_migration_test.py` that tests the upgrade/downgrade paths between the old and new group protocol in KIP-848. ### Committer Checklist (excluded from commit m

Re: [PR] KAFKA-17600: Add nextOffsets to the ConsumerRecords [kafka]

2024-10-14 Thread via GitHub
aliehsaeedii commented on PR #17414: URL: https://github.com/apache/kafka/pull/17414#issuecomment-2412042780 @lucasbru I think the PR is ready for the last round of review. Thanks in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] KAFKA-17600: Add nextOffsets to the ConsumerRecords [kafka]

2024-10-14 Thread via GitHub
aliehsaeedii commented on code in PR #17414: URL: https://github.com/apache/kafka/pull/17414#discussion_r1799936825 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetch.java: ## @@ -95,6 +102,13 @@ public int numRecords() { return numRecords;

Re: [PR] KAFKA-14619: KRaft validate snapshot id are at batch boundries [kafka]

2024-10-14 Thread via GitHub
jsancio commented on code in PR #17500: URL: https://github.com/apache/kafka/pull/17500#discussion_r1799965560 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -258,7 +260,8 @@ public KafkaRaftClient( localSupportedKRaftVersion, l

Re: [PR] KAFKA-17742: Move DelayedShareFetchPurgatory declaration to ReplicaManager [kafka]

2024-10-14 Thread via GitHub
junrao commented on code in PR #17437: URL: https://github.com/apache/kafka/pull/17437#discussion_r1799892871 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -950,6 +983,7 @@ class ReplicaManager(val config: KafkaConfig, delayedProducePurgatory.check

Re: [PR] KAFKA-17600: Add nextOffsets to the ConsumerRecords [kafka]

2024-10-14 Thread via GitHub
aliehsaeedii commented on code in PR #17414: URL: https://github.com/apache/kafka/pull/17414#discussion_r1799936825 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetch.java: ## @@ -95,6 +102,13 @@ public int numRecords() { return numRecords;

[PR] KAFKA-17793: Improve kcontroller robustness against long delays [kafka]

2024-10-14 Thread via GitHub
cmccabe opened a new pull request, #17502: URL: https://github.com/apache/kafka/pull/17502 As described in KIP-500, the Kafka controller monitors the liveness of each broker in the cluster. It gathers this information from heartbeats sent from the brokers themselves. In some rare cas

[jira] [Created] (KAFKA-17793) Improve kcontroller robustness against long delays

2024-10-14 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-17793: Summary: Improve kcontroller robustness against long delays Key: KAFKA-17793 URL: https://issues.apache.org/jira/browse/KAFKA-17793 Project: Kafka Issue Type

[jira] [Commented] (KAFKA-17766) TopicBasedRemoteLogMetadataManager stuck in close

2024-10-14 Thread Anshul Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889298#comment-17889298 ] Anshul Goyal commented on KAFKA-17766: -- [~satish.duggana]  [~ckamal] Could you have

[PR] KAFKA-17790: Document that control.plane.listener should be removed before ZK migration is finished [kafka]

2024-10-14 Thread via GitHub
cmccabe opened a new pull request, #17501: URL: https://github.com/apache/kafka/pull/17501 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[jira] [Updated] (KAFKA-17790) Document that control.plane.listener should be removed before ZK migration is finished

2024-10-14 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-17790: - Summary: Document that control.plane.listener should be removed before ZK migration is finished

[jira] [Resolved] (KAFKA-17788) Migration fails in Kafka 3.9.0-RC2 when control plane listener is used

2024-10-14 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-17788. -- Resolution: Invalid > Migration fails in Kafka 3.9.0-RC2 when control plane listener is used >

[jira] [Commented] (KAFKA-17788) Migration fails in Kafka 3.9.0-RC2 when control plane listener is used

2024-10-14 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889291#comment-17889291 ] Colin McCabe commented on KAFKA-17788: -- After looking through the attached file, I

Re: [PR] KAFKA-17031: Make RLM thread pool configurations public [kafka]

2024-10-14 Thread via GitHub
gaurav-narula commented on code in PR #17499: URL: https://github.com/apache/kafka/pull/17499#discussion_r1799875723 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -257,13 +257,13 @@ public static ConfigDef configDef() {

  1   2   3   >