adixitconfluent commented on code in PR #17437:
URL: https://github.com/apache/kafka/pull/17437#discussion_r1800505275
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1425,7 +1428,8 @@ class ReplicaManager(val config: KafkaConfig,
entriesPerPartition: Map[TopicPartition,
MemoryRecords],
requiredAcks: Short,
requestLocal: RequestLocal,
- verificationGuards: Map[TopicPartition,
VerificationGuard]): Map[TopicPartition, LogAppendResult] = {
+ verificationGuards: Map[TopicPartition,
VerificationGuard]):
+ Map[TopicPartition, (LogAppendResult, Option[Uuid])] = {
Review Comment:
Hi @junrao, for a `TopicIdPartition`, topicId parameter in constructor([code
reference](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/TopicIdPartition.java#L37))
has to be not null, which can happen in our case here. Hence, opted for
`Map[TopicPartition, (LogAppendResult, Option[Uuid])]`. I was thinking of
`Uuid.ZERO_UUID` for the null cases, but I was not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
