kamalcph commented on code in PR #17492:
URL: https://github.com/apache/kafka/pull/17492#discussion_r1800548833


##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java:
##########
@@ -449,14 +450,13 @@ private void initializeResources() {
                 } catch (Exception e) {
                     log.error("Encountered error while initializing 
producer/consumer", e);

Review Comment:
   Should we mark the initialization as failed when we fail to initialize the 
producer/consumer? Otherwise, the metadata events won't be propagated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to