[ https://issues.apache.org/jira/browse/KAFKA-17627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889356#comment-17889356 ]
Spacrocket edited comment on KAFKA-17627 at 10/14/24 10:58 PM: --------------------------------------------------------------- Thanks Greg for the advice, it's very useful. I missed some parts of how configuration is provided into the class. I should do another commit this week. After all, I just need to determine when WCT is transforming a Task config which should probably be determined by connectorName == null and schedule restart for it based on supplied TTL. Do you know what Test files should I see to check how TTLs for Tasks are currently processed? Herder*Test and WorkerConfigTransformerTest don't seem to be helpful. was (Author: JIRAUSER289157): Thanks Greg for the advice, it's very useful. I missed some parts of how configuration is provided into the class. I should do another commit this week. After all, I just need to determine when WCT is transforming a Task config which should probably be determined by connectorName == null and schedule restart for it based on supplied TTL. > ConfigProvider TTLs do not restart Tasks > ---------------------------------------- > > Key: KAFKA-17627 > URL: https://issues.apache.org/jira/browse/KAFKA-17627 > Project: Kafka > Issue Type: Bug > Components: connect > Affects Versions: 2.0.0 > Reporter: Greg Harris > Assignee: Spacrocket > Priority: Major > Labels: newbie > > The ConfigProvider interface allows for implementations to provide > configurations with an accompanying Time To Live, a lifetime that the > returned value is valid for. Callers which receive a TTL should periodically > call the ConfigProvider to refresh and receive any updated value. > The WorkerConfigTransformer is responsible for accepting TTLs from > ConfigProviders, and scheduling restarts for connectors to force them to > refresh their externalized configurations. > Since the introduction of the ConfigProvider interface in 2.0.0, when the > WorkerConfigTransformer processes task configurations, it schedules a restart > of the connector, which may or may not be present on the running machine. > Instead, when secrets for a task include a TTL, the task should be restarted > directly. -- This message was sent by Atlassian Jira (v8.20.10#820010)