philipnee commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1378452443
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -154,6 +158,8 @@ public class PrototypeAsyncConsumer implement
[
https://issues.apache.org/jira/browse/KAFKA-15753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781619#comment-17781619
]
Zihao Lin commented on KAFKA-15753:
---
Hi [~sameert]
I wonder we begin to fix these is
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378449294
##
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java:
##
@@ -346,6 +346,23 @@ public static Function
getDeserializeValue(final S
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378449410
##
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java:
##
@@ -346,6 +346,23 @@ public static Function
getDeserializeValue(final S
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378448335
##
streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueToTimestampedKeyValueByteStoreAdapter.java:
##
@@ -126,15 +128,22 @@ public QueryResult q
kamalcph commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378448023
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -379,6 +379,8 @@ public void stopPartitions(Set
stopPartitions,
LOGGER.in
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378447978
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +140,230 @@ static class RawAndDeserializedValu
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378447310
##
streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueToTimestampedKeyValueByteStoreAdapter.java:
##
@@ -126,15 +128,22 @@ public QueryResult q
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378446901
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +140,230 @@ static class RawAndDeserializedValu
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378445910
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -47,7 +59,26 @@ public class MeteredTimestampedKeyValu
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781616#comment-17781616
]
Arpit Goyal edited comment on KAFKA-15388 at 11/1/23 6:43 AM:
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378445789
##
streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueToTimestampedKeyValueByteStoreAdapter.java:
##
@@ -126,15 +128,22 @@ public QueryResult q
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781616#comment-17781616
]
Arpit Goyal commented on KAFKA-15388:
-
[~divijvaidya] [~satish.duggana] Correct me
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378442918
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3126,8 +3127,11 @@ class ReplicaManagerTest {
propsModifier.apply(props)
val config =
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378442872
##
streams/src/main/java/org/apache/kafka/streams/query/TimestampedRangeQuery.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1378442252
##
streams/src/main/java/org/apache/kafka/streams/query/TimestampedKeyQuery.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/KAFKA-15768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hanyu Zheng reassigned KAFKA-15768:
---
Assignee: Hanyu Zheng
> StateQueryResult#getOnlyPartitionResult should not throw for Failed
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378438720
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3117,7 +3117,8 @@ class ReplicaManagerTest {
isShuttingDown: AtomicBoolean = new AtomicBoo
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378429312
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -379,6 +379,8 @@ public void stopPartitions(Set
stopPartitions,
LOGGER.info
alok123t commented on PR #14607:
URL: https://github.com/apache/kafka/pull/14607#issuecomment-1788463950
@ijuma @junrao
the latest build succeeds for JDK 8/Scala 2.12. The previous failures should
be unrelated to this PR
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2
alok123t commented on PR #14607:
URL: https://github.com/apache/kafka/pull/14607#issuecomment-1788460578
@junrao created following JIRA
https://issues.apache.org/jira/browse/KAFKA-15770
For rest of the failed tests, JIRA already exists
--
This is an automated message from the Apache
Alok Thatikunta created KAFKA-15770:
---
Summary:
org.apache.kafka.streams.integration.ConsistencyVectorIntegrationTest.shouldHaveSamePositionBoundActiveAndStandBy
is flaky
Key: KAFKA-15770
URL: https://issues.ap
[
https://issues.apache.org/jira/browse/KAFKA-15020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781599#comment-17781599
]
Alok Thatikunta commented on KAFKA-15020:
-
Another instance here
[https://ci-bu
[
https://issues.apache.org/jira/browse/KAFKA-15700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alok Thatikunta updated KAFKA-15700:
Attachment: (was: testRackAwareRangeAssignor(String).quorum=zk –
integration.kafka.se
[
https://issues.apache.org/jira/browse/KAFKA-15700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alok Thatikunta updated KAFKA-15700:
Attachment: testRackAwareRangeAssignor(String).quorum=zk –
integration.kafka.server.Fetch
GOODBOY008 commented on PR #14683:
URL: https://github.com/apache/kafka/pull/14683#issuecomment-1788440311
@dengziming PTAL , Thank you~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
kamalcph commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378393848
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3117,7 +3117,8 @@ class ReplicaManagerTest {
isShuttingDown: AtomicBoolean = new AtomicB
GOODBOY008 opened a new pull request, #14683:
URL: https://github.com/apache/kafka/pull/14683
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of test
Zhongqiang Gong created KAFKA-15769:
---
Summary: Fix wrong log with exception
Key: KAFKA-15769
URL: https://issues.apache.org/jira/browse/KAFKA-15769
Project: Kafka
Issue Type: Improvement
kamalcph commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378390961
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -379,6 +379,8 @@ public void stopPartitions(Set
stopPartitions,
LOGGER.in
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378380054
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -378,6 +378,8 @@ public void stopPartitions(Set
stopPartitions,
if (stopPartiti
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378379272
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -5667,6 +5671,47 @@ class ReplicaManagerTest {
verify(spyRm).checkpointHighWatermarks()
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378378073
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -3126,8 +3127,11 @@ class ReplicaManagerTest {
propsModifier.apply(props)
val config =
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378377914
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -630,13 +630,15 @@ class ReplicaManager(val config: KafkaConfig,
// Third delete the logs and chec
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378377473
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -378,6 +378,8 @@ public void stopPartitions(Set
stopPartitions,
if (stopPartiti
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378377473
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -378,6 +378,8 @@ public void stopPartitions(Set
stopPartitions,
if (stopPartiti
github-actions[bot] commented on PR #13310:
URL: https://github.com/apache/kafka/pull/13310#issuecomment-1788353993
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
lzyLuke opened a new pull request, #14682:
URL: https://github.com/apache/kafka/pull/14682
Pick up works left from https://github.com/apache/kafka/pull/14160/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
[
https://issues.apache.org/jira/browse/KAFKA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cameron updated KAFKA-15766:
Description:
Hello,
This is my first dive into the Kafka source code, so I may be mis-interpreting
some
dengziming merged PR #14660:
URL: https://github.com/apache/kafka/pull/14660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apac
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1378285408
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -108,13 +105,13 @@
import static org.apache.kafka.common.utils.Uti
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1378285238
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/LegacyKafkaConsumer.java:
##
@@ -0,0 +1,2616 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-15661:
--
Assignee: Crispin Bernier
> KIP-951: Server side and protocol changes
> -
jolshan merged PR #13247:
URL: https://github.com/apache/kafka/pull/13247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1378277149
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -670,168 +582,11 @@ public KafkaConsumer(Properties properties,
public KafkaC
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1378276620
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -108,13 +105,13 @@
import static org.apache.kafka.common.utils.Uti
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1378276022
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerUtils.java:
##
@@ -211,4 +226,17 @@ else if (t instanceof KafkaException)
thr
jolshan merged PR #14627:
URL: https://github.com/apache/kafka/pull/14627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1378275567
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerDelegateCreator.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundat
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1378275212
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerDelegateCreator.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundat
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1378274154
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerDelegateCreator.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundat
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1378272592
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +781,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This me
junrao commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378220184
##
core/src/main/scala/kafka/server/ConfigHelper.scala:
##
@@ -129,6 +130,25 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
[
https://issues.apache.org/jira/browse/KAFKA-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781556#comment-17781556
]
Kirk True commented on KAFKA-15679:
---
[~pnee] can you mark this as in progress/in revie
[
https://issues.apache.org/jira/browse/KAFKA-15679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15679:
-
Assignee: Philip Nee
> Client support for new consumer configs
> --
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1378267516
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +781,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This me
apoorvmittal10 commented on PR #14618:
URL: https://github.com/apache/kafka/pull/14618#issuecomment-1788182563
> jar -tf kafka-clients-3.7.0-SNAPSHOT.jar | grep -v
org/apache/kafka/shaded/ > jar_tf_output
I have updated the build file and below are the results; tldr there is no
chan
[
https://issues.apache.org/jira/browse/KAFKA-15768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15768:
Description:
Calling `StateQueryResult#getOnlyPartitionResult` crashes with an incorrect
Matthias J. Sax created KAFKA-15768:
---
Summary: StateQueryResult#getOnlyPartitionResult should not throw
for FailedQueryResult
Key: KAFKA-15768
URL: https://issues.apache.org/jira/browse/KAFKA-15768
CalvinConfluent commented on code in PR #14612:
URL: https://github.com/apache/kafka/pull/14612#discussion_r1378225326
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -116,6 +117,7 @@ class KafkaApis(val requestChannel: RequestChannel,
val requestHelper = new Reque
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1378225151
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -50,28 +50,36 @@ object KafkaRequestHandler {
}
/**
- * Wrap callback to schedule it on a
hachikuji commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1378179666
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -50,28 +50,36 @@ object KafkaRequestHandler {
}
/**
- * Wrap callback to schedule it on
ableegoldman opened a new pull request, #14681:
URL: https://github.com/apache/kafka/pull/14681
In applications that construct the various client configs multiple times,
the config logging can be pretty extreme, so it's nice to be able to disable
this for subsequent config objects that are
[
https://issues.apache.org/jira/browse/KAFKA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cameron updated KAFKA-15766:
Description:
Hello,
This is my first dive into the Kafka source code, so I may be mis-interpreting
some
xvrl commented on PR #14618:
URL: https://github.com/apache/kafka/pull/14618#issuecomment-1788079703
> @xvrl Please find the details below, AK `trunk` branch build vs `changes`
in PR. Do you think we should relocate `*.proto` files too, didn't do that as I
felt moving classes should be suff
[
https://issues.apache.org/jira/browse/KAFKA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cameron updated KAFKA-15766:
Description:
Hello,
This is my first dive into the Kafka source code, so I may be mis-interpreting
some
agavra commented on code in PR #14659:
URL: https://github.com/apache/kafka/pull/14659#discussion_r1378192463
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreBuilderWrapper.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (
agavra commented on code in PR #14659:
URL: https://github.com/apache/kafka/pull/14659#discussion_r1378192463
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreBuilderWrapper.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1378192398
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/SubscribedTopicMetadata.java:
##
@@ -68,12 +68,12 @@ public int numPartitions(Uuid topi
agavra commented on code in PR #14659:
URL: https://github.com/apache/kafka/pull/14659#discussion_r1378189923
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreBuilderWrapper.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (
agavra commented on code in PR #14659:
URL: https://github.com/apache/kafka/pull/14659#discussion_r1378189275
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -611,33 +545,38 @@ public final void addProcessor(final
Strin
mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1378185193
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -281,45 +274,38 @@ public void testDestroyConnector() t
agavra commented on code in PR #14659:
URL: https://github.com/apache/kafka/pull/14659#discussion_r1378185082
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreBuilderWrapper.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (
agavra commented on code in PR #14659:
URL: https://github.com/apache/kafka/pull/14659#discussion_r1378184855
##
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##
@@ -520,7 +521,7 @@ public synchronized GlobalKTable
globalTable(final String topic,
*/
wcarlson5 commented on code in PR #14564:
URL: https://github.com/apache/kafka/pull/14564#discussion_r1378153127
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -350,6 +353,91 @@ public synchronized void update(int requestVersion,
MetadataResponse respons
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1378164028
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apa
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1378163455
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apa
rreddy-22 commented on code in PR #14416:
URL: https://github.com/apache/kafka/pull/14416#discussion_r1378163030
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,419 @@
+/*
+ * Licensed to the Ap
dajac commented on PR #14670:
URL: https://github.com/apache/kafka/pull/14670#issuecomment-1788029739
@kirktrue Noted. I will be away tomorrow but I can’t take a look at it when
I come back if nobody gets to it first.
--
This is an automated message from the Apache Git Service.
To respond
dajac commented on PR #14680:
URL: https://github.com/apache/kafka/pull/14680#issuecomment-1788027763
Does commitSync have the same issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
dajac commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1378159050
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -154,6 +158,8 @@ public class PrototypeAsyncConsumer implements
C
wcarlson5 merged PR #14619:
URL: https://github.com/apache/kafka/pull/14619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
wcarlson5 commented on PR #14619:
URL: https://github.com/apache/kafka/pull/14619#issuecomment-1787988965
The tests failing are not related to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jolshan commented on code in PR #14671:
URL: https://github.com/apache/kafka/pull/14671#discussion_r1378127829
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -16,10 +16,6 @@
*/
package org.apache.kafka.common;
-import java.util.Collections;
-
[
https://issues.apache.org/jira/browse/KAFKA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cameron updated KAFKA-15766:
Description:
Hello,
This is my first dive into the Kafka source code, so I may be mis-interpreting
some
C0urante commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-1787948593
@gharris1727 similar to https://github.com/apache/kafka/pull/14304 -
apologies for the delay, I've addressed all outstanding concerns, ready for
another round when you have time 👍
--
cmccabe commented on PR #14628:
URL: https://github.com/apache/kafka/pull/14628#issuecomment-1787946848
This was getting too big, so I split off a part 1 here :
https://github.com/apache/kafka/pull/14678/files
--
This is an automated message from the Apache Git Service.
To respond to the
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1378105490
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -380,6 +387,110 @@ protected Map
validateSourceConnectorConfig(SourceConn
Kirk True created KAFKA-15767:
-
Summary: Redesign TransactionManager to avoid use of ThreadLocal
Key: KAFKA-15767
URL: https://issues.apache.org/jira/browse/KAFKA-15767
Project: Kafka
Issue Type:
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1378078025
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -380,6 +387,110 @@ protected Map
validateSourceConnectorConfig(SourceConn
philipnee commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1378079473
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -384,12 +384,10 @@ public void commitAsync(Map offsets, Offset
[
https://issues.apache.org/jira/browse/KAFKA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cameron updated KAFKA-15766:
Description:
Hello,
This is my first dive into the Kafka source code, so I may be mis-interpreting
some
kirktrue commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1378071781
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -384,12 +384,10 @@ public void commitAsync(Map offsets, OffsetC
[
https://issues.apache.org/jira/browse/KAFKA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cameron updated KAFKA-15766:
Description:
Hello,
This is my first dive into the Kafka source code, so I may be mis-interpreting
some
[
https://issues.apache.org/jira/browse/KAFKA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cameron updated KAFKA-15766:
Description:
Hello,
This is my first dive into the Kafka source code, so I may be mis-interpreting
some
[
https://issues.apache.org/jira/browse/KAFKA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cameron updated KAFKA-15766:
Description:
Hello,
This is my first dive into the Kafka source code, so I may be mis-interpreting
some
[
https://issues.apache.org/jira/browse/KAFKA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cameron updated KAFKA-15766:
Description:
Hello,
This is my first dive into the Kafka source code, so I may be mis-interpreting
some
mjsax commented on PR #14677:
URL: https://github.com/apache/kafka/pull/14677#issuecomment-1787845179
Can we just do this? Seems we need to wait for 4.0 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cameron updated KAFKA-15766:
Description:
Hello,
This is my first dive into the Kafka source code, so I may be mis-interpreting
some
[
https://issues.apache.org/jira/browse/KAFKA-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cameron updated KAFKA-15766:
Description:
Hello,
This is my first dive into the Kafka source code, so I may be mis-interpreting
some
1 - 100 of 216 matches
Mail list logo
