hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378377473
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -378,6 +378,8 @@ public void stopPartitions(Set<StopPartition>
stopPartitions,
if (stopPartition.deleteRemoteLog()) {
LOGGER.info("Deleting the remote log segments task for
partition: {}", tpId);
deleteRemoteLogPartition(tpId);
+ } else {
Review Comment:
updated, thanks
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -630,13 +630,15 @@ class ReplicaManager(val config: KafkaConfig,
// Third delete the logs and checkpoint.
val errorMap = new mutable.HashMap[TopicPartition, Throwable]()
+ // `tieredEnabledPartitions` has excluded internal topics because the
logic of `unifiedLog.remoteLogEnabled()`
+ val tieredEnabledPartitions = partitionsToStop.filter(sp =>
logManager.getLog(sp.topicPartition).exists(unifiedLog =>
unifiedLog.remoteLogEnabled()))
Review Comment:
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
