xvrl commented on PR #14618: URL: https://github.com/apache/kafka/pull/14618#issuecomment-1788079703
> @xvrl Please find the details below, AK `trunk` branch build vs `changes` in PR. Do you think we should relocate `*.proto` files too, didn't do that as I felt moving classes should be sufficient? I think we should minimize the differences. Unless the protos are actually necessary at runtime, I think we should omit them to avoid polluting the jar with unnecessary resources. > git diff 3.7.0-SNAPSHOT-trunk/kafka-clients-3.7.0-SNAPSHOT.pom 3.7.0-SNAPSHOT-changes/kafka-clients-3.7.0-SNAPSHOT.pom It looks like we are adding opentelemetry-proto as a runtime dependency, that doesn't look right. Since the proto dependencies are already included in the jar and relocated, the resulting pom should be identical. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
