hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1378438720
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -3117,7 +3117,8 @@ class ReplicaManagerTest {
isShuttingDown: AtomicBoolean = new AtomicBoolean(false),
enableRemoteStorage: Boolean = false,
shouldMockLog: Boolean = false,
- remoteLogManager: Option[RemoteLogManager] = None
+ remoteLogManager: Option[RemoteLogManager] = None,
+ defaultTopicRemoteLogStorageEnable: Boolean = true
Review Comment:
Default set true is to preserve the same behaviour on other tests. For
example, for test
`testStopReplicaWithDeletePartitionAndExistingPartitionAndEqualLeaderEpoch`,
when `enableRemoteStorage` is set true, it will verify
`verify(mockRemoteLogManager).stopPartitions(ArgumentMatchers.eq(Collections.singleton(stopPartition)),
any())`, if `defaultTopicRemoteLogStorageEnable ` set false, in this pr
change, the topic will be filtered out and test failed in the unit test, which
is same as other unit tests. @kamalcph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
