hiteshk25 commented on code in PR #1293:
URL: https://github.com/apache/solr/pull/1293#discussion_r1083142545
##
solr/core/src/test/org/apache/solr/cloud/api/collections/SimpleCollectionCreateDeleteTest.java:
##
@@ -104,6 +109,29 @@ public void testCreateAndDeleteThenCreateAgain
epugh commented on PR #1295:
URL: https://github.com/apache/solr/pull/1295#issuecomment-1399254159
@janhoy we proobably should up our Javascript game, and do it in conjunction
with a lint checker to ensure if we migrate to new ways, we don't slip back...
I've used `jshint` on Quepid and i
epugh merged PR #1283:
URL: https://github.com/apache/solr/pull/1283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on code in PR #1304:
URL: https://github.com/apache/solr/pull/1304#discussion_r1083292547
##
solr/webapp/web/js/angular/controllers/analysis.js:
##
@@ -137,16 +168,24 @@ solrAdminApp.controller('AnalysisController',
}
if (fieldOrType == "field
epugh commented on code in PR #1304:
URL: https://github.com/apache/solr/pull/1304#discussion_r1083292726
##
solr/webapp/web/js/angular/controllers/analysis.js:
##
@@ -21,33 +21,64 @@ solrAdminApp.controller('AnalysisController',
$scope.refresh = function() {
L
epugh commented on code in PR #1304:
URL: https://github.com/apache/solr/pull/1304#discussion_r1083292803
##
solr/webapp/web/js/angular/controllers/analysis.js:
##
@@ -21,33 +21,64 @@ solrAdminApp.controller('AnalysisController',
$scope.refresh = function() {
L
epugh commented on code in PR #1304:
URL: https://github.com/apache/solr/pull/1304#discussion_r1083293157
##
solr/webapp/web/js/angular/controllers/analysis.js:
##
@@ -21,33 +21,64 @@ solrAdminApp.controller('AnalysisController',
$scope.refresh = function() {
L
epugh commented on code in PR #1304:
URL: https://github.com/apache/solr/pull/1304#discussion_r1083293202
##
solr/webapp/web/js/angular/controllers/analysis.js:
##
@@ -21,33 +21,64 @@ solrAdminApp.controller('AnalysisController',
$scope.refresh = function() {
L
stillalex commented on code in PR #1304:
URL: https://github.com/apache/solr/pull/1304#discussion_r1083315721
##
solr/webapp/web/js/angular/controllers/analysis.js:
##
@@ -21,33 +21,64 @@ solrAdminApp.controller('AnalysisController',
$scope.refresh = function() {
stillalex commented on code in PR #1304:
URL: https://github.com/apache/solr/pull/1304#discussion_r1083316512
##
solr/webapp/web/js/angular/controllers/analysis.js:
##
@@ -137,16 +168,24 @@ solrAdminApp.controller('AnalysisController',
}
if (fieldOrType == "f
dsmiley merged PR #1243:
URL: https://github.com/apache/solr/pull/1243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
renatoh opened a new pull request, #1305:
URL: https://github.com/apache/solr/pull/1305
Fixing a small typo in one of the comments in sonrconfig.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
mkhludnev merged PR #1305:
URL: https://github.com/apache/solr/pull/1305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
renatoh opened a new pull request, #1306:
URL: https://github.com/apache/solr/pull/1306
Debugging FacetComponent I came noticed two little things which can be
improved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
mkhludnev commented on PR #1305:
URL: https://github.com/apache/solr/pull/1305#issuecomment-1399907200
@renatoh, could you please create branch_9x PR to backport this commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
mkhludnev merged PR #1306:
URL: https://github.com/apache/solr/pull/1306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
mkhludnev commented on PR #1306:
URL: https://github.com/apache/solr/pull/1306#issuecomment-1399907677
@renatoh, could you please create branch_9x PR to backport this commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
renatoh opened a new pull request, #1307:
URL: https://github.com/apache/solr/pull/1307
backporting "Debugging FacetComponent I noticed two little things which can
be improved"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
renatoh commented on PR #1306:
URL: https://github.com/apache/solr/pull/1306#issuecomment-1400035494
sure, have created another PR with target branch_9x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mkhludnev commented on PR #1307:
URL: https://github.com/apache/solr/pull/1307#issuecomment-1400065983
` Files changed 5,000+`
Not good. Ok maybe I put it wrong, but it's cherry-picking as described in
dev docs.
--
This is an automated message from the Apache Git Service.
To respond t
mkhludnev closed pull request #1307: Small code improvements in facet component
URL: https://github.com/apache/solr/pull/1307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
renatoh opened a new pull request, #1308:
URL: https://github.com/apache/solr/pull/1308
Debugging FacetComponent I noticed two little things which can be improved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
renatoh commented on PR #1308:
URL: https://github.com/apache/solr/pull/1308#issuecomment-1400117149
@mkhludnev Is the PR now correct? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
a-nych opened a new pull request, #520:
URL: https://github.com/apache/solr-operator/pull/520
Resolves #519.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
a-nych opened a new issue, #519:
URL: https://github.com/apache/solr-operator/issues/519
Steps to reproduce:
1. Run SolrCloud nodes with `podOptions.podSecurityContext.runAsUser` and
`podOptions.podSecurityContext.fsGroup` set to anything other than `8983`
(default SolrCloud user)
noblepaul merged PR #1309:
URL: https://github.com/apache/solr/pull/1309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
epugh commented on code in PR #1304:
URL: https://github.com/apache/solr/pull/1304#discussion_r1084211406
##
solr/webapp/web/js/angular/controllers/analysis.js:
##
@@ -21,33 +21,64 @@ solrAdminApp.controller('AnalysisController',
$scope.refresh = function() {
L
epugh commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1400570621
https://user-images.githubusercontent.com/22395/214083749-158ac761-ba50-4820-b221-5b52cd4293c6.png";>
I see the `?` from the bool... I was trying to figure out if there is
something we
epugh commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1400580787
https://user-images.githubusercontent.com/22395/214085226-599d3a5b-1b6d-40e5-a1d4-88355f5172f7.png";>
Ahh... Now I see the `@todo` reasonI wonder if the right fix is to
pick th
stillalex commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1400615323
> I see the ? from the bool... I was trying to figure out if there is
something we could put there, like "Bool" or something? But regardless, I like
how this works...
I would keep i
stillalex commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1400620486
> Maybe we don't need the default value if we just show the page, but don't
submit it to the backend, which then avoids the error message.
I agree with this idea, but the way the cur
gerlowskija merged PR #1286:
URL: https://github.com/apache/solr/pull/1286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
epugh commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1400648984
>
I started thinking about another param... but that feels a bit like the
`goto` statement of web dev. How hard would it be to change the query to
submit when you click the button?
epugh commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1400650619
> > I see the ? from the bool... I was trying to figure out if there is
something we could put there, like "Bool" or something? But regardless, I like
how this works...
>
> I would keep
stillalex commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1400705981
> How hard would it be to change the query to submit when you click the
button? Are there other places we link to the schema analysis page and have it
auto run, so that requiring a button
HoustonPutman commented on code in PR #520:
URL: https://github.com/apache/solr-operator/pull/520#discussion_r1084358734
##
controllers/util/solr_util.go:
##
@@ -594,6 +594,21 @@ func generateSolrSetupInitContainers(solrCloud
*solr.SolrCloud, solrCloudStatus
}
s
HoustonPutman commented on PR #516:
URL: https://github.com/apache/solr-operator/pull/516#issuecomment-1400737473
This looks good to me! We can merge this before the e2e tests, and add a
test for it after that is merged!
--
This is an automated message from the Apache Git Service.
To resp
HoustonPutman merged PR #518:
URL: https://github.com/apache/solr-operator/pull/518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
HoustonPutman commented on code in PR #520:
URL: https://github.com/apache/solr-operator/pull/520#discussion_r1084366285
##
controllers/util/solr_util.go:
##
@@ -594,6 +594,21 @@ func generateSolrSetupInitContainers(solrCloud
*solr.SolrCloud, solrCloudStatus
}
s
epugh commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1400748206
>
Sure! I can buy that. So... leave the todo? It otherwise looks good
to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
epugh commented on PR #1273:
URL: https://github.com/apache/solr/pull/1273#issuecomment-1400751651
@risdenk so the `console` seemed to work out really nicely Thoughts?
Love a +1 before I start plowing through the Ref Guide ;-)
--
This is an automated message from the Apache Git
stillalex commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1400790967
> Sure! I can buy that. So... leave the todo? It otherwise looks good to
merge.
yep, leave the todo. there is only that string matching issue in the combo
which I don't know how to
mkhludnev merged PR #1308:
URL: https://github.com/apache/solr/pull/1308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
mkhludnev commented on PR #1308:
URL: https://github.com/apache/solr/pull/1308#issuecomment-1400838707
Yeah! Right. Appreciate. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
HoustonPutman commented on PR #1308:
URL: https://github.com/apache/solr/pull/1308#issuecomment-1400846172
Did this go to `main` first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
HoustonPutman commented on PR #1273:
URL: https://github.com/apache/solr/pull/1273#issuecomment-1400849355
+1 from me
> I get that... Does it deal properly with the multiple line thing?
I tested it locally and it works as expected, only copying the lines that
start with `$`. Lo
epugh commented on PR #1273:
URL: https://github.com/apache/solr/pull/1273#issuecomment-1400853122
The multiline `curl` command even worked!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mkhludnev commented on PR #1308:
URL: https://github.com/apache/solr/pull/1308#issuecomment-1400870955
Absolutely, @HoustonPutman
https://github.com/apache/solr/pull/1305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
epugh commented on PR #1273:
URL: https://github.com/apache/solr/pull/1273#issuecomment-1401054406
Finished all the tutorials, which I guess are the most likely to have
straight up cut'n'paste?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dsmiley commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1084625105
##
solr/core/src/java/org/apache/solr/core/ConfigOverlay.java:
##
@@ -34,15 +34,15 @@
* performed on tbhis gives a new copy of the object with the changed value
*/
pu
dsmiley commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084758269
##
.github/workflows/solrj-test-crave.yml:
##
@@ -0,0 +1,41 @@
+name: SolrJ Tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ - '.github/work
uvatbc commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084773938
##
.github/workflows/solrj-test-crave.yml:
##
@@ -0,0 +1,41 @@
+name: SolrJ Tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ - '.github/workf
uvatbc commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084774129
##
.github/workflows/solrj-test-crave.yml:
##
@@ -0,0 +1,41 @@
+name: SolrJ Tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ - '.github/workf
uvatbc commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084774519
##
.github/workflows/solrj-test-crave.yml:
##
@@ -0,0 +1,41 @@
+name: SolrJ Tests
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service
uvatbc commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084774842
##
.github/workflows/solrj-test-crave.yml:
##
@@ -0,0 +1,41 @@
+name: SolrJ Tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ - '.github/workf
uvatbc commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084776393
##
.github/workflows/solrj-test-crave.yml:
##
@@ -0,0 +1,41 @@
+name: SolrJ Tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ - '.github/workf
elyograg commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084781451
##
.github/workflows/solrj-test-crave.yml:
##
@@ -0,0 +1,41 @@
+name: SolrJ Tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ - '.github/wor
uvatbc commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084786595
##
.github/workflows/solrj-test-crave.yml:
##
@@ -0,0 +1,41 @@
+name: SolrJ Tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ - '.github/workf
dsmiley commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084822103
##
.github/workflows/solrj-test-crave.yml:
##
@@ -0,0 +1,41 @@
+name: SolrJ Tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ - '.github/work
dsmiley commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084829522
##
.github/workflows/tests-via-crave.yml:
##
@@ -0,0 +1,38 @@
+name: Solr Tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+
+jobs:
+ test:
+name: Run Sol
mkhludnev opened a new pull request, #1310:
URL: https://github.com/apache/solr/pull/1310
Co-authored-by: Renato Haeberli <>
Cherry-pick #1305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mkhludnev commented on PR #1310:
URL: https://github.com/apache/solr/pull/1310#issuecomment-1401475305
cc @renatoh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
bszabo97 opened a new pull request, #1311:
URL: https://github.com/apache/solr/pull/1311
https://issues.apache.org/jira/browse/SOLR-16632
# Description
When expired documents are deleted periodically from the index we have a log
message about the
[start](https://gi
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1085229423
##
solr/solrj/src/test/org/apache/solr/client/solrj/response/TermsResponseTest.java:
##
@@ -31,16 +35,19 @@ public class TermsResponseTest extends
EmbeddedSolrServerTestBas
epugh commented on PR #1218:
URL: https://github.com/apache/solr/pull/1218#issuecomment-1401850595
I think I am slowly starting to grok what this is all about... Let me see
if I can state the value "Using a TestRule simplifies the setup of a test
by abstracting away a lot of the Sol
dsmiley commented on PR #1218:
URL: https://github.com/apache/solr/pull/1218#issuecomment-1402176092
> I think I am slowly starting to grok what this is all about... Let me see
if I can state the value "Using a TestRule simplifies the setup of a test
by abstracting away a lot of the Sol
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1084222675
##
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##
@@ -282,7 +282,12 @@ private String normalizePathToOsSeparator(String path) {
protected
HoustonPutman commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1085625134
##
solr/core/src/java/org/apache/solr/core/ConfigOverlay.java:
##
@@ -267,9 +267,14 @@ public ConfigOverlay deleteNamedPlugin(String name, String
typ) {
Map re
HoustonPutman commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1085627272
##
solr/core/src/java/org/apache/solr/core/ConfigOverlay.java:
##
@@ -34,15 +34,15 @@
* performed on tbhis gives a new copy of the object with the changed value
HoustonPutman commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1085629013
##
solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java:
##
@@ -984,4 +987,43 @@ public static void persistConfLocally(
// This is to verify if this re
HoustonPutman merged PR #516:
URL: https://github.com/apache/solr-operator/pull/516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
HoustonPutman closed issue #515: SolrBackup doesn't work when the collections
field is omitted
URL: https://github.com/apache/solr-operator/issues/515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
HoustonPutman commented on issue #515:
URL: https://github.com/apache/solr-operator/issues/515#issuecomment-1402369940
Once #507 is merged, we can add tests for this and make sure that it is good
to go for the next release.
--
This is an automated message from the Apache Git Service.
To r
HoustonPutman commented on PR #511:
URL: https://github.com/apache/solr-operator/pull/511#issuecomment-1402784282
Thanks for both of your thoughts!
As for the question on whether the liveness/readiness endpoint should be the
same, I do not think they should be eventually. I like `admi
tflobbe opened a new pull request, #1312:
URL: https://github.com/apache/solr/pull/1312
By resolving the full path of the pre-generated crypto keys in
`MiniSolrCloudCluster` we make sure it also works for third party projects
testing using Solr test framework
--
This is an automated mess
dsmiley commented on PR #1303:
URL: https://github.com/apache/solr/pull/1303#issuecomment-1403144847
I imagine Crave might work on a "self hosted runner" _eventually_ instead of
indirectly using GitHub runner:
https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-
dsmiley commented on PR #1303:
URL: https://github.com/apache/solr/pull/1303#issuecomment-1403146619
Looking at the GH Action results, the crave executable failed because of no
crave conf:
> Error: Configuration file not found. Zero conf not found: No matching
projects found for URL "htt
dsmiley opened a new pull request, #1313:
URL: https://github.com/apache/solr/pull/1313
https://issues.apache.org/jira/browse/SOLR-16629
TODO double-check compileOnly in SolrJ means won't result in transitive
dependency to 3rd parties. Or maybe we don't care?
Trying to see if
gerlowskija commented on PR #1286:
URL: https://github.com/apache/solr/pull/1286#issuecomment-1403678908
I merged this change on Monday but quickly reverted it when it caused some
build failures (a bad bug crept in when resolving some merge conflicts).
I've since fixed almost all of t
uvatbc commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1086751334
##
.github/workflows/tests-via-crave.yml:
##
@@ -0,0 +1,38 @@
+name: Solr Tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+
+jobs:
+ test:
+name: Run Solr
uvatbc commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1086751963
##
.github/workflows/tests-via-crave.yml:
##
@@ -0,0 +1,38 @@
+name: Solr Tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+
+jobs:
+ test:
+name: Run Solr
uvatbc commented on PR #1303:
URL: https://github.com/apache/solr/pull/1303#issuecomment-1403758318
Added the link "https://github.com/apache/solr"; to the ZeroConf
configuration as another alias for the Solr git repository.
The Github action should now work: The client binary should be a
HoustonPutman commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1086857155
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -178,9 +179,14 @@ private class ResourceProvider implements Function {
ZkSolrResourceLoade
HoustonPutman merged PR #511:
URL: https://github.com/apache/solr-operator/pull/511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
HoustonPutman closed issue #510: Look into better default values for Solr &
PrometheusExporter Probes
URL: https://github.com/apache/solr-operator/issues/510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
gerlowskija opened a new pull request, #1314:
URL: https://github.com/apache/solr/pull/1314
https://issues.apache.org/jira/browse/SOLR-16615
# Description
Currently, our Jersey integration involves creating an 'ApplicationHandler'
class for each SolrCore. These classes are exp
gerlowskija commented on PR #1286:
URL: https://github.com/apache/solr/pull/1286#issuecomment-1403986120
Turns out there isn't any way in GH to reopen merged PRs, so I've opened a
new PR ([here](https://github.com/apache/solr/pull/1314)) to continue iteration
on this functionality. Plannin
gerlowskija commented on PR #1314:
URL: https://github.com/apache/solr/pull/1314#issuecomment-1404005863
(Credit to Kevin for pointing this out). Anyone familiar with the previous
PR see what has changed since then with [this
link](https://github.com/gerlowskija/solr/compare/c21719ee2245bce
stillalex commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1404022543
@epugh gentle ping. are we good to merge, or is there something that needs
more work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
epugh commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1404038382
@magibney and I chatted, and we're going to leave it open till end of the
week in case anyone else has concerns about having a potentially longer list of
dynamic fields in the drop down ;-).
stillalex commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1404046037
makes sense, thanks for the update @epugh!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1087083741
##
solr/core/src/test/org/apache/solr/update/RootFieldTest.java:
##
@@ -54,7 +54,7 @@ public static void beforeTest() throws Exception {
solrClientTestRule.startSolr(Pa
gerlowskija commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1087094844
##
solr/core/src/java/org/apache/solr/jersey/JerseyAppHandlerCache.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
gerlowskija commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1087096093
##
solr/core/src/java/org/apache/solr/jersey/JerseyAppHandlerCache.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
gerlowskija commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1087098331
##
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##
@@ -225,7 +226,7 @@ public class SolrCore implements SolrInfoBean, Closeable {
private final Date start
gerlowskija commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1087098331
##
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##
@@ -225,7 +226,7 @@ public class SolrCore implements SolrInfoBean, Closeable {
private final Date start
gerlowskija commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1087101643
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -192,11 +193,16 @@ public CoreLoadFailure(CoreDescriptor cd, Exception
loadFailure) {
new
gerlowskija commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1087105926
##
solr/core/src/java/org/apache/solr/jersey/JerseyAppHandlerCache.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
epugh commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1087107239
##
.github/workflows/tests-via-crave.yml:
##
@@ -12,8 +12,9 @@ jobs:
runs-on: ubuntu-latest
steps:
-# Setup
-- uses: actions/checkout@v2
+- uses: act
gerlowskija commented on code in PR #1286:
URL: https://github.com/apache/solr/pull/1286#discussion_r1087123329
##
solr/core/src/java/org/apache/solr/jersey/JerseyAppHandlerCache.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
1 - 100 of 16397 matches
Mail list logo
