uvatbc commented on code in PR #1303:
URL: https://github.com/apache/solr/pull/1303#discussion_r1084786595


##########
.github/workflows/solrj-test-crave.yml:
##########
@@ -0,0 +1,41 @@
+name: SolrJ Tests
+
+on:
+  pull_request:
+    branches:
+      - 'main'
+    paths:
+      - '.github/workflows/solrj-test.yml'
+      - 'solr/solrj/**'
+
+jobs:
+  test:
+    name: Run SolrJ Tests
+
+    runs-on: ubuntu-latest
+
+    steps:
+    # Setup
+    - uses: actions/checkout@v2
+    - name: Set up JDK 11
+      uses: actions/setup-java@v2
+      with:
+        distribution: 'temurin'
+        java-version: 11
+        java-package: jdk
+    - name: Grant execute permission for gradlew
+      run: chmod +x gradlew
+    - uses: actions/cache@v2
+      with:
+        path: |
+          ~/.gradle/caches
+        key: ${{ runner.os }}-gradle-solrj-${{ hashFiles('versions.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-gradle-solrj-
+          ${{ runner.os }}-gradle-
+    - name: Get the Crave binary
+      run: curl -s 
https://raw.githubusercontent.com/accupara/crave/master/get_crave.sh | bash -s 
--
+    - name: Initialize gradle settings
+      run: ./crave run -- ./gradlew localSettings

Review Comment:
   @elyograg `nproc` seems to return "the number of cores available to your 
process". Through empirical testing on my X1 carbon, this seems to mean 
"hyperthreaded cores".
   
   Testing on the `n1-standard-96` set up that we have for Solr testing got me:
   ```
   19:23:12 uv@uv-x1:~/src/github.com/java/solr/solr$ crave ssh -- nproc
   96
   ```
   So it looks like it is hyperthreaded cores for sure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to