epugh commented on code in PR #1304:
URL: https://github.com/apache/solr/pull/1304#discussion_r1083292547
##########
solr/webapp/web/js/angular/controllers/analysis.js:
##########
@@ -137,16 +168,24 @@ solrAdminApp.controller('AnalysisController',
}
if (fieldOrType == "fieldname") {
- $location.search("analysis.fieldname", name);
- $location.search("analysis.fieldtype", null);
+ $location.search("analysis.fieldname", name);
Review Comment:
I don't love the whitespace change, however I see we have a werid mix of two
and four space indentations on if/else throughout this method! We need some
code styling tools for jS ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
