janhoy commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r829808444
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp1SolrClient.java
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foun
dsmiley commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r829965942
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp1SolrClient.java
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Fou
dsmiley commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r829970588
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java
##
@@ -34,7 +34,7 @@
* @since solr 8.0
*/
@SuppressWarnings
madrob merged pull request #748:
URL: https://github.com/apache/solr/pull/748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
madrob merged pull request #747:
URL: https://github.com/apache/solr/pull/747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
madrob merged pull request #747:
URL: https://github.com/apache/solr/pull/747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
janhoy commented on pull request #692:
URL: https://github.com/apache/solr/pull/692#issuecomment-1070899480
Are you ready to bring this up to date and merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
janhoy commented on a change in pull request #749:
URL: https://github.com/apache/solr/pull/749#discussion_r829247192
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
##
@@ -51,6 +50,10 @@
private Set liveNodes;
private Set hostAllowList;
dsmiley commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r829965942
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp1SolrClient.java
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Fou
HoustonPutman commented on a change in pull request #749:
URL: https://github.com/apache/solr/pull/749#discussion_r829213839
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
##
@@ -51,6 +50,10 @@
private Set liveNodes;
private Set hostAllow
madrob merged pull request #748:
URL: https://github.com/apache/solr/pull/748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
janhoy commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r829770160
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp1SolrClient.java
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache Software Foun
janhoy commented on pull request #749:
URL: https://github.com/apache/solr/pull/749#issuecomment-1072496155
> Some of this was already done by @haythemkh . I'm not sure it needs a
dedicated JIRA issue (compared to an overall issue for the other things for
separating SolrJ ZK).
Yea,
cpoerschke commented on a change in pull request #744:
URL: https://github.com/apache/solr/pull/744#discussion_r830143381
##
File path: solr/core/src/test/org/apache/solr/update/PeerSyncTest.java
##
@@ -213,26 +214,23 @@ public void test() throws Exception {
// now lets
madrob commented on a change in pull request #744:
URL: https://github.com/apache/solr/pull/744#discussion_r830162764
##
File path: solr/core/src/test/org/apache/solr/update/PeerSyncTest.java
##
@@ -213,26 +214,23 @@ public void test() throws Exception {
// now lets chec
anshumg closed pull request #647:
URL: https://github.com/apache/solr/pull/647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
anshumg merged pull request #746:
URL: https://github.com/apache/solr/pull/746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
anshumg opened a new pull request #751:
URL: https://github.com/apache/solr/pull/751
https://issues.apache.org/jira/browse/SOLR-16101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
anshumg merged pull request #751:
URL: https://github.com/apache/solr/pull/751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
anshumg opened a new pull request #752:
URL: https://github.com/apache/solr/pull/752
https://issues.apache.org/jira/browse/SOLR-16101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
anshumg merged pull request #752:
URL: https://github.com/apache/solr/pull/752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
ackepenek opened a new pull request #753:
URL: https://github.com/apache/solr/pull/753
https://issues.apache.org/jira/browse/SOLR-16005
# Description
Added "add field type" feature in to collection's schema screen.
# Solution
The button and functionali
epugh commented on pull request #745:
URL: https://github.com/apache/solr/pull/745#issuecomment-1073827388
Thanks @risdenk for the pointer!
One thing that I realized as I looked at #594 is that it also introduces a
better multiselect tool... I don't know which of the
http://githu
epugh commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1073834692
Thanks @ackepenek, left a review. How would you like to be credited in the
changelog???
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
ackepenek commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1073860416
> Thanks @ackepenek, left a review. How would you like to be credited in the
changelog???
Thanks for review. "Ahmet Can Kepenek" is good to be in changelog.
--
This is an
epugh commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1073863796
@ackepenek so I tried out the feature locally, and I really like it, but did
have a thought Instead of this being a hard coded to the `add-field-type`
command, what if instead i
ackepenek commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1074002756
> @ackepenek so I tried out the feature locally, and I really like it, but
did have a thought Instead of this being a hard coded to the
`add-field-type` command, what if inste
epugh commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1074006014
> If you are ok to manage the add, delete, replace operations with single
text area(json field). I can update the PR.
Go for it!
--
This is an automated message from the Ap
ackepenek commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1074055002
I improved the PR by comments.
latest screenshot:
https://user-images.githubusercontent.com/1234305/159296658-479d6afc-c14a-4ca8-b434-3a1a054c2884.png";>
--
Th
anshumg commented on pull request #692:
URL: https://github.com/apache/solr/pull/692#issuecomment-1074527817
I've updated the PR. There were more conflicts than I was expecting, so will
merge this in once someone confirms I didn't do something crazy here.
Thanks for your patience.
markrmiller commented on pull request #585:
URL: https://github.com/apache/solr/pull/585#issuecomment-1074584006
Okay, I had missed in the patch you passed me how you proposed dealing with
the toolchain dep issue - just using that instead of servlet-api - that seems
fine to me.
I sp
janhoy commented on a change in pull request #692:
URL: https://github.com/apache/solr/pull/692#discussion_r831863255
##
File path: solr/CHANGES.txt
##
@@ -244,12 +223,14 @@ when told to. The admin UI now tells it to. (Nazerke
Seidan, David Smiley)
* SOLR-11905: New Admin U
janhoy commented on pull request #692:
URL: https://github.com/apache/solr/pull/692#issuecomment-1074868902
I diffed the jira numbers and looked into the changes. All looks good to me,
except the remnants of merge markers ` HEAD` etc mentioned above.
After merge, please replace t
madrob commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1075247405
@epugh while I appreciate the idea of robustness here for add/delete/modify,
I also think we're losing some of the accessibility if we go that route. With
the add field/dynamic field
janhoy commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1075277102
> @epugh while I appreciate the idea of robustness here for
add/delete/modify, I also think we're losing some of the accessibility if we go
that route. With the add field/dynamic fie
epugh commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1075441419
Thank you for looking @madrob and @janhoy...So the first version that
@ackepenek had was basically the "Add field type Template". You just put in
the JSON, without the `add-fiel
anshumg commented on a change in pull request #692:
URL: https://github.com/apache/solr/pull/692#discussion_r832520160
##
File path: solr/CHANGES.txt
##
@@ -244,12 +223,14 @@ when told to. The admin UI now tells it to. (Nazerke
Seidan, David Smiley)
* SOLR-11905: New Admin
anshumg merged pull request #692:
URL: https://github.com/apache/solr/pull/692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
anshumg opened a new pull request #754:
URL: https://github.com/apache/solr/pull/754
Copied over the 9.0 section from `branch_9_0` after merging the CHANGELOG
consolidation PR for that branch.
I confirmed that none of the JIRAs listed in the `9.1` section were
duplicated in 9.0, how
paulkiernan opened a new pull request #755:
URL: https://github.com/apache/solr/pull/755
https://issues.apache.org/jira/browse/SOLR-16109
# Description
I'd like to be able to simply compare two SolrInputDocuments in unit tests
without absorbing all the overhead tha
epugh commented on pull request #755:
URL: https://github.com/apache/solr/pull/755#issuecomment-1076284701
I'm not the Java-head to have a strong opinon on this yay or nay, however if
we want to make these methods more usable by folks who maybe aren't already
Solr coders, could we get some
cpoerschke opened a new pull request #756:
URL: https://github.com/apache/solr/pull/756
No JIRA ticket as yet, so keeping as draft until there is one. Similar to
the https://github.com/apache/lucene/pull/737 change.
--
This is an automated message from the Apache Git Service.
To respond
janhoy commented on pull request #750:
URL: https://github.com/apache/solr/pull/750#issuecomment-1076393125
Brought the branch up to date and fixed spotless.
Beware of re-organization of 9.0 CHANGES section in #754 that may or may
affect this during merge, depending on which is merge
cpoerschke opened a new pull request #757:
URL: https://github.com/apache/solr/pull/757
https://issues.apache.org/jira/browse/SOLR-16111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
risdenk commented on pull request #745:
URL: https://github.com/apache/solr/pull/745#issuecomment-1076568542
https://github.com/angular-ui/ui-select is archived. So
https://github.com/machineboy2045/angular-selectize seems like a better option?
angular-selectize has some comparisons to ui-
epugh commented on pull request #745:
URL: https://github.com/apache/solr/pull/745#issuecomment-1076570987
Good point... The one thing I haven't been able to test out with
angular-selectize is the ability to resort your list of choices using your
mouse, this would be use ful for when the
paulkiernan commented on pull request #755:
URL: https://github.com/apache/solr/pull/755#issuecomment-1076632035
Sure thing, I'll take a look over the JavaDocs and add some information
there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
cpoerschke commented on pull request #755:
URL: https://github.com/apache/solr/pull/755#issuecomment-1076643318
Wondering if the comparators becoming static _and_ moving into a separate
class might also be something to consider, to make them (perhaps) more
discoverable for use in tests?
anshumg merged pull request #754:
URL: https://github.com/apache/solr/pull/754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
sonatype-lift[bot] commented on a change in pull request #716:
URL: https://github.com/apache/solr/pull/716#discussion_r833883166
##
File path:
solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java
##
@@ -0,0 +1,275 @@
+/*
+ * Licensed to the Apache Software
cpoerschke commented on a change in pull request #757:
URL: https://github.com/apache/solr/pull/757#discussion_r834052452
##
File path:
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java
##
@@ -431,14 +435,35 @@ protected Locale parseLocale(String languag
madrob opened a new pull request #759:
URL: https://github.com/apache/solr/pull/759
ZooKeeper has sufficient APIs now for us to no longer need to maintain
our own wrapper client.
https://issues.apache.org/jira/browse/SOLR-16114
--
This is an automated message from the Apache Git
HoustonPutman commented on a change in pull request #759:
URL: https://github.com/apache/solr/pull/759#discussion_r834511425
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java
##
@@ -57,6 +57,7 @@
* All Solr ZooKeeper interactions should go throu
anshumg merged pull request #758:
URL: https://github.com/apache/solr/pull/758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
HoustonPutman opened a new pull request #760:
URL: https://github.com/apache/solr/pull/760
https://issues.apache.org/jira/browse/SOLR-16116
This is still a WIP there are two outstanding issues:
- [ ] The hadoop-auth framework requires a different version of curator
- [ ] The
cpoerschke commented on a change in pull request #759:
URL: https://github.com/apache/solr/pull/759#discussion_r834516072
##
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##
@@ -1886,7 +1886,7 @@ public void reload(String name, UUID coreId) {
cpoerschke commented on a change in pull request #757:
URL: https://github.com/apache/solr/pull/757#discussion_r834574449
##
File path:
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java
##
@@ -431,14 +435,35 @@ protected Locale parseLocale(String languag
sonatype-lift[bot] commented on a change in pull request #760:
URL: https://github.com/apache/solr/pull/760#discussion_r834604185
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerRoleCmd.java
##
@@ -76,11 +76,11 @@ public void call(ClusterState st
HoustonPutman commented on a change in pull request #759:
URL: https://github.com/apache/solr/pull/759#discussion_r834627698
##
File path: solr/test-framework/src/java/org/apache/solr/cloud/ChaosMonkey.java
##
@@ -149,8 +152,7 @@ public void expireSession(final JettySolrRunner
madrob commented on a change in pull request #759:
URL: https://github.com/apache/solr/pull/759#discussion_r834636827
##
File path: solr/licenses/zookeeper-3.7.0-tests.jar.sha1
##
@@ -0,0 +1 @@
+093f2c34c33ee16f9ff3f9352c79eafd3cd9040a
Review comment:
We can look at it
cpoerschke commented on a change in pull request #750:
URL: https://github.com/apache/solr/pull/750#discussion_r834644743
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java
##
@@ -230,122 +166,1272 @@ public Builder(ClusterStateProvider st
madrob commented on a change in pull request #759:
URL: https://github.com/apache/solr/pull/759#discussion_r834655528
##
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##
@@ -1886,7 +1886,7 @@ public void reload(String name, UUID coreId) {
if (
madrob commented on a change in pull request #759:
URL: https://github.com/apache/solr/pull/759#discussion_r834660108
##
File path:
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java
##
@@ -791,14 +791,13 @@ public JettySolrRunner getReplicaJetty(Repl
madrob commented on a change in pull request #759:
URL: https://github.com/apache/solr/pull/759#discussion_r834660338
##
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
##
@@ -300,6 +301,7 @@ public static void setupTestCases() {
System.setPrope
madrob commented on a change in pull request #759:
URL: https://github.com/apache/solr/pull/759#discussion_r834689783
##
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
##
@@ -300,6 +301,7 @@ public static void setupTestCases() {
System.setPrope
dsmiley commented on pull request #750:
URL: https://github.com/apache/solr/pull/750#issuecomment-1078190099
Thanks for looking carefully Christine! I copied those javadocs directly
from the Http2 one so that's how it got that way.
--
This is an automated message from the Apache Git Ser
HoustonPutman commented on a change in pull request #760:
URL: https://github.com/apache/solr/pull/760#discussion_r834730709
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerRoleCmd.java
##
@@ -76,11 +76,11 @@ public void call(ClusterState state,
ackepenek commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1078775395
@madrob @janhoy @epugh
I am agree with @epugh. We should get better all admin panel to understand
what we can do. We should put info text to panel where we need. I think it is
cpoerschke commented on a change in pull request #759:
URL: https://github.com/apache/solr/pull/759#discussion_r835185774
##
File path: solr/test-framework/src/java/org/apache/solr/cloud/ZkTestServer.java
##
@@ -113,7 +112,7 @@
class ZKServerMain {
private volatile Se
dsmiley merged pull request #750:
URL: https://github.com/apache/solr/pull/750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
janhoy merged pull request #761:
URL: https://github.com/apache/solr/pull/761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
Seunghan-Jung opened a new issue #424:
URL: https://github.com/apache/solr-operator/issues/424
```
❯ kubectl get all
NAMEREADY STATUS
RESTARTS AGE
pod/example-solrcloud-0 1/1 Running
janhoy opened a new pull request #762:
URL: https://github.com/apache/solr/pull/762
https://issues.apache.org/jira/browse/SOLR-16117
This build change disable java compilation for the `solr:server` module,
which is a pure assembly module to assemble Jetty and other stuff in the
"sol
janhoy opened a new pull request #763:
URL: https://github.com/apache/solr/pull/763
https://issues.apache.org/jira/browse/SOLR-15852
Smoketester fixes for 9.0 RC1
* Test of source tarball is now done on the `gradlew dev` output folder
instead of inside source unpack where jars are
janhoy opened a new pull request #764:
URL: https://github.com/apache/solr/pull/764
https://issues.apache.org/jira/browse/SOLR-16118
I don't know why these were explicitly excluded in the first place, but the
smoke tester explicitly checks for these in all jar files, and all our hist
uschindler opened a new pull request #765:
URL: https://github.com/apache/solr/pull/765
This also cleans up signatures files to make use of new wildcard method
signatures feature.
I did not open an issue as this is trivial and is more build maintenance. I
will commit this to 9x and
madrob commented on pull request #765:
URL: https://github.com/apache/solr/pull/765#issuecomment-1079774559
Can you update
main/gradle/validation/forbidden-apis/commons-io.commons-io.all.txt as well?
--
This is an automated message from the Apache Git Service.
To respond to the message,
uschindler commented on pull request #765:
URL: https://github.com/apache/solr/pull/765#issuecomment-1079778770
> Can you update
main/gradle/validation/forbidden-apis/commons-io.commons-io.all.txt as well?
The copy methods? I don't know them, so I kept untouched.
--
This is an aut
uschindler commented on pull request #765:
URL: https://github.com/apache/solr/pull/765#issuecomment-1079795702
> > Can you update
main/gradle/validation/forbidden-apis/commons-io.commons-io.all.txt as well?
>
> The copy methods? I don't know them, so I kept untouched.
better
cpoerschke opened a new pull request #767:
URL: https://github.com/apache/solr/pull/767
https://issues.apache.org/jira/browse/SOLR-16120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
cpoerschke commented on a change in pull request #767:
URL: https://github.com/apache/solr/pull/767#discussion_r836282039
##
File path: solr/core/src/java/org/apache/solr/highlight/SolrHighlighter.java
##
@@ -91,13 +87,25 @@ protected boolean emptyArray(String[] arr) {
ret
jeanielamwh opened a new pull request #768:
URL: https://github.com/apache/solr/pull/768
https://issues.apache.org/jira/browse/SOLR-16111
# Description
Add a text input for `hl.queryFieldPattern` which was introduced in #757
