madrob commented on a change in pull request #763:
URL: https://github.com/apache/solr/pull/763#discussion_r836524450
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -836,12 +827,15 @@ def checkIdenticalMavenArtifacts(distFiles, artifacts,
version):
for artifact in artifacts:
if reJarWar.search(artifact):
artifactFilename = os.path.basename(artifact)
+ if artifactFilename in ['solr-test-framework-%s.jar' % version]:
+ print(' Skipping artifact %s as it should not be in the binary
distribution' % artifactFilename)
Review comment:
do we want to explicitly test that it was not included? I thought there
was a check against extra files but I can't find it now.
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -626,22 +626,23 @@ def verifyUnpacked(java, artifact, unpackPath,
gitRevision, version, testArgs):
print(" run tests w/ Java 11 and testArgs='%s'..." % testArgs)
java.run_java11('./gradlew --no-daemon test %s' % testArgs, '%s/test.log'
% unpackPath)
- print(" compile jars w/ Java 11")
- java.run_java11('./gradlew --no-daemon jar -Dversion.release=%s' %
version, '%s/compile.log' % unpackPath)
- print(" run interation tests w/ Java 11")
+ print(" run integration tests w/ Java 11")
java.run_java11('./gradlew --no-daemon integrationTest
-Dversion.release=%s' % version, '%s/itest.log' % unpackPath)
- testSolrExample(unpackPath, java.java11_home, True)
+ print(" build binary release w/ Java 11")
+ java.run_java11('./gradlew --no-daemon dev -Dversion.release=%s' %
version, '%s/compile.log' % unpackPath)
Review comment:
Should we call this `assemble.log` or compile could still be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
