janhoy commented on pull request #749:
URL: https://github.com/apache/solr/pull/749#issuecomment-1072496155


   > Some of this was already done by @haythemkh . I'm not sure it needs a 
dedicated JIRA issue (compared to an overall issue for the other things for 
separating SolrJ ZK).
   
   Yea, the PR #584 touches 264 source files, I forgot about it for a second, 
so this is perhaps duplicated.
   
   Problem with those huge PRs is that you don't get enough reviewers. Perhaps 
a central git feature branch is the way to go for this, and then open several 
small isolated PRs against that branch, and frequently merge in main branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to