HoustonPutman commented on a change in pull request #749:
URL: https://github.com/apache/solr/pull/749#discussion_r829213839
##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
##########
@@ -51,6 +50,10 @@
private Set<String> liveNodes;
private Set<String> hostAllowList;
+ // Copy of constants from ZkStateReader. Keep in sync if changed
+ public static final String NODE_NAME_PROP = "node_name";
Review comment:
I think that a good amount of those props in ZKStateReader could live
elsewhere and not be duplicated (since they aren't specific to ZK).
This includes the URL_SCHEME in the file above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
