ds-manzinger commented on PR #3179:
URL: https://github.com/apache/solr/pull/3179#issuecomment-2661052895
Yes, it is only in SolrJ. Our Company used that feature quite many years (I
think since Solr 4).
If there is a case, where a * in the middle of the name is possible, we can
add t
bruno-roustant commented on code in PR #3185:
URL: https://github.com/apache/solr/pull/3185#discussion_r1957163042
##
solr/core/src/java/org/apache/solr/handler/IncrementalShardBackup.java:
##
@@ -145,21 +145,22 @@ protected IncrementalShardSnapshotResponse backup(final
IndexCo
[
https://issues.apache.org/jira/browse/SOLR-17674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17674:
--
Labels: pull-request-available (was: )
> Update SolrCLI to reflect cloud mode is default
> ---
epugh commented on code in PR #2923:
URL: https://github.com/apache/solr/pull/2923#discussion_r1957226637
##
solr/modules/hdfs/src/java/org/apache/solr/hdfs/store/blockcache/package-info.java:
##
Review Comment:
@dsmiley I am ambivalent about this, especially when we say "h
epugh commented on PR #3026:
URL: https://github.com/apache/solr/pull/3026#issuecomment-2661194114
@sandbergja I don't want to lose this great work, can you sync it up and
then let's merge it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
[
https://issues.apache.org/jira/browse/SOLR-16465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-16465:
--
Labels: pull-request-available (was: )
> Start the migration of the Admin UI to React
> --
epugh commented on PR #1479:
URL: https://github.com/apache/solr/pull/1479#issuecomment-2661195095
We've got an active effort going on with the new Kotlin based "Solr UI", so
going to close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
epugh closed pull request #1479: SOLR-16465: Replace Login w/ React App
URL: https://github.com/apache/solr/pull/1479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
epugh commented on PR #3175:
URL: https://github.com/apache/solr/pull/3175#issuecomment-2661128777
thank you for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
epugh merged PR #3175:
URL: https://github.com/apache/solr/pull/3175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #3162:
URL: https://github.com/apache/solr/pull/3162#issuecomment-2661134311
@elangelo thanks for this... However, I am wondering if we need to go a
bit furthur...
@janhoy you often have good ideas on if something is the right way...
I am wondering,
epugh opened a new pull request, #3189:
URL: https://github.com/apache/solr/pull/3189
https://issues.apache.org/jira/browse/SOLR-17668
# Description
Add the cluster command to tool help output, and rearrange lines a bit to
format nicer.
--
This is an automated me
[
https://issues.apache.org/jira/browse/SOLR-17668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17668:
--
Labels: pull-request-available (was: )
> bin/solr cluster command missing from bin/solr -h
> -
Eric Pugh created SOLR-17674:
Summary: Update SolrCLI to reflect cloud mode is default
Key: SOLR-17674
URL: https://issues.apache.org/jira/browse/SOLR-17674
Project: Solr
Issue Type: Sub-task
epugh commented on PR #236:
URL: https://github.com/apache/solr/pull/236#issuecomment-2661120724
I've tried to take a stab at this, and honestly I think I made this one
worse.I think this is going to be one of those "someday if I need this, or
a smarter person comes along with a fix, le
epugh commented on PR #2693:
URL: https://github.com/apache/solr/pull/2693#issuecomment-2661120911
@cpoerschke if I can get a LGTM, I'll move forward with merging this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
malliaridis opened a new pull request, #3187:
URL: https://github.com/apache/solr/pull/3187
# Description
Some dependencies of the UI module are not properly aligned, others have
useful updates that can be applied.
# Solution
This PR does 3 things related to the UI modul
bruno-roustant commented on code in PR #3185:
URL: https://github.com/apache/solr/pull/3185#discussion_r1957082788
##
solr/core/src/java/org/apache/solr/core/DirectoryFactory.java:
##
@@ -55,10 +55,16 @@ public abstract class DirectoryFactory implements
NamedListInitializedPlug
malliaridis commented on PR #3184:
URL: https://github.com/apache/solr/pull/3184#issuecomment-2660860918
@HoustonPutman thanks for the links, very insightful.
> We'd have to make those lines, and the other two for desktop and browser,
configurable.
Not sure what you mean by con
dsmiley commented on PR #3184:
URL: https://github.com/apache/solr/pull/3184#issuecomment-2660938071
Ideally we submit an issue to get JetBrains to fix this and they do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
dsmiley commented on code in PR #3185:
URL: https://github.com/apache/solr/pull/3185#discussion_r1957129435
##
solr/core/src/java/org/apache/solr/handler/admin/api/ReplicationAPIBase.java:
##
@@ -246,6 +242,21 @@ protected FileListResponse getFileList(long generation,
Replicati
bruno-roustant commented on PR #3185:
URL: https://github.com/apache/solr/pull/3185#issuecomment-2660928987
This new commit makes the PR work. I added
DirectoryFactory.unwrapFor(Directory, DirUseContext) method, with a context to
potentially differentiate replication and backup.
--
This
dsmiley commented on PR #3185:
URL: https://github.com/apache/solr/pull/3185#issuecomment-2661224062
(A) seems kinda hard due to various entanglements that seem to assume one
cache entry per path or other complexities I see there. At least (B) would
actually only need to wrap dirs that are
dsmiley commented on code in PR #2923:
URL: https://github.com/apache/solr/pull/2923#discussion_r1957236372
##
solr/modules/hdfs/src/java/org/apache/solr/hdfs/store/blockcache/package-info.java:
##
Review Comment:
Thanks. Interestingly the package it used to live in was
o
dsmiley commented on PR #3179:
URL: https://github.com/apache/solr/pull/3179#issuecomment-2661233098
Yes Pattern is fine (as it was).
I hope this is tested, but I suppose maybe it isn't if tests pass without
the middle wildcard. Can you please add a test?
--
This is an automated messa
bruno-roustant commented on PR #3185:
URL: https://github.com/apache/solr/pull/3185#issuecomment-2661020011
As I see it, the need to unwrap is based on what the caller will use the
Directory for. So Im' not sure putting a lot of logic in CachingDirectory in
the best solution. Maybe the opti
epugh commented on PR #2693:
URL: https://github.com/apache/solr/pull/2693#issuecomment-2661091811
I think I figured out how to add the Lucene `queries` module to the local
Javadocs. I had to manually edit the lockfiles...
--
This is an automated message from the Apache Git Service.
To
epugh closed pull request #3026: SOLR-17618: Add unit tests for
org.apache.solr.util.TimeOut
URL: https://github.com/apache/solr/pull/3026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
sandbergja commented on PR #3026:
URL: https://github.com/apache/solr/pull/3026#issuecomment-2661201387
Thanks, @epugh (and everyone else who helped me with this)! It looks like
#3173 added tests that exercise all the methods exercised in this PR, so I
don't think this PR adds much value.
epugh commented on PR #3026:
URL: https://github.com/apache/solr/pull/3026#issuecomment-2661202254
Sure... I'll close it then, however I would love to see more commits.
Speak up if you are looking for ideas.. especially on the d...@solr.apache.org
mailing list. Or in Slack. Or any whe
30 matches
Mail list logo
