dsmiley commented on code in PR #2923: URL: https://github.com/apache/solr/pull/2923#discussion_r1957236372
########## solr/modules/hdfs/src/java/org/apache/solr/hdfs/store/blockcache/package-info.java: ########## Review Comment: Thanks. Interestingly the package it used to live in was org.apache.solr.store.blockcache but that "store" package doesn't have anything else nowadays so I guess blockcache at a kind of top level of Solr packages is fine. The ideal home for this is actually Lucene but I wouldn't want to donate something until it's used. Well it has been used and still is via Solr 9. Hmm. @markrmiller would you be interested in donating it given your hard work on it? I propose updating the javadocs for the package to be what I said above "A generic ....". You wrote "A blockcache implementation" and that's self-referential so not helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
