bruno-roustant commented on code in PR #3185:
URL: https://github.com/apache/solr/pull/3185#discussion_r1957082788
##########
solr/core/src/java/org/apache/solr/core/DirectoryFactory.java:
##########
@@ -55,10 +55,16 @@ public abstract class DirectoryFactory implements
NamedListInitializedPlugin, Cl
// Absolute.
protected Path dataHomePath;
- // hint about what the directory contains - default is index directory
+ /** Hint about what the directory contains or what the directory will be
used for. */
public enum DirContext {
+ /** Default is index directory. */
DEFAULT,
- META_DATA
+ /** Directory containing metadata. */
+ META_DATA,
+ /** Directory used to copy raw files during replication. */
+ REPLICATE,
+ /** Directory used to copy raw files during backup. */
+ BACKUP,
Review Comment:
Actually this very same question was discussed when I introduced
DelegatingBackupRepository. During backup, two different checksums are verified:
- The Lucene format checksum, to verify the file to backup is not corrupted.
This checksum can only be verified cleartext, so for encryption this means it
is verified by the EncryptionDirectory after decrypting.
- The file transfer checksum, to verify the bytes are identical at the
beginning and at the end of the copy. This checksum is verified by
IncrementalShardBackup, and can be verified on either raw or filtered bytes.
Currently it is on filtered bytes.
I specifically asked if we could skip the Lucene checksum verification in
the case of encryption. But since we want to ensure we do not backup a
corrupted file (which could replace an older valid one), then we have to check
the cleartext bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
