dsmiley commented on PR #3185: URL: https://github.com/apache/solr/pull/3185#issuecomment-2661224062
(A) seems kinda hard due to various entanglements that seem to assume one cache entry per path or other complexities I see there. At least (B) would actually only need to wrap dirs that are not DEFAULT. Also, the word "unwrap" pre-supposes an implementation detail that the callers should ideally not be exposed to and isn't necessarily accurate. Maybe it'll wrap not unwrap or do both or something new; who knows. Solr code using this should just give this DirContext hint as to what the dir will be used for. That's how it is now, albeit we see a bug and the use-cases (DirContext) listed are insufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
