epugh commented on PR #3029:
URL: https://github.com/apache/solr/pull/3029#issuecomment-2589605275
Could you explain a bit more what the general use case is? I read the
code, and I see lots of complex words I don't understand ;-).Maybe the Ref
Guide docs would make it all clear!
epugh commented on code in PR #3027:
URL: https://github.com/apache/solr/pull/3027#discussion_r1914614723
##
solr/solrj/src/java/org/apache/solr/common/ConfigNode.java:
##
@@ -93,9 +107,16 @@ default String attr(String name) {
return attributes().get(name);
}
- defaul
epugh commented on code in PR #3027:
URL: https://github.com/apache/solr/pull/3027#discussion_r1914615978
##
solr/core/src/java/org/apache/solr/core/PluginInfo.java:
##
@@ -100,39 +100,23 @@ public String toString() {
}
}
+ /** From XML. */
Review Comment:
i think
gerlowskija opened a new pull request, #3032:
URL: https://github.com/apache/solr/pull/3032
https://issues.apache.org/jira/browse/SOLR-17562
# Description
Several v2 APIs return raw files or streams of data, including:
ZooKeeperReadAPI, NodeFileStore, and CoreReplication.fetchF
[
https://issues.apache.org/jira/browse/SOLR-17562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17562:
--
Labels: pull-request-available (was: )
> Unify v2 API streaming support
>
epugh commented on code in PR #3031:
URL: https://github.com/apache/solr/pull/3031#discussion_r1914833957
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -534,7 +534,6 @@ public void refresh(String path) {
@SuppressWarnings({"rawtypes"})
gerlowskija commented on code in PR #2930:
URL: https://github.com/apache/solr/pull/2930#discussion_r1915243956
##
solr/api/src/java/org/apache/solr/client/api/endpoint/CollectionApis.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
gerlowskija commented on PR #2930:
URL: https://github.com/apache/solr/pull/2930#issuecomment-2590552508
> Perhaps HTTP DELETE for deleting them one at a time and we see if this is
good enough for folks?
OK, good call - I'll pursue that route for now.
--
This is an automated messag
madrob commented on code in PR #3031:
URL: https://github.com/apache/solr/pull/3031#discussion_r1915252465
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -534,7 +534,6 @@ public void refresh(String path) {
@SuppressWarnings({"rawtypes"})
QFREEE opened a new pull request, #3033:
URL: https://github.com/apache/solr/pull/3033
https://issues.apache.org/jira/browse/SOLR-6122
# Description
The PR implemented a new overseer level collection handler to cancel
submitted & in-progress collections api calls.
epugh opened a new pull request, #3031:
URL: https://github.com/apache/solr/pull/3031
https://issues.apache.org/jira/browse/SOLR-X
# Description
Migrate Schema Designer calls from using Blob store to FileStore
# Solution
Swap implementation methods.
epugh commented on PR #3031:
URL: https://github.com/apache/solr/pull/3031#issuecomment-2589942671
Progress so far @gerlowskija
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
epugh commented on code in PR #3031:
URL: https://github.com/apache/solr/pull/3031#discussion_r1914833957
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -534,7 +534,6 @@ public void refresh(String path) {
@SuppressWarnings({"rawtypes"})
gerlowskija commented on code in PR #2940:
URL: https://github.com/apache/solr/pull/2940#discussion_r1915077934
##
solr/solr-ref-guide/modules/indexing-guide/pages/reindexing.adoc:
##
@@ -165,6 +165,20 @@ Once the alias is in place and you are satisfied you no
longer need the o
gerlowskija commented on code in PR #2940:
URL: https://github.com/apache/solr/pull/2940#discussion_r1915089283
##
solr/solr-ref-guide/modules/indexing-guide/pages/reindexing.adoc:
##
@@ -165,6 +165,20 @@ Once the alias is in place and you are satisfied you no
longer need the o
gerlowskija commented on code in PR #2940:
URL: https://github.com/apache/solr/pull/2940#discussion_r1915077934
##
solr/solr-ref-guide/modules/indexing-guide/pages/reindexing.adoc:
##
@@ -165,6 +165,20 @@ Once the alias is in place and you are satisfied you no
longer need the o
gerlowskija commented on PR #3031:
URL: https://github.com/apache/solr/pull/3031#issuecomment-2590329199
Looks good to me so far. I notice this is still "Draft"; curious what else
is remaining here?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
gerlowskija commented on code in PR #3031:
URL: https://github.com/apache/solr/pull/3031#discussion_r1915099312
##
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java:
##
@@ -494,62 +498,59 @@ protected void validateTypeChange(String configSet,
HoustonPutman commented on PR #3024:
URL: https://github.com/apache/solr/pull/3024#issuecomment-2590708982
> LGTM, assuming this change is for `main` only and won't be backported to
branch_9x?
>
> Also, assuming you picked Java25 in some places as it's the next LTS after
Java 21?
QFREEE closed pull request #2790: SOLR-6122: POC cancel submitted not started
async task
URL: https://github.com/apache/solr/pull/2790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
solrbot commented on PR #3005:
URL: https://github.com/apache/solr/pull/3005#issuecomment-2591452513
### ⚠️ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably
do not want to merge this PR as-is.
♻ Renovate will retry this branch,
dsmiley commented on code in PR #2927:
URL: https://github.com/apache/solr/pull/2927#discussion_r1915917903
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -1170,6 +1171,21 @@ protected Object _getHandler() {
return handler;
}
+ /** Gets the cli
[
https://issues.apache.org/jira/browse/SOLR-17486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913165#comment-17913165
]
calelin commented on SOLR-17486:
Anyone has bandwidth to create a PR for this? If not ple
dsmiley commented on code in PR #2927:
URL: https://github.com/apache/solr/pull/2927#discussion_r1915918653
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -1170,6 +1171,21 @@ protected Object _getHandler() {
return handler;
}
+ /** Gets the cli
dsmiley merged PR #3030:
URL: https://github.com/apache/solr/pull/3030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913167#comment-17913167
]
Yuntong Qu commented on SOLR-6122:
--
Hi folks, raised another [PR|https://github.com/apach
dsmiley commented on PR #3030:
URL: https://github.com/apache/solr/pull/3030#issuecomment-2591621730
No delta to the POM, before & after. I see no signing info in the POM
though; not sure what to make of that. I'll merge.
--
This is an automated message from the Apache Git Service.
To r
dsmiley commented on code in PR #3031:
URL: https://github.com/apache/solr/pull/3031#discussion_r1915959864
##
solr/core/src/java/org/apache/solr/filestore/FileStore.java:
##
@@ -38,8 +42,13 @@ public interface FileStore {
*/
void put(FileEntry fileEntry) throws IOExcepti
dsmiley commented on code in PR #3032:
URL: https://github.com/apache/solr/pull/3032#discussion_r1915979535
##
solr/solrj/src/java/org/apache/solr/client/solrj/InputStreamResponse.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
clayburn opened a new pull request, #3035:
URL: https://github.com/apache/solr/pull/3035
# Description
This PR migrates the Solr project to publish Build Scans to the the new
Develocity instance at develocity.apache.org.
# Solution
N/A
# Tests
N/A
#
[
https://issues.apache.org/jira/browse/SOLR-17519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913086#comment-17913086
]
Houston Putman commented on SOLR-17519:
---
{quote}Another reason to exclusively use t
HoustonPutman commented on PR #2930:
URL: https://github.com/apache/solr/pull/2930#issuecomment-2591063358
> Personally, I'm worried the API design issues highlight deeper confusion
in the underlying functionality. Why do we support arbitrary properties in
"modify" that are somehow differen
gerlowskija commented on PR #2930:
URL: https://github.com/apache/solr/pull/2930#issuecomment-2591493830
I like "metadata" from a naming perspective.
> I do not think the two are as separate as we would like them to be.
Yeah, agreed. Worth some digging there to see what the ori
dsmiley commented on PR #2930:
URL: https://github.com/apache/solr/pull/2930#issuecomment-2591540203
+1 on "metadata" vs "properties" for nomenclature.
I was thinking about the earlier conundrum a bit. Let's just do PATCH to
`/api/collections/myCollName` to update anything updatable.
gerlowskija commented on PR #2930:
URL: https://github.com/apache/solr/pull/2930#issuecomment-2590915285
Ugh, actually, using an HTTP DELETE would conflict with existing paths.
- `DELETE /api/collections/someCollName/properties/somePropName` is my first
choice, but that conflicts with
[
https://issues.apache.org/jira/browse/SOLR-17568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913101#comment-17913101
]
David Smiley commented on SOLR-17568:
-
A scenario where this can happen is when a rep
dsmiley commented on PR #3030:
URL: https://github.com/apache/solr/pull/3030#issuecomment-2591304848
The only thing I want to do before merging is spot-check some generated
Maven POMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/SOLR-17519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913105#comment-17913105
]
David Smiley commented on SOLR-17519:
-
Houston:
When I said "the operator might want
HoustonPutman opened a new pull request, #3034:
URL: https://github.com/apache/solr/pull/3034
Fixing the same problem as https://github.com/apache/lucene/issues/14090
The full error is "VirtualMachineError: Out of space in CodeCache for
adapters in gradle"
The fix is to increas
epugh commented on PR #3034:
URL: https://github.com/apache/solr/pull/3034#issuecomment-2591048494
Thanks for this! I've been seeing this recently too...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
HoustonPutman merged PR #3024:
URL: https://github.com/apache/solr/pull/3024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
dsmiley merged PR #3027:
URL: https://github.com/apache/solr/pull/3027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #2927:
URL: https://github.com/apache/solr/pull/2927#issuecomment-2591610680
Ready to merge; will do within a couple days if I hear nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
43 matches
Mail list logo
