[ https://issues.apache.org/jira/browse/SOLR-17486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913165#comment-17913165 ]
calelin commented on SOLR-17486: -------------------------------- Anyone has bandwidth to create a PR for this? If not please let me know whether I could help create a PR. Thanks! > Potentially unused code in SolrDispatchFilter - abortErrorMessage > ----------------------------------------------------------------- > > Key: SOLR-17486 > URL: https://issues.apache.org/jira/browse/SOLR-17486 > Project: Solr > Issue Type: Bug > Affects Versions: main (10.0) > Reporter: Gus Heck > Priority: Minor > Attachments: image-2024-10-09-10-01-33-503.png > > > I was reading code on main, and noticed that SolrDispatchFilter has a string > field called abortErrorMessage. This is checked in HttpSolrCall, and the code > purports to exit if there is an abort message, but I see no place in code > where this is ever set. > It is protected access so maybe there's some intent to set it in an > overridden version of SolrDispatchFilter somewhere, that has become obsolete? > This code looks like it can be deleted. Raising this issue to find out if > anyone has a notion of why it should be retained. > !image-2024-10-09-10-01-33-503.png! -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org