QFREEE opened a new pull request, #3033: URL: https://github.com/apache/solr/pull/3033
https://issues.apache.org/jira/browse/SOLR-6122 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description The PR implemented a new overseer level collection handler to cancel submitted & in-progress collections api calls. As an example, this PR only opt-in backup collection api for in-progress cancel. in-progress collections api calls are not complete, as core level cancel is not implemented. Current implemention removes tracking of in-progress collections api from overseers, which can be useful in some situation like backup. # Solution General flow: -> Client request cancle with async ID through ```http://localhost:8983/solr/admin/collections?action=CANCEL&requestid=1``` -> Cancel message handled by `OverseerCancelMessageHandler` to determine if this asyncId exist and if it's currently in submitted or in-progress state : - if submitted: remove from `workQueue` and clear `blockedTasks` in case submitted task is in blocked tasks - if in-progress: check if is `isInProgressCancelable` -> remove in-progress tasks from tracking queues in overseer `workQueue` & `runningMap` & `runningTasks` Api: New V2 api interface for cancel handler Overseer: - stored asyncId on to ZK's running map to keep track of in-process async task easier - Adjust `OverseerTaskQueue` to handle remove / get item from queue given zk path OverseerCancelMessageHandler: - a new message handler specifically to handle cancel. Since cancel collections api involovs removing queue event from overseer's queue, added this part of logic as message handler instead of a new collection api # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
