cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840225404
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/ReverseSearchHandler.java:
##
@@ -0,0 +1,36 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation
risdenk commented on code in PR #2862:
URL: https://github.com/apache/solr/pull/2862#discussion_r1840233468
##
gradle/validation/error-prone.gradle:
##
@@ -236,7 +240,7 @@ allprojects { prj ->
// '-Xep:ThrowIfUncheckedKnownChecked:OFF', // we don't use this
annotat
malliaridis opened a new pull request, #2862:
URL: https://github.com/apache/solr/pull/2862
# Description
This PR updates Google error-prone to 2.31.0.
# Solution
In order to avoid blocking https://github.com/apache/solr/pull/2706 I have
updated Google error-prone and ad
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840198843
##
solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java:
##
@@ -115,6 +116,12 @@ public void process(ResponseBuilder rb) throws IOException
{
epugh commented on PR #2861:
URL: https://github.com/apache/solr/pull/2861#issuecomment-2473525638
I think stripping out the `` makes this a breaking change for 10
only???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
epugh commented on code in PR #2479:
URL: https://github.com/apache/solr/pull/2479#discussion_r1840259437
##
solr/core/src/java/org/apache/solr/cli/StreamTool.java:
##
@@ -0,0 +1,507 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
epugh commented on code in PR #2479:
URL: https://github.com/apache/solr/pull/2479#discussion_r1840261645
##
solr/core/src/java/org/apache/solr/cli/StreamTool.java:
##
@@ -0,0 +1,507 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840259984
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/ReverseSearchComponent.java:
##
@@ -0,0 +1,207 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundatio
malliaridis commented on PR #2862:
URL: https://github.com/apache/solr/pull/2862#issuecomment-2473699542
Thanks for the notes @risdenk. I will soon create another PR for applying
the rules and see what can be backported as well. We can then address the
existing rules as well. Is it fine to
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1840370734
##
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java:
##
@@ -92,8 +92,7 @@ public void init(final NamedList args) {
epugh commented on code in PR #2479:
URL: https://github.com/apache/solr/pull/2479#discussion_r1840260149
##
solr/core/src/java/org/apache/solr/cli/StreamTool.java:
##
@@ -0,0 +1,507 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
[
https://issues.apache.org/jira/browse/SOLR-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897958#comment-17897958
]
Andrzej Bialecki commented on SOLR-12723:
-
Agreed, +1 to remove that method.
How
malliaridis opened a new pull request, #2863:
URL: https://github.com/apache/solr/pull/2863
# Description
Backports errorprone update to 9x. See #2862 for details.
# Solution
Additional to the backported changes this PR removes unsupported static
keywords in inner classe
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840661574
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/SolrMonitorQueryCollector.java:
##
@@ -0,0 +1,104 @@
+/*
+ *
+ * * Licensed to the Apache Software Foun
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840617435
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/ReverseSearchComponent.java:
##
@@ -0,0 +1,207 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundat
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840249646
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/ReverseSearchComponent.java:
##
@@ -0,0 +1,207 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundatio
malliaridis commented on code in PR #2479:
URL: https://github.com/apache/solr/pull/2479#discussion_r1840275323
##
solr/core/src/java/org/apache/solr/cli/StreamTool.java:
##
@@ -0,0 +1,507 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribu
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840259984
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/ReverseSearchComponent.java:
##
@@ -0,0 +1,207 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundatio
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840564981
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/ReverseSearchComponent.java:
##
@@ -0,0 +1,223 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundat
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840807577
##
solr/modules/monitor/src/java/org/apache/lucene/monitor/MonitorFields.java:
##
@@ -0,0 +1,38 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF) under
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840828379
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/ReverseSearchComponent.java:
##
@@ -0,0 +1,223 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundat
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840828379
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/ReverseSearchComponent.java:
##
@@ -0,0 +1,223 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundat
HoustonPutman commented on PR #2861:
URL: https://github.com/apache/solr/pull/2861#issuecomment-2474331085
I mean, this is just changing the examples. I think we can back port this.
People should not be using the tech products config in production.
--
This is an automated message from the
Houston Putman created SOLR-17558:
-
Summary: Move ZK Watch Executor wrapping to Curator
Key: SOLR-17558
URL: https://issues.apache.org/jira/browse/SOLR-17558
Project: Solr
Issue Type: Sub-tas
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840998844
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/SolrMonitorQueryCollector.java:
##
@@ -0,0 +1,104 @@
+/*
+ *
+ * * Licensed to the Apache Software Founda
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1841001671
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/SolrMonitorQueryCollector.java:
##
@@ -0,0 +1,104 @@
+/*
+ *
+ * * Licensed to the Apache Software Founda
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1841003021
##
solr/modules/monitor/src/java/org/apache/lucene/monitor/DocumentBatchVisitor.java:
##
@@ -0,0 +1,64 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1841001671
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/SolrMonitorQueryCollector.java:
##
@@ -0,0 +1,104 @@
+/*
+ *
+ * * Licensed to the Apache Software Founda
epugh commented on code in PR #2479:
URL: https://github.com/apache/solr/pull/2479#discussion_r1840262175
##
solr/core/src/java/org/apache/solr/cli/StreamTool.java:
##
@@ -0,0 +1,507 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
risdenk opened a new pull request, #2864:
URL: https://github.com/apache/solr/pull/2864
https://issues.apache.org/jira/browse/SOLR-17545 /
https://github.com/apache/solr/pull/2848 inadvertently broke alternative JDK
support that some Jenkins jobs use to run different JDKs. One deprecated us
cugarte commented on PR #2788:
URL: https://github.com/apache/solr/pull/2788#issuecomment-2474555044
Thanks @gerlowskija ! The punting of "Problem 2" does resolve all of the
outstanding issues, and the commit I just pushed added the two missing bits of
documentation that you noted.
--
T
risdenk commented on code in PR #2862:
URL: https://github.com/apache/solr/pull/2862#discussion_r1840296908
##
gradle/validation/error-prone.gradle:
##
@@ -179,6 +179,7 @@ allprojects { prj ->
'-Xep:MathRoundIntLong:ERROR',
// '-Xep:MislabeledAndroidStr
epugh commented on PR #2479:
URL: https://github.com/apache/solr/pull/2479#issuecomment-2473647474
Leaning towards "execution" and either "local" or "remote".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840339347
##
solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java:
##
@@ -115,6 +116,12 @@ public void process(ResponseBuilder rb) throws IOException
{
malliaridis commented on code in PR #2862:
URL: https://github.com/apache/solr/pull/2862#discussion_r1840295379
##
gradle/validation/error-prone.gradle:
##
@@ -236,7 +240,7 @@ allprojects { prj ->
// '-Xep:ThrowIfUncheckedKnownChecked:OFF', // we don't use this
ann
risdenk commented on PR #2862:
URL: https://github.com/apache/solr/pull/2862#issuecomment-2473714247
Yes I think so that jira should probably be closed as "mostly done" by now
anyway :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
malliaridis merged PR #2862:
URL: https://github.com/apache/solr/pull/2862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-17182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck reassigned SOLR-17182:
---
Assignee: Gus Heck
> Eliminate the need for 'solr.useExitableDirectoryReader' sysprop
>
malliaridis commented on code in PR #2479:
URL: https://github.com/apache/solr/pull/2479#discussion_r1840282656
##
solr/core/src/java/org/apache/solr/cli/StreamTool.java:
##
@@ -0,0 +1,507 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribu
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840359108
##
solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java:
##
@@ -115,6 +116,12 @@ public void process(ResponseBuilder rb) throws IOException
{
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840522423
##
solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java:
##
@@ -115,6 +116,12 @@ public void process(ResponseBuilder rb) throws IOException
{
gus-asf commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1840660878
##
dev-docs/dependency-upgrades.adoc:
##
@@ -16,30 +16,34 @@
// specific language governing permissions and limitations
// under the License.
-Solr has lots of 3rd par
epugh commented on PR #2479:
URL: https://github.com/apache/solr/pull/2479#issuecomment-2473616312
@gerlowskija @malliaridis What do you think about using the word
"environment" versus "context" for the option you pass for execution? I.e,
your environment is either local or solr... Con
epugh commented on PR #2479:
URL: https://github.com/apache/solr/pull/2479#issuecomment-2474698022
@malliaridis in reference to your question, yeah -z never has a scheme, but
-s always does. Why exactly, not totally sure.. I guess that ZK communciates
over same port regardless of ssl or n
[
https://issues.apache.org/jira/browse/SOLR-17559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17559:
Description:
DocCollection (a collection's SolrCloud state) has a number of accessors that
return
epugh commented on code in PR #2479:
URL: https://github.com/apache/solr/pull/2479#discussion_r1841104745
##
solr/core/src/java/org/apache/solr/cli/StreamTool.java:
##
@@ -0,0 +1,507 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
epugh commented on code in PR #2479:
URL: https://github.com/apache/solr/pull/2479#discussion_r1841105384
##
solr/core/src/java/org/apache/solr/cli/StreamTool.java:
##
@@ -0,0 +1,507 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
epugh merged PR #2479:
URL: https://github.com/apache/solr/pull/2479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840966254
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/ReverseSearchComponent.java:
##
@@ -0,0 +1,223 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundat
risdenk merged PR #2864:
URL: https://github.com/apache/solr/pull/2864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-14673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898044#comment-17898044
]
ASF subversion and git services commented on SOLR-14673:
Commit 4
David Smiley created SOLR-17559:
---
Summary: DocCollection should be fully immutable.
Key: SOLR-17559
URL: https://issues.apache.org/jira/browse/SOLR-17559
Project: Solr
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SOLR-17535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898060#comment-17898060
]
ASF subversion and git services commented on SOLR-17535:
Commit 2
dsmiley merged PR #2846:
URL: https://github.com/apache/solr/pull/2846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-17559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned SOLR-17559:
---
Assignee: David Smiley
> DocCollection should be fully immutable.
>
[
https://issues.apache.org/jira/browse/SOLR-14673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-14673.
--
Fix Version/s: main (10.0)
Resolution: Fixed
Done!
> Add CLI for Streaming Expressions
> --
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1841589725
##
help/dependencies.txt:
##
@@ -100,12 +166,12 @@ If you want to upgrade Lucene to a newer build proceed
like the following:
queued)
- remember the build number
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1841589266
##
dev-docs/dependency-upgrades.adoc:
##
@@ -16,30 +16,34 @@
// specific language governing permissions and limitations
// under the License.
-Solr has lots of 3rd
malliaridis commented on PR #2706:
URL: https://github.com/apache/solr/pull/2706#issuecomment-2475456393
Thanks @gus-asf for your review and input. Your questions are pointing out
some of our upcoming TODOs. I'll leave some comments about the current state on
each of your comments, hopefull
gerlowskija commented on PR #2734:
URL: https://github.com/apache/solr/pull/2734#issuecomment-2474813720
Alright, merged in the latest 'main' and synced it with the changes here.
The only real change of note is that the interface file is now named
'ReplicationApis.java' (I went with the na
David Smiley created SOLR-17560:
---
Summary: DocCollection, don't need getLeaderReplicas(nodeName)
Key: SOLR-17560
URL: https://issues.apache.org/jira/browse/SOLR-17560
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-17559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17559:
Fix Version/s: main (10.0)
> DocCollection should be fully immutable.
> ---
[
https://issues.apache.org/jira/browse/SOLR-17560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17560:
Fix Version/s: main (10.0)
Labels: newdev (was: )
> DocCollection, don't need getLeader
63 matches
Mail list logo
