malliaridis commented on code in PR #2862: URL: https://github.com/apache/solr/pull/2862#discussion_r1840295379
########## gradle/validation/error-prone.gradle: ########## @@ -236,7 +240,7 @@ allprojects { prj -> // '-Xep:ThrowIfUncheckedKnownChecked:OFF', // we don't use this annotation '-Xep:ThrowNull:ERROR', '-Xep:TreeToString:ERROR', - // '-Xep:TruthSelfEquals:OFF', // we don't use truth + // '-Xep:SelfAssertion:OFF', // we don't use truth Review Comment: Oh, nice catch. I'll remove the `TruthSelfEquals` then and keep the todo for `SelfAssertion` as it seems that it does check more than `TruthSelfEquals` did. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org