kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1840359108
##########
solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java:
##########
@@ -115,6 +116,12 @@ public void process(ResponseBuilder rb) throws IOException
{
info.add("facet-debug", fdebug.getFacetDebugInfo());
}
+ ReverseSearchDebugInfo rsdebug =
+ (ReverseSearchDebugInfo)
(rb.req.getContext().get(ReverseSearchDebugInfo.KEY));
+ if (rsdebug != null) {
+ info.add("reverse-search-debug", rsdebug.getReverseSearchDebugInfo());
+ }
+
Review Comment:
I suppose an alternative way would be to introduce some normalized List of
`CustomInfoProviders` in the request context .. the inteface could like like:
```
interface CustomDebugInfoProvider {
SimpleOrderedMap<Object> asMap()
String name();
}
```
and you could fetch it via:
```
List<CustomDebugInfoProvider > customInfos = (List<CustomDebugInfoProvider
>) request.getContext().get("customDebugInfoProvider")
for (var customInfo: customInfos) {
info.add(customInfo.name(), customInfo.asMap());
}
```
LEt me know what you think .. I can also make a commit to clarify..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
