rmueller83 commented on code in PR #2705:
URL: https://github.com/apache/solr/pull/2705#discussion_r1756277133
##
solr/solr-ref-guide/modules/deployment-guide/pages/solr-in-docker.adoc:
##
@@ -342,6 +342,13 @@ Usage: jattach [args ...]
jcmd : execute jcmd command
[
https://issues.apache.org/jira/browse/SOLR-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reopened SOLR-17439:
Reopen for better docs
> jattach does not work with Solr in Docker
> -
janhoy commented on PR #2705:
URL: https://github.com/apache/solr/pull/2705#issuecomment-2345627630
Hi, thanks for this. It's a tiny doc change, so normally we don't attribute
it in CHANGES.txt and in release notes. However, we encourage you to keep
contributing and for a more substantial c
janhoy merged PR #2705:
URL: https://github.com/apache/solr/pull/2705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881219#comment-17881219
]
Jan Høydahl commented on SOLR-17439:
Note that a you CAN have Solr run as PID 1 by se
[
https://issues.apache.org/jira/browse/SOLR-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881221#comment-17881221
]
ASF subversion and git services commented on SOLR-17439:
Commit c
[
https://issues.apache.org/jira/browse/SOLR-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881222#comment-17881222
]
ASF subversion and git services commented on SOLR-17439:
Commit 9
janhoy commented on PR #2705:
URL: https://github.com/apache/solr/pull/2705#issuecomment-2345652951
Realized too late that the PR was against branch_9_7. Normally we make
changes to `main` first and then back port. This time I'll forward port to
main...
--
This is an automated message fr
[
https://issues.apache.org/jira/browse/SOLR-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881228#comment-17881228
]
ASF subversion and git services commented on SOLR-17439:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-17439.
Fix Version/s: 9.7
Resolution: Fixed
> jattach does not work with Solr in Docker
> -
[
https://issues.apache.org/jira/browse/SOLR-17447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881255#comment-17881255
]
Eric Pugh commented on SOLR-17447:
--
if your number one requirement is a latency (which m
cpoerschke commented on code in PR #2703:
URL: https://github.com/apache/solr/pull/2703#discussion_r1756550381
##
solr/bin/solr:
##
@@ -1076,10 +1076,8 @@ if [ "${SOLR_HOME:0:${#EXAMPLE_DIR}}" = "$EXAMPLE_DIR"
]; then
SOLR_LOGS_DIR="$SOLR_HOME/../logs"
fi
-# Set the loggi
epugh commented on code in PR #2684:
URL: https://github.com/apache/solr/pull/2684#discussion_r1756553717
##
solr/packaging/test/test_ssl.bats:
##
@@ -526,12 +526,14 @@ teardown() {
# server1 will run on $SOLR_PORT and will use server1.keystore
export SOLR_SSL_KEY_STORE=$s
epugh commented on code in PR #2684:
URL: https://github.com/apache/solr/pull/2684#discussion_r1756557886
##
solr/bin/solr.cmd:
##
@@ -426,7 +426,7 @@ IF "%1"=="-s" goto set_solr_url
IF "%1"=="--solr-url" goto set_solr_url
IF "%1"=="-solrUrl" goto set_solr_url
IF "%1"=="-a" g
epugh commented on code in PR #2684:
URL: https://github.com/apache/solr/pull/2684#discussion_r1756556905
##
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##
@@ -140,54 +140,54 @@ public List getOptions() {
.build(),
Option.builder()
epugh commented on PR #2684:
URL: https://github.com/apache/solr/pull/2684#issuecomment-2345837926
Thanks for going through and commenting @malliaridis, I just did some manual
testing with 9x and it all looks okay!
I ran:
```
bin/solr start -a "-Dsolr.jetty.sslContext.reload.sca
epugh commented on code in PR #2703:
URL: https://github.com/apache/solr/pull/2703#discussion_r1756570707
##
solr/bin/solr:
##
@@ -1076,10 +1076,8 @@ if [ "${SOLR_HOME:0:${#EXAMPLE_DIR}}" = "$EXAMPLE_DIR"
]; then
SOLR_LOGS_DIR="$SOLR_HOME/../logs"
fi
-# Set the logging ma
malliaridis commented on code in PR #2684:
URL: https://github.com/apache/solr/pull/2684#discussion_r1756584746
##
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##
@@ -140,54 +140,54 @@ public List getOptions() {
.build(),
Option.builder()
malliaridis commented on code in PR #2684:
URL: https://github.com/apache/solr/pull/2684#discussion_r1756584746
##
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##
@@ -140,54 +140,54 @@ public List getOptions() {
.build(),
Option.builder()
epugh commented on PR #2703:
URL: https://github.com/apache/solr/pull/2703#issuecomment-2345872563
Okay, so, after putting in the slf4j bridge, I see that the bats tests is
now failing (and thats a good thing) because it means we don't see the error:
```
not ok 85 SOLR-16976 solr s
malliaridis commented on PR #2684:
URL: https://github.com/apache/solr/pull/2684#issuecomment-2345885671
Thanks for the replies and for double-checking everything for me. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
epugh merged PR #2690:
URL: https://github.com/apache/solr/pull/2690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-17431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881264#comment-17881264
]
ASF subversion and git services commented on SOLR-17431:
Commit e
malliaridis closed pull request #2646: SOLR-17406: Introduce Version Catalogs
URL: https://github.com/apache/solr/pull/2646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
malliaridis commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2345913148
This PR is closed in favor to #2706, which does not include all the
dependency updates made here. They will be resolved in separate PRs.
--
This is an automated message from the Apache
epugh commented on PR #2693:
URL: https://github.com/apache/solr/pull/2693#issuecomment-2345949111
How do I compile the javadocs? I normally run `gw buildLocalSite` but that
doesn't get the docs! Can't find a mention in `:helpWorkflow` either!
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/SOLR-17431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881270#comment-17881270
]
ASF subversion and git services commented on SOLR-17431:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-17431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17431.
--
Fix Version/s: 9.8
Assignee: Eric Pugh
Resolution: Fixed
Another one completed!
> CLI:
[
https://issues.apache.org/jira/browse/SOLR-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-17442:
Assignee: Eric Pugh
> CLI: Resolve -v flag conflict (version, value, verbose)
> --
cpoerschke commented on PR #2693:
URL: https://github.com/apache/solr/pull/2693#issuecomment-2346050794
> How do I compile the javadocs? I normally run `gw buildLocalSite` but that
doesn't get the docs! Can't find a mention in `:helpWorkflow` either!
Thanks for taking a look! Interest
tboeghk commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1756203503
##
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##
@@ -133,18 +126,25 @@ public static String getCommitVersion(SolrCore solrCore) {
}
/**
-
tboeghk commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1756925343
##
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##
@@ -133,18 +126,25 @@ public static String getCommitVersion(SolrCore solrCore) {
}
/**
-
tboeghk commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1756930589
##
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##
@@ -133,18 +126,25 @@ public static String getCommitVersion(SolrCore solrCore) {
}
/**
-
cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1757002715
##
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##
@@ -133,18 +126,25 @@ public static String getCommitVersion(SolrCore solrCore) {
}
/**
cpoerschke commented on PR #2316:
URL: https://github.com/apache/solr/pull/2316#issuecomment-2346490565
> thanks @cpoerschke for your review on this! Definitly a better patch!
So just listing out likely remaining "TODO" items in case that's helpful?
- solr ref guide documentatio
sigram commented on PR #2288:
URL: https://github.com/apache/solr/pull/2288#issuecomment-2346594734
This became stale - I'll open a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
[
https://issues.apache.org/jira/browse/SOLR-17150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17150:
--
Labels: pull-request-available (was: )
> Create MemQueryLimit implementation
> ---
sigram closed pull request #2288: SOLR-17150: Create MemQueryLimit
implementation
URL: https://github.com/apache/solr/pull/2288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sigram opened a new pull request, #2708:
URL: https://github.com/apache/solr/pull/2708
This is a refreshed PR using the latest QueryLimit APIs and a thread-safe
accumulation of value, similar to the approach in `CpuAllowedLimit`. However,
since that class uses a thread-local managed by `Thr
szhou1998 commented on code in PR #2703:
URL: https://github.com/apache/solr/pull/2703#discussion_r1757550888
##
solr/bin/solr:
##
@@ -1076,10 +1076,8 @@ if [ "${SOLR_HOME:0:${#EXAMPLE_DIR}}" = "$EXAMPLE_DIR"
]; then
SOLR_LOGS_DIR="$SOLR_HOME/../logs"
fi
-# Set the loggin
[
https://issues.apache.org/jira/browse/SOLR-17447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881420#comment-17881420
]
Siju Varghese commented on SOLR-17447:
--
[~epugh] our latency budget for the "search
[
https://issues.apache.org/jira/browse/SOLR-17447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siju Varghese updated SOLR-17447:
-
Attachment:
Add_support_for_maxHits__Max_hits_is_a_hard_value_for_number__of_hits_the_searcher_it
[
https://issues.apache.org/jira/browse/SOLR-17447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881420#comment-17881420
]
Siju Varghese edited comment on SOLR-17447 at 9/12/24 10:16 PM:
---
43 matches
Mail list logo
