epugh commented on code in PR #2684: URL: https://github.com/apache/solr/pull/2684#discussion_r1756557886
########## solr/bin/solr.cmd: ########## @@ -426,7 +426,7 @@ IF "%1"=="-s" goto set_solr_url IF "%1"=="--solr-url" goto set_solr_url IF "%1"=="-solrUrl" goto set_solr_url IF "%1"=="-a" goto set_addl_opts -IF "%1"=="--additional-options" goto set_addl_opts Review Comment: Since we decided to go with `--jvm-opts` instead of ```-addopts` this was never released so we are okay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org