epugh commented on code in PR #2684:
URL: https://github.com/apache/solr/pull/2684#discussion_r1756553717
##########
solr/packaging/test/test_ssl.bats:
##########
@@ -526,12 +526,14 @@ teardown() {
# server1 will run on $SOLR_PORT and will use server1.keystore
export SOLR_SSL_KEY_STORE=$ssl_dir/server1.keystore.p12
export SOLR_SSL_TRUST_STORE=$ssl_dir/server1.keystore.p12
- solr start -c -a "-Dsolr.jetty.sslContext.reload.scanInterval=1
-DsocketTimeout=5000"
+ solr start -c --jvm-opts "-Dsolr.jetty.sslContext.reload.scanInterval=1
-DsocketTimeout=5000"
solr assert --started https://localhost:${SOLR_PORT} --timeout 5000
# server2 will run on $SOLR2_PORT and will use server2.keystore. Initially,
this is the same as server1.keystore
export SOLR_SSL_KEY_STORE=$ssl_dir/server2.keystore.p12
export SOLR_SSL_TRUST_STORE=$ssl_dir/server2.keystore.p12
+
+ # leaving -a instead of --jvm-opts for back compat testing.
solr start -c -z localhost:${ZK_PORT} -p ${SOLR2_PORT} -a
"-Dsolr.jetty.sslContext.reload.scanInterval=1 -DsocketTimeout=5000"
Review Comment:
I am going to double check now by hand on main and branch_9x. I believe it
will work because we left that `-a` in the parsing logic for the `start`
command...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
