cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1757002715
##########
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##########
@@ -133,18 +126,25 @@ public static String getCommitVersion(SolrCore solrCore) {
}
/**
- * Determine the poll interval for replicas based on the auto soft/hard
commit schedule
+ * Determine the poll interval for replicas based on the auto soft/hard
commit schedule or
+ * configured commit poll interval
*
* @param uinfo the update handler info containing soft/hard commit
configuration
* @return a poll interval string representing a cadence of polling
frequency in the form of
- * hh:mm:ss
+ * hh:mm:ss, never <code>null</code>
Review Comment:
Ah, I mis-read the comment and thought that "never" was a string value that
could be returned when actually the comment was about a `null` value meaning
never.
Yes, if null is never returned then no need to comment about it in the
javadocs (and then also no need for the caller to consider what to do when null
is returned).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
