Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-08-23 Thread via GitHub
luiseterc commented on PR #2571: URL: https://github.com/apache/solr/pull/2571#issuecomment-2306678676 Thanks @janhoy We'll do that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[I] [Regression] security.json is not uploaded during the first initialization of SolrCloud [solr-operator]

2024-08-23 Thread via GitHub
erwanval opened a new issue, #720: URL: https://github.com/apache/solr-operator/issues/720 This is a regression caused by [#660](https://github.com/apache/solr-operator/pull/660). During the first initialization of SolrCloud, the security.json doesn't exists in Zookeeper, which cause

Re: [PR] SOLR-17400: remove deprecated snapshot related code [solr]

2024-08-23 Thread via GitHub
epugh merged PR #2659: URL: https://github.com/apache/solr/pull/2659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Resolved] (SOLR-17400) Remove deprecated snapshotscli.sh from main

2024-08-23 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17400. -- Resolution: Fixed > Remove deprecated snapshotscli.sh from main > -

[jira] [Commented] (SOLR-17400) Remove deprecated snapshotscli.sh from main

2024-08-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876240#comment-17876240 ] ASF subversion and git services commented on SOLR-17400: Commit 4

Re: [PR] Review SolrJ code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2656: URL: https://github.com/apache/solr/pull/2656#discussion_r1728881870 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBase.java: ## @@ -121,7 +121,7 @@ protected ResponseParser responseParser(SolrRequest solrRequest) {

Re: [PR] Review SolrJ code for typos [solr]

2024-08-23 Thread via GitHub
epugh merged PR #2656: URL: https://github.com/apache/solr/pull/2656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-08-23 Thread via GitHub
dweiss commented on PR #2646: URL: https://github.com/apache/solr/pull/2646#issuecomment-2306992445 I would keep any upgrades from infrastructure changes separate. You can then diff/ compare the final artifacts and see what's changed before doing any updates. -- This is an automated mess

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1728897327 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/Matrix.java: ## @@ -61,8 +61,8 @@ public List getRowLabels() { return rowLabels; } - public

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on PR #2657: URL: https://github.com/apache/solr/pull/2657#issuecomment-2307002076 This is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Branch_9x] Bump up gradle analyze dependency to 1.10.0 [solr]

2024-08-23 Thread via GitHub
iamsanjay merged PR #2660: URL: https://github.com/apache/solr/pull/2660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-17321) Bump minimum required Java version to 21

2024-08-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876259#comment-17876259 ] ASF subversion and git services commented on SOLR-17321: Commit f

Re: [PR] SOLR-17399: Replace the use of the deprecated java.util.Locale ctor [solr]

2024-08-23 Thread via GitHub
iamsanjay merged PR #2633: URL: https://github.com/apache/solr/pull/2633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-17399) Replace the use of the deprecated java.util.Locale constructor with Locale Builder API

2024-08-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876268#comment-17876268 ] ASF subversion and git services commented on SOLR-17399: Commit c

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-08-23 Thread via GitHub
malliaridis commented on PR #2646: URL: https://github.com/apache/solr/pull/2646#issuecomment-2307147732 Yeah I agree. I already started the process of splitting the PR into two, one for infra and one for the dependency updates. I am facing a few version differences with non-conflicting dep

Re: [PR] SOLR-17399: Replace the use of the deprecated java.util.Locale ctor [solr]

2024-08-23 Thread via GitHub
iamsanjay commented on PR #2633: URL: https://github.com/apache/solr/pull/2633#issuecomment-2307158372 I was preparing it for backporting and before merge it to 9.x, ran the check on crave. One test case failed! ``` ERROR: The following test(s) have failed: - org.apache.solr.

Re: [PR] SOLR-17399: Replace the use of the deprecated java.util.Locale ctor [solr]

2024-08-23 Thread via GitHub
iamsanjay commented on PR #2633: URL: https://github.com/apache/solr/pull/2633#issuecomment-2307199250 git bisect points to 7af8b82db2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] SOLR-17381: Make CLUSTERSTATUS configurable [solr]

2024-08-23 Thread via GitHub
iamsanjay commented on PR #2599: URL: https://github.com/apache/solr/pull/2599#issuecomment-2307201061 git bisect points to this commit! ``` ERROR: The following test(s) have failed: - org.apache.solr.client.solrj.impl.ClusterStateProviderTest.testGetClusterState (:solr:solrj)

[jira] [Commented] (SOLR-17399) Replace the use of the deprecated java.util.Locale constructor with Locale Builder API

2024-08-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876278#comment-17876278 ] ASF subversion and git services commented on SOLR-17399: Commit 4

Re: [PR] SOLR-17399: Replace the use of the deprecated java.util.Locale ctor [solr]

2024-08-23 Thread via GitHub
iamsanjay commented on PR #2633: URL: https://github.com/apache/solr/pull/2633#issuecomment-2307216717 Backported to 9.x! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (SOLR-17421) With overseer node role enabled, overseer may be stopped without giving-up leadership

2024-08-23 Thread Pierre Salagnac (Jira)
Pierre Salagnac created SOLR-17421: -- Summary: With overseer node role enabled, overseer may be stopped without giving-up leadership Key: SOLR-17421 URL: https://issues.apache.org/jira/browse/SOLR-17421

Re: [PR] SOLR-17321: Bump minimum required Java version to 21 [solr]

2024-08-23 Thread via GitHub
iamsanjay closed pull request #2497: SOLR-17321: Bump minimum required Java version to 21 URL: https://github.com/apache/solr/pull/2497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
cpoerschke commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1729208565 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/NotNullEvaluator.java: ## @@ -45,7 +45,7 @@ public Object doWork(Object... values) throws IOExcept

[jira] [Commented] (SOLR-7871) Platform independent config file instead of solr.in.sh and solr.in.cmd

2024-08-23 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876316#comment-17876316 ] Jan Høydahl commented on SOLR-7871: --- Lots of stuff happened since last activity on this

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1729254232 ## solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/StreamingTest.java: ## @@ -1348,7 +1348,7 @@ private void checkReturnValsForEmpty(String[] fields) t

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1729255006 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/MergeStream.java: ## @@ -224,7 +224,7 @@ public Tuple read() throws IOException { // If all EO

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1729256408 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/HashJoinStream.java: ## @@ -55,7 +55,7 @@ public class HashJoinStream extends TupleStream implements

Re: [PR] Review Solr Streaming code for typos [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1729257930 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/OutliersEvaluator.java: ## @@ -97,13 +97,13 @@ public Object doWork(Object... values) throws IOExceptio

[PR] remove use of deprecated SolrIndexSearcher.search variant [solr]

2024-08-23 Thread via GitHub
cpoerschke opened a new pull request, #2662: URL: https://github.com/apache/solr/pull/2662 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Refactor: QueryResult: don't provide to SolrIndexSearcher [solr]

2024-08-23 Thread via GitHub
cpoerschke commented on code in PR #2524: URL: https://github.com/apache/solr/pull/2524#discussion_r1729272808 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -716,6 +716,12 @@ public boolean regenerateItem( } } + /** Primary entrypoint for

Re: [PR] remove use of deprecated SolrIndexSearcher.search variant [solr]

2024-08-23 Thread via GitHub
cpoerschke commented on PR #2662: URL: https://github.com/apache/solr/pull/2662#issuecomment-2307492804 https://github.com/apache/solr/actions/runs/10529517119/job/29177462369?pr=2662 CI failure seems unrelated ``` ./gradlew :solr:core:test --tests "org.apache.solr.cloud.api.coll

Re: [PR] remove use of deprecated SolrIndexSearcher.search variant [solr]

2024-08-23 Thread via GitHub
epugh commented on PR #2662: URL: https://github.com/apache/solr/pull/2662#issuecomment-2307495270 Will we be able to remove the deprecated `QueryResult search(QueryResult qr, QueryCommand cmd)` method in `main`? Do we every label something Deprecated but don't mean to remove it for a lon

[PR] SOLR-17421: Make sure overseer drops leadership after QUIT failure [solr]

2024-08-23 Thread via GitHub
psalagnac opened a new pull request, #2663: URL: https://github.com/apache/solr/pull/2663 https://issues.apache.org/jira/browse/SOLR-17421 # Description Overseer might be stop after a failure of the `QUIT` operation if we don't give up on leadership (see Jira). A

[PR] support Lucene's (proposed) HNSW search seeding feature [solr]

2024-08-23 Thread via GitHub
cpoerschke opened a new pull request, #2664: URL: https://github.com/apache/solr/pull/2664 See https://github.com/apache/lucene/issues/13634 issue and @seanmacavaney's https://github.com/apache/lucene/pull/13635 draft for context. -- This is an automated message from the Apache Git Servic

[jira] [Updated] (SOLR-17421) With overseer node role enabled, overseer may be stopped without giving-up leadership

2024-08-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17421: -- Labels: pull-request-available (was: ) > With overseer node role enabled, overseer may be stop

Re: [PR] Migrate from Gradle Enterprise Gradle Plugin to Develocity Gradle Plugin [solr]

2024-08-23 Thread via GitHub
dsmiley commented on PR #2642: URL: https://github.com/apache/solr/pull/2642#issuecomment-2307566750 Thanks Clay; I'll merge this tonight/tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (SOLR-12429) ZK upconfig throws confusing error when it encounters a symlink

2024-08-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876347#comment-17876347 ] David Smiley commented on SOLR-12429: - Why block symlinks; shouldn't they be supporte

Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]

2024-08-23 Thread via GitHub
dsmiley commented on code in PR #2632: URL: https://github.com/apache/solr/pull/2632#discussion_r1729408777 ## solr/core/src/java/org/apache/solr/search/facet/MissingAgg.java: ## @@ -45,7 +45,7 @@ public SlotAcc createSlotAcc(FacetContext fcontext, long numDocs, int numSlots)

Re: [PR] SOLR-12429: Prevent symbolic links from being uploaded as part of a configset [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2651: URL: https://github.com/apache/solr/pull/2651#discussion_r1729415225 ## solr/core/src/java/org/apache/solr/util/FileTypeMagicUtil.java: ## @@ -60,6 +60,14 @@ public static void assertConfigSetFolderLegal(Path confPath) throws IOException

Re: [PR] SOLR-12429: Prevent symbolic links from being uploaded as part of a configset [solr]

2024-08-23 Thread via GitHub
epugh commented on code in PR #2651: URL: https://github.com/apache/solr/pull/2651#discussion_r1729415225 ## solr/core/src/java/org/apache/solr/util/FileTypeMagicUtil.java: ## @@ -60,6 +60,14 @@ public static void assertConfigSetFolderLegal(Path confPath) throws IOException

Re: [PR] SOLR-17180: Deprecate snapshotscli.sh in favour of bin/solr sub commands. [solr]

2024-08-23 Thread via GitHub
malliaridis commented on PR #2381: URL: https://github.com/apache/solr/pull/2381#issuecomment-2307848943 Great job adding documentation on this one. That's a very useful addition to the referene guide. 👍 -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] SOLR-17180: Deprecate snapshotscli.sh in favour of bin/solr sub commands. [solr]

2024-08-23 Thread via GitHub
epugh commented on PR #2381: URL: https://github.com/apache/solr/pull/2381#issuecomment-2307851372 > Great job adding documentation on this one. That's a very useful addition to the referene guide. 👍 I appreciate it! I did it partly because you called it out! -- This is an automat

Re: [PR] SOLR-17180: Deprecate snapshotscli.sh in favour of bin/solr sub commands. [solr]

2024-08-23 Thread via GitHub
epugh commented on PR #2381: URL: https://github.com/apache/solr/pull/2381#issuecomment-2307852130 I would love a bot that would jsut delete code that wasn't documented ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (SOLR-12429) ZK upconfig throws confusing error when it encounters a symlink

2024-08-23 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876374#comment-17876374 ] Eric Pugh commented on SOLR-12429: -- Gus asked the same question on the PR...   Right now