epugh commented on code in PR #2657: URL: https://github.com/apache/solr/pull/2657#discussion_r1729256408
########## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/HashJoinStream.java: ########## @@ -55,7 +55,7 @@ public class HashJoinStream extends TupleStream implements Expressible { protected Tuple workingFullTuple = null; protected String workingFullHash = null; - protected int workngHashSetIdx = 0; + protected int workingHashSetIdx = 0; Review Comment: this would be a good thing right? that way they know to fix their bug right! I don't really want to spend a ton of effort on this deprecation for some code that I don't know has many users or has a logical easy way to emit deprecations etc... Unless we just deprecate in the java code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org