cpoerschke commented on code in PR #2657:
URL: https://github.com/apache/solr/pull/2657#discussion_r1729208565
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/NotNullEvaluator.java:
##########
@@ -45,7 +45,7 @@ public Object doWork(Object... values) throws IOException {
}
if (values[0] instanceof String) {
- // Check to see if the this tuple had a null value for that string.
+ // Check to see if this tuple had a null value for that string.
Review Comment:
```suggestion
// Check to see if this tuple had a null value for that string.
```
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/eval/OutliersEvaluator.java:
##########
@@ -97,13 +97,13 @@ public Object doWork(Object... values) throws IOException {
double cumProb = d.cumulativeProbability(n.intValue());
if (low >= 0 && cumProb <= low) {
t.put("lowOutlierValue_d", n);
- t.put("cumulativeProbablity_d", cumProb);
+ t.put("cumulativeProbability_d", cumProb);
Review Comment:
Wondering if this is "user facing" i.e. change in input or output 'contract'
of the evaluator?
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/BiJoinStream.java:
##########
@@ -28,8 +28,8 @@
import org.apache.solr.client.solrj.io.stream.expr.StreamFactory;
/**
- * Joins leftStream with rightStream based on a Equalitor. Both streams must
be sorted by the fields
- * being joined on. Resulting stream is sorted by the equalitor.
+ * Joins leftStream with rightStream based on an Equalitor. Both streams must
be sorted by the
Review Comment:
```suggestion
* Joins leftStream with rightStream based on an {@link StreamEqualitor}.
Both streams must be sorted by the
```
##########
solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/StreamingTest.java:
##########
@@ -1348,7 +1348,7 @@ private void checkReturnValsForEmpty(String[] fields)
throws IOException {
}
}
- // Goes away after after LUCENE-7548
+ // Goes away after LUCENE-7548
Review Comment:
```suggestion
// Goes away after LUCENE-7548 a.k.a.
https://github.com/apache/lucene/issues/8599
```
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CartesianProductStream.java:
##########
@@ -277,7 +277,8 @@ private Deque<Tuple> generateTupleList(Tuple original)
throws IOException {
private boolean iterate(
List<NamedEvaluator> evaluators, int[] indexes, Map<String, Object>
evaluatedValues) {
- // this assumes evaluators and indexes are the same length, which is ok
cause we created it so
+ // this assumes evaluators and indexes are the same length, which is ok
because we created it,
+ // so
// we know it is
Review Comment:
```suggestion
// so we know it is
```
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/MergeStream.java:
##########
@@ -224,7 +224,7 @@ public Tuple read() throws IOException {
// If all EOF then min will be null, else min is the current minimum
if (null == minimum) {
- // return EOF, doesn't matter which cause we're done
+ // return EOF, doesn't matter which because we're done
Review Comment:
not sure if this comment actually contradicts the code? maybe leave as-is or
remove.
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/HashJoinStream.java:
##########
@@ -55,7 +55,7 @@ public class HashJoinStream extends TupleStream implements
Expressible {
protected Tuple workingFullTuple = null;
protected String workingFullHash = null;
- protected int workngHashSetIdx = 0;
+ protected int workingHashSetIdx = 0;
Review Comment:
observation: deriving classes referencing the class member will get build
failure (or weirdness if deploying X.Y custom jar with X.Y+1 base jar)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
