epugh commented on code in PR #2651:
URL: https://github.com/apache/solr/pull/2651#discussion_r1729415225


##########
solr/core/src/java/org/apache/solr/util/FileTypeMagicUtil.java:
##########
@@ -60,6 +60,14 @@ public static void assertConfigSetFolderLegal(Path confPath) 
throws IOException
         new SimpleFileVisitor<>() {
           @Override
           public FileVisitResult visitFile(Path file, BasicFileAttributes 
attrs) {
+            if (Files.isSymbolicLink(file)) {

Review Comment:
   So, right now symbolic links don't work, they blow up with a cryptic error.  
This PR replaces the cryptic error with a nicer error!   I think your 
suggestion is interesting, and if we wanted to support symbolic link lookup, 
that sounds like a nice addition to do in a seperate PR that removes the 
limitation.   Does that sound reasonable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to