iamsanjay commented on PR #2501:
URL: https://github.com/apache/solr/pull/2501#issuecomment-2164742464
> Why use ForbiddenAPI for a deprecated thing?
As we are still in migration phase, It will not be deprecated until we move
onto Java 21. Meanwhile, If someone tries to use it , they
uschindler commented on PR #2501:
URL: https://github.com/apache/solr/pull/2501#issuecomment-2164786335
> Why use ForbiddenAPI for a deprecated thing? The JDK (with IDE support
too) and javac already handle it in its own way. ForbiddenAPI principally
exists for non-deprecated things we insi
uschindler commented on code in PR #2501:
URL: https://github.com/apache/solr/pull/2501#discussion_r1637690443
##
solr/solrj/src/test/org/apache/solr/common/util/ContentStreamTest.java:
##
@@ -161,7 +161,7 @@ public void testURLStreamCSVGZIPExtention() throws
IOException {
uschindler commented on code in PR #2501:
URL: https://github.com/apache/solr/pull/2501#discussion_r1637696933
##
solr/core/src/test/org/apache/solr/cloud/TestRequestForwarding.java:
##
@@ -69,6 +71,12 @@ public void testMultiCollectionQuery() throws Exception {
}
}
+
dsmiley commented on PR #2501:
URL: https://github.com/apache/solr/pull/2501#issuecomment-2165044084
What I love about our community is that we have so much expertise to call
upon; thanks Uwe :-)
> Forbiddenapis allows to restrict only JDK-forbidden stuff
Then lets do that and
[
https://issues.apache.org/jira/browse/SOLR-17331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yohann Callea updated SOLR-17331:
-
Description:
The test *_MigrateReplicasTest.testGoodSpreadDuringAssignWithNoTarget_* is
sometime
[
https://issues.apache.org/jira/browse/SOLR-17331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yohann Callea updated SOLR-17331:
-
Description:
The test *_MigrateReplicasTest.testGoodSpreadDuringAssignWithNoTarget_* is
sometime
Yohann Callea created SOLR-17331:
Summary:
MigrateReplicasTest.testGoodSpreadDuringAssignWithNoTarget is flaky
Key: SOLR-17331
URL: https://issues.apache.org/jira/browse/SOLR-17331
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-17331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854694#comment-17854694
]
Yohann Callea edited comment on SOLR-17331 at 6/13/24 9:51 AM:
[
https://issues.apache.org/jira/browse/SOLR-17331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854694#comment-17854694
]
Yohann Callea commented on SOLR-17331:
--
Before eventually going ahead with a fix pro
[
https://issues.apache.org/jira/browse/SOLR-17331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854694#comment-17854694
]
Yohann Callea edited comment on SOLR-17331 at 6/13/24 9:51 AM:
cpoerschke commented on code in PR #2506:
URL: https://github.com/apache/solr/pull/2506#discussion_r1638095981
##
solr/core/src/test/org/apache/solr/search/RankQueryTest.java:
##
@@ -106,4 +119,65 @@ public void testPluggableCollector() {
"//result/doc[2]/str[@name='id'
[
https://issues.apache.org/jira/browse/SOLR-17322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke reassigned SOLR-17322:
--
Assignee: Christine Poerschke
> Make RankQuery.getTopDocsCollector use covaria
[
https://issues.apache.org/jira/browse/SOLR-17322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-17322:
---
Fix Version/s: 9.7
> Make RankQuery.getTopDocsCollector use covariant generic types
>
stephen-woods commented on code in PR #2506:
URL: https://github.com/apache/solr/pull/2506#discussion_r1638116683
##
solr/core/src/test/org/apache/solr/search/RankQueryTest.java:
##
@@ -106,4 +119,65 @@ public void testPluggableCollector() {
"//result/doc[2]/str[@name='
stephen-woods commented on code in PR #2506:
URL: https://github.com/apache/solr/pull/2506#discussion_r1638116683
##
solr/core/src/test/org/apache/solr/search/RankQueryTest.java:
##
@@ -106,4 +119,65 @@ public void testPluggableCollector() {
"//result/doc[2]/str[@name='
cpoerschke commented on code in PR #2478:
URL: https://github.com/apache/solr/pull/2478#discussion_r1638122281
##
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##
@@ -151,8 +151,9 @@ public Codec getCodec() {
}
/**
- * This class exists because Lucen
cpoerschke commented on code in PR #2478:
URL: https://github.com/apache/solr/pull/2478#discussion_r1638122281
##
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##
@@ -151,8 +151,9 @@ public Codec getCodec() {
}
/**
- * This class exists because Lucen
cpoerschke commented on code in PR #2506:
URL: https://github.com/apache/solr/pull/2506#discussion_r1638137295
##
solr/core/src/test/org/apache/solr/search/RankQueryTest.java:
##
@@ -106,4 +119,65 @@ public void testPluggableCollector() {
"//result/doc[2]/str[@name='id'
cpoerschke commented on code in PR #2506:
URL: https://github.com/apache/solr/pull/2506#discussion_r1638182293
##
solr/core/src/test/org/apache/solr/search/RankQueryTest.java:
##
@@ -106,4 +119,65 @@ public void testPluggableCollector() {
"//result/doc[2]/str[@name='id'
[
https://issues.apache.org/jira/browse/SOLR-17324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854758#comment-17854758
]
Thomas Wöckinger commented on SOLR-17324:
-
It is a bit worse, as solr-solrj-zooke
atris commented on PR #313:
URL: https://github.com/apache/solr/pull/313#issuecomment-2165858080
Still working on this - have a PR in process. Will publish by weekend and
tag you for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
cpoerschke commented on code in PR #2477:
URL: https://github.com/apache/solr/pull/2477#discussion_r1638276023
##
solr/core/src/java/org/apache/solr/update/SegmentTimeLeafSorterSupplier.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/SOLR-17324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Wöckinger updated SOLR-17324:
Summary: Weird SolrJ Dependency Tree (was: Wired SolrJ Dependency Tree )
> Weird SolrJ De
cpoerschke merged PR #2478:
URL: https://github.com/apache/solr/pull/2478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
[
https://issues.apache.org/jira/browse/SOLR-17310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854761#comment-17854761
]
Christine Poerschke commented on SOLR-17310:
Following on from my
[https://g
cpoerschke commented on code in PR #2477:
URL: https://github.com/apache/solr/pull/2477#discussion_r1638294314
##
solr/core/src/java/org/apache/solr/update/SegmentTimeLeafSorterSupplier.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/SOLR-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854774#comment-17854774
]
David Smiley commented on SOLR-17332:
-
Sorry, I didn't get or read the memo that post
[
https://issues.apache.org/jira/browse/SOLR-17324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854758#comment-17854758
]
Thomas Wöckinger edited comment on SOLR-17324 at 6/13/24 3:01 PM:
-
Eric Pugh created SOLR-17332:
Summary: Remove last vestiges of post.jar from main
Key: SOLR-17332
URL: https://issues.apache.org/jira/browse/SOLR-17332
Project: Solr
Issue Type: Sub-task
psalagnac opened a new pull request, #2514:
URL: https://github.com/apache/solr/pull/2514
No Jira.
This is just to clean-up a bad smell in the code.
# Description
We create a `java.lang.Thread` instance, but this thread is never started.
It just acts as a target for anot
[
https://issues.apache.org/jira/browse/SOLR-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854779#comment-17854779
]
Eric Pugh commented on SOLR-17332:
--
* SOLR-17159: Remove deprecated bin/post and bin/pos
[
https://issues.apache.org/jira/browse/SOLR-16962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854796#comment-17854796
]
ASF subversion and git services commented on SOLR-16962:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-17330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854798#comment-17854798
]
David Smiley commented on SOLR-17330:
-
+1.
What do you think about trivially augmenti
jdyer1 commented on PR #2242:
URL: https://github.com/apache/solr/pull/2242#issuecomment-2166340661
@epugh As mentioned earlier in the PR, we can paper over this by disabling
Parallel Updates for auth tests. But the real problem in my opinion is we have
allowed SolrJ to become a server-sid
dsmiley commented on PR #2438:
URL: https://github.com/apache/solr/pull/2438#issuecomment-2166172934
Looks great. Might you suggest a succinct CHANGES.txt entry for 9.7?
CHANGES.txt is written for users to read/understand.
Also can you propose a commit message here, which often adds
magibney merged PR #1895:
URL: https://github.com/apache/solr/pull/1895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
[
https://issues.apache.org/jira/browse/SOLR-16962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854811#comment-17854811
]
ASF subversion and git services commented on SOLR-16962:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-16796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854836#comment-17854836
]
ASF subversion and git services commented on SOLR-16796:
Commit 1
Michael Gibney created SOLR-17333:
-
Summary: Various rate limiting fixes
Key: SOLR-17333
URL: https://issues.apache.org/jira/browse/SOLR-17333
Project: Solr
Issue Type: Bug
Report
[
https://issues.apache.org/jira/browse/SOLR-16962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney resolved SOLR-16962.
---
Fix Version/s: 9.7
Assignee: Michael Gibney
Resolution: Fixed
> updateLog tlo
[
https://issues.apache.org/jira/browse/SOLR-16796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854837#comment-17854837
]
ASF subversion and git services commented on SOLR-16796:
Commit 3
patsonluk commented on PR #2438:
URL: https://github.com/apache/solr/pull/2438#issuecomment-2166201555
> Looks great. Might you suggest a succinct CHANGES.txt entry for 9.7?
CHANGES.txt is written for users to read/understand.
Many thanks for all the reviews! I will add an entry to CH
[
https://issues.apache.org/jira/browse/SOLR-16796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854835#comment-17854835
]
Houston Putman commented on SOLR-16796:
---
Unfortunately I think I need to revert unt
epugh commented on PR #1768:
URL: https://github.com/apache/solr/pull/1768#issuecomment-2166319911
Okay! I believe that deprecated options are back in, so scripts shouldn't
break between 9.6 and 9.7 I would love another set of eyes and then look
to merge to main in the next few days.
[
https://issues.apache.org/jira/browse/SOLR-17331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman reassigned SOLR-17331:
-
Assignee: Houston Putman
> MigrateReplicasTest.testGoodSpreadDuringAssignWithNoTarget is
epugh commented on PR #1768:
URL: https://github.com/apache/solr/pull/1768#issuecomment-2166795214
@HoustonPutman any tips on how to validate that changes on this PR don't
impact solr operator?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
dsmiley commented on code in PR #2304:
URL: https://github.com/apache/solr/pull/2304#discussion_r1638975112
##
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java:
##
@@ -497,42 +534,23 @@ public void submitAsyncTask(TaskObject taskObject) throws
SolrExceptio
dsmiley commented on PR #2438:
URL: https://github.com/apache/solr/pull/2438#issuecomment-2166879930
Yes to both. It's helpful if you provide this info as it affords peer
review and it makes it easier for me :-)
--
This is an automated message from the Apache Git Service.
To respond to t
[
https://issues.apache.org/jira/browse/SOLR-17331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854882#comment-17854882
]
Houston Putman commented on SOLR-17331:
---
Thank you for an outstanding JIRA, I'm blo
HoustonPutman opened a new pull request, #2515:
URL: https://github.com/apache/solr/pull/2515
https://issues.apache.org/jira/browse/SOLR-17331
I've also added and re-arranged tests as-per the Jira comments.
--
This is an automated message from the Apache Git Service.
To respond to t
gus-asf commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2166986928
Am on vacation this week, will try to look Sunday after I get back.
On Tue, Jun 11, 2024 at 7:40 PM Hitesh Khamesra ***@***.***>
wrote:
> ***@***. commented on this pull r
patsonluk commented on PR #2438:
URL: https://github.com/apache/solr/pull/2438#issuecomment-2167020499
@dsmiley
CHANGES.txt updated
Commit message:
```
Removed logic that registers the synthetic collection/core of Coordinator
node to zookeeper, this simplifies the code f
53 matches
Mail list logo
